From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: mingo@redhat.com, juri.lelli@redhat.com,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
linux-kernel@vger.kernel.org, pierre.gondois@arm.com,
kprateek.nayak@amd.com, qyousef@layalina.io,
hongyan.xia2@arm.com, christian.loehle@arm.com,
luis.machado@arm.com
Subject: Re: [PATCH 4/6 v8] sched/fair: Add push task mechanism for fair
Date: Thu, 4 Dec 2025 11:46:09 +0100 [thread overview]
Message-ID: <20251204104609.GH2528459@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20251202181242.1536213-5-vincent.guittot@linaro.org>
On Tue, Dec 02, 2025 at 07:12:40PM +0100, Vincent Guittot wrote:
> +static void fair_add_pushable_task(struct rq *rq, struct task_struct *p)
> +{
> + if (sched_push_task_enabled() && fair_push_task(rq, p)) {
> + plist_del(&p->pushable_tasks, &rq->cfs.pushable_tasks);
> + plist_node_init(&p->pushable_tasks, p->prio);
> + plist_add(&p->pushable_tasks, &rq->cfs.pushable_tasks);
> + }
> +}
I might have asked before, but if there was an answer, I have forgotten
:/
Why is this a prio-list? It seems to me that we don't particularly care
about keeping this push sorted by nice value, right?
next prev parent reply other threads:[~2025-12-04 10:46 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 18:12 [PATCH 0/6 v8] sched/fair: Add push task mechanism and handle more EAS cases Vincent Guittot
2025-12-02 18:12 ` [PATCH 1/6 v8] sched/fair: Filter false overloaded_group case for EAS Vincent Guittot
2025-12-02 18:12 ` [PATCH 2/6 v8] sched/fair: Update overutilized detection Vincent Guittot
2026-02-06 17:42 ` Qais Yousef
2025-12-02 18:12 ` [PATCH 3/6 v8] sched/fair: Prepare select_task_rq_fair() to be called for new cases Vincent Guittot
2025-12-07 13:23 ` Shrikanth Hegde
2026-02-09 13:21 ` Vincent Guittot
2026-02-06 18:03 ` Qais Yousef
2026-02-09 13:21 ` Vincent Guittot
2025-12-02 18:12 ` [PATCH 4/6 v8] sched/fair: Add push task mechanism for fair Vincent Guittot
2025-12-04 10:46 ` Peter Zijlstra [this message]
2025-12-04 14:32 ` Vincent Guittot
2025-12-04 11:29 ` Peter Zijlstra
2025-12-04 14:34 ` Vincent Guittot
2025-12-05 8:59 ` Peter Zijlstra
2025-12-05 12:49 ` K Prateek Nayak
2025-12-05 12:56 ` Peter Zijlstra
2025-12-05 13:05 ` K Prateek Nayak
2025-12-05 13:36 ` Vincent Guittot
2025-12-06 3:08 ` K Prateek Nayak
2025-12-05 13:26 ` Vincent Guittot
2025-12-07 12:13 ` Shrikanth Hegde
2026-02-09 13:17 ` Vincent Guittot
2025-12-10 14:01 ` Dietmar Eggemann
2026-02-09 13:17 ` Vincent Guittot
2026-02-06 18:21 ` Qais Yousef
2026-02-09 13:18 ` Vincent Guittot
2025-12-02 18:12 ` [RFC PATCH 5/6 v8] sched/fair: Enable idle core tracking for !SMT Vincent Guittot
2025-12-05 15:52 ` Christian Loehle
2025-12-06 2:11 ` Chen, Yu C
2025-12-06 10:18 ` Vincent Guittot
2025-12-06 10:09 ` Vincent Guittot
2025-12-08 18:43 ` Christian Loehle
2025-12-02 18:12 ` [RFC PATCH 6/6 v8] sched/fair: Add EAS and idle cpu push trigger Vincent Guittot
2026-02-06 18:30 ` Qais Yousef
2026-02-09 13:20 ` Vincent Guittot
2026-02-11 0:59 ` Qais Yousef
2025-12-03 14:06 ` [PATCH 0/6 v8] sched/fair: Add push task mechanism and handle more EAS cases Christian Loehle
2025-12-10 13:30 ` Dietmar Eggemann
2026-02-06 18:32 ` Qais Yousef
2026-02-09 13:20 ` Vincent Guittot
2026-02-26 17:34 ` Pierre Gondois
2026-03-10 4:16 ` Qais Yousef
2026-03-10 10:27 ` Pierre Gondois
2026-03-10 15:11 ` Qais Yousef
2026-03-10 16:59 ` Pierre Gondois
2026-03-12 8:19 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251204104609.GH2528459@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=christian.loehle@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=hongyan.xia2@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luis.machado@arm.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=pierre.gondois@arm.com \
--cc=qyousef@layalina.io \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®