From: "René Rebe" <rene@exactco.de>
To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Dave Airlie <airlied@redhat.com>,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH V2] drm/mgag200: Fix big-endian support
Date: Fri, 05 Dec 2025 18:24:05 +0100 (CET) [thread overview]
Message-ID: <20251205.182405.876575799174263183.rene@exactco.de> (raw)
Unlike the original, deleted Matrox mga driver, the new mgag200 driver
has the XRGB frame-buffer byte swapped on big-endian "RISC"
systems. Fix by enabling byte swapping "PowerPC" OPMODE for any
__BIG_ENDIAN config.
Fixes: 414c45310625 ("mgag200: initial g200se driver (v2)")
Signed-off-by: René Rebe <rene@exactco.de>
Cc: stable@kernel.org
---
V2: move to atomic_update
Tested on IBM 43p Model 150 (7043-150) running T2/Linux.
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
index 951d715dea30..d40434ec68ab 100644
--- a/drivers/gpu/drm/mgag200/mgag200_mode.c
+++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
@@ -496,6 +496,20 @@ void mgag200_primary_plane_helper_atomic_update(struct drm_plane *plane,
struct drm_atomic_helper_damage_iter iter;
struct drm_rect damage;
+#ifdef __BIG_ENDIAN
+ /* Big-endian byte-swapping */
+ switch (fb->format->format) {
+ case DRM_FORMAT_RGB565:
+ WREG32(MGAREG_OPMODE, 0x10100);
+ break;
+ case DRM_FORMAT_XRGB8888:
+ WREG32(MGAREG_OPMODE, 0x20200);
+ break;
+ default:
+ break;
+ }
+#endif
+
drm_atomic_helper_damage_iter_init(&iter, old_plane_state, plane_state);
drm_atomic_for_each_plane_damage(&iter, &damage) {
mgag200_handle_damage(mdev, shadow_plane_state->data, fb, &damage);
--
2.52.0
--
René Rebe, ExactCODE GmbH, Berlin, Germany
https://exactco.de • https://t2linux.com • https://patreon.com/renerebe
next reply other threads:[~2025-12-05 17:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 17:24 René Rebe [this message]
2025-12-08 8:29 ` Thomas Zimmermann
2025-12-08 12:39 ` René Rebe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251205.182405.876575799174263183.rene@exactco.de \
--to=rene@exactco.de \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®