mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jinhui Guo" <guojinhui.liam@bytedance.com>
To: <corey@minyard.net>
Cc: <guojinhui.liam@bytedance.com>, <linux-kernel@vger.kernel.org>,
	 <openipmi-developer@lists.sourceforge.net>
Subject: Re: [PATCH v2 0/3] ipmi: Close the race between __scan_channels() and deliver_response()
Date: Fri,  5 Dec 2025 16:01:02 +0800	[thread overview]
Message-ID: <20251205080102.1039-1-guojinhui.liam@bytedance.com> (raw)
In-Reply-To: <aN_vFKhMi0tDT2rK@mail.minyard.net>

On Fri, Oct 3, 2025 at 10:43:16AM -0500, Corey Minyard wrote:
> On Tue, Sep 30, 2025 at 03:42:36PM +0800, Jinhui Guo wrote:
> > The command "ipmi -b -t" would occasionally fail:
> >   #ipmitool -b 6 -t 0x2c raw 0x6 0x01
> >   Unable to send command: Invalid argument
> >   Unable to send RAW command (channel=0x6 netfn=0x6 lun=0x0 cmd=0x1)
> > 
> > The race window between __scan_channels() and deliver_response() causes
> > the parameters of some channels to be set to 0.
> > 
> > Fix the race between __scan_channels() and deliver_response() with the
> > following changes.
> > 
> > 1. Only assign intf->channel_list = intf->wchannels and set
> >    intf->channels_ready = true in channel_handler() after all channels_ready
> >    have been successfully scanned or after failing to send the IPMI
> >    request.
> > 2. channel_handler() sets intf->channels_ready to true but no one clears
> >    it, preventing __scan_channels() from rescanning channels. When the BMC
> >    firmware changes a rescan is required. Allow it by clearing the flag
> >    before starting a new scan.
> > 3. Channels remain static unless the BMC firmware changes. Skip channel
> >    rescan when no BMC firmware update has occurred.
> > 
> > 
> > v1: https://lore.kernel.org/all/20250929081602.1901-1-guojinhui.liam@bytedance.com/
> > 
> > Changelog in v1 -> v2 (suggested by corey):
> >  - Split the fix into three independent patches, each addressing a
> >    separate issue.
> >  - Clear intf->channels_ready only when the BMC firmware changes.
> > 
> > Jinhui Guo (3):
> >   ipmi: Fix the race between __scan_channels() and deliver_response()
> >   ipmi: Fix __scan_channels() failing to rescan channels
> >   ipmi: Skip channel scan if channels are already marked ready

> I have these queued for 6.18.  I need to re-review them; that will
> probably happen later in the cycle; I can't put them in until 6.17-rc1
> releases.

> Thanks,

> -corey

Hi, corey

Friendly ping — please let me know if you need anything else (rebase, more review,
test results) and I’ll be happy to take care of it.

Thanks for your time, and sorry for the noise.

Best regards,
Jinhui

> > 
> >  drivers/char/ipmi/ipmi_msghandler.c | 24 +++++++++++++++++-------
> >  1 file changed, 17 insertions(+), 7 deletions(-)
> > 
> > -- 
> > 2.20.1
> >

  reply	other threads:[~2025-12-05  8:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-30  7:42 Jinhui Guo
2025-09-30  7:42 ` [PATCH v2 1/3] ipmi: Fix " Jinhui Guo
2025-09-30  7:42 ` [PATCH v2 2/3] ipmi: Fix __scan_channels() failing to rescan channels Jinhui Guo
2025-09-30  7:42 ` [PATCH v2 3/3] ipmi: Skip channel scan if channels are already marked ready Jinhui Guo
2025-10-03 15:43 ` [PATCH v2 0/3] ipmi: Close the race between __scan_channels() and deliver_response() Corey Minyard
2025-12-05  8:01   ` Jinhui Guo [this message]
2025-12-05 13:05     ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251205080102.1039-1-guojinhui.liam@bytedance.com \
    --to=guojinhui.liam@bytedance.com \
    --cc=corey@minyard.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®