mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: lee@kernel.org, linux-kernel@vger.kernel.org, sre@kernel.org
Subject: Re: [PATCH] mfd: bd71828: Add some missing charger related registers
Date: Tue, 9 Dec 2025 10:21:49 +0100	[thread overview]
Message-ID: <20251209102149.30c7ce19@kemnade.info> (raw)
In-Reply-To: <20389a09-1c69-40fa-a937-289a104d57fa@gmail.com>

On Mon, 8 Dec 2025 09:47:43 +0200
Matti Vaittinen <mazziesaccount@gmail.com> wrote:

> On 07/12/2025 10:50, Andreas Kemnade wrote:
> > As there are some registers missing which are required for future charger
> > extensions, add them.
> > 
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>  
> 
> Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
> 
> Thanks for working with this driver! Much appreciated :)
> 
[...]
> I asked for some clarification from the HQ folks - but they may be quite 
> busy, and my request(s) may not be at the top of the priority list. So, 
> let's see...
> 
> Are you planning to expose the current limit values to user-space? Allow 
> setting the control to AUTO/fixed value? I suppose this is what enabled 
> you to do some low-power charging, right?
> 
I am thinking about adding input_current_limit property and providing the
ILIM_DCIN_EN as a custom sysfs property like maybe "auto_input_current_limitation"

I had issues with using my bike hub dynamo and some solar panels
without any additional batteries in between, just  regulator (and
in the bike hub dynamo, of course a rectifier with a smoothing capacitor).
I would expect to just see the current limited so that voltage stays at the
anticollapse voltage, but that is not the case.
I have solved the problem with clearing ILIM_DCIN_EN and setting current
accordingly (often to something like 0.4A). I will try to use the next sun ray
arriving here to recheck. I have created a script to manipulate
things using i2cset in a lonely place in nature where I obviously
did not want to spend time with datasheets as short as possible.

The key point is not only low-power charging but also power sources with
changing properties.

Regards,
Andreas

  parent reply	other threads:[~2025-12-09  9:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-07  8:50 Andreas Kemnade
2025-12-08  7:47 ` Matti Vaittinen
2025-12-08  8:20   ` Matti Vaittinen
2025-12-09  9:21   ` Andreas Kemnade [this message]
2026-01-08 11:18 ` (subset) " Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251209102149.30c7ce19@kemnade.info \
    --to=andreas@kemnade.info \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mazziesaccount@gmail.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®