* [PATCH] wifi: rtw89: add WQ_PERCPU to alloc_workqueue users
@ 2025-12-10 10:12 Marco Crivellari
2025-12-23 3:47 ` Ping-Ke Shih
0 siblings, 1 reply; 3+ messages in thread
From: Marco Crivellari @ 2025-12-10 10:12 UTC (permalink / raw)
To: linux-kernel, linux-wireless
Cc: Tejun Heo, Lai Jiangshan, Frederic Weisbecker,
Sebastian Andrzej Siewior, Marco Crivellari, Michal Hocko,
Ping-Ke Shih
This continues the effort to refactor workqueue APIs, which began with
the introduction of new workqueues and a new alloc_workqueue flag in:
commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")
The refactoring is going to alter the default behavior of
alloc_workqueue() to be unbound by default.
With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND),
any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND
must now use WQ_PERCPU. For more details see the Link tag below.
In order to keep alloc_workqueue() behavior identical, explicitly request
WQ_PERCPU.
Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Link: https://lore.kernel.org/all/20250221112003.1dSuoGyc@linutronix.de/
---
drivers/net/wireless/realtek/rtw89/usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw89/usb.c b/drivers/net/wireless/realtek/rtw89/usb.c
index d7d968207a39..e77561a4d971 100644
--- a/drivers/net/wireless/realtek/rtw89/usb.c
+++ b/drivers/net/wireless/realtek/rtw89/usb.c
@@ -620,7 +620,7 @@ static int rtw89_usb_init_rx(struct rtw89_dev *rtwdev)
struct sk_buff *rx_skb;
int i;
- rtwusb->rxwq = alloc_workqueue("rtw89_usb: rx wq", WQ_BH, 0);
+ rtwusb->rxwq = alloc_workqueue("rtw89_usb: rx wq", WQ_BH | WQ_PERCPU, 0);
if (!rtwusb->rxwq) {
rtw89_err(rtwdev, "failed to create RX work queue\n");
return -ENOMEM;
--
2.52.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] wifi: rtw89: add WQ_PERCPU to alloc_workqueue users
2025-12-10 10:12 [PATCH] wifi: rtw89: add WQ_PERCPU to alloc_workqueue users Marco Crivellari
@ 2025-12-23 3:47 ` Ping-Ke Shih
2025-12-23 14:27 ` Marco Crivellari
0 siblings, 1 reply; 3+ messages in thread
From: Ping-Ke Shih @ 2025-12-23 3:47 UTC (permalink / raw)
To: Marco Crivellari, linux-kernel, linux-wireless
Cc: Tejun Heo, Lai Jiangshan, Frederic Weisbecker,
Sebastian Andrzej Siewior, Marco Crivellari, Michal Hocko,
Ping-Ke Shih
Marco Crivellari <marco.crivellari@suse.com> wrote:
> This continues the effort to refactor workqueue APIs, which began with
> the introduction of new workqueues and a new alloc_workqueue flag in:
>
> commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
> commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")
>
> The refactoring is going to alter the default behavior of
> alloc_workqueue() to be unbound by default.
>
> With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND),
> any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND
> must now use WQ_PERCPU. For more details see the Link tag below.
>
> In order to keep alloc_workqueue() behavior identical, explicitly request
> WQ_PERCPU.
>
> Suggested-by: Tejun Heo <tj@kernel.org>
> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
> Link: https://lore.kernel.org/all/20250221112003.1dSuoGyc@linutronix.de/
1 patch(es) applied to rtw-next branch of rtw.git, thanks.
36f2deb2f55f wifi: rtw89: add WQ_PERCPU to alloc_workqueue users
---
https://github.com/pkshih/rtw.git
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] wifi: rtw89: add WQ_PERCPU to alloc_workqueue users
2025-12-23 3:47 ` Ping-Ke Shih
@ 2025-12-23 14:27 ` Marco Crivellari
0 siblings, 0 replies; 3+ messages in thread
From: Marco Crivellari @ 2025-12-23 14:27 UTC (permalink / raw)
To: Ping-Ke Shih
Cc: linux-kernel, linux-wireless, Tejun Heo, Lai Jiangshan,
Frederic Weisbecker, Sebastian Andrzej Siewior, Michal Hocko
On Tue, Dec 23, 2025 at 4:48 AM Ping-Ke Shih <pkshih@realtek.com> wrote:
> 1 patch(es) applied to rtw-next branch of rtw.git, thanks.
>
> 36f2deb2f55f wifi: rtw89: add WQ_PERCPU to alloc_workqueue users
Many thanks!
--
Marco Crivellari
L3 Support Engineer
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-23 14:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-10 10:12 [PATCH] wifi: rtw89: add WQ_PERCPU to alloc_workqueue users Marco Crivellari
2025-12-23 3:47 ` Ping-Ke Shih
2025-12-23 14:27 ` Marco Crivellari
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®