* [PATCH 0/2] ASoC: fsl_easrc: Fix duplicate debufs entries
@ 2025-12-16 9:40 Alexander Stein
2025-12-16 9:40 ` [PATCH 1/2] ASoC: fsl_easrc: fix duplicate debugfs directory error Alexander Stein
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Alexander Stein @ 2025-12-16 9:40 UTC (permalink / raw)
To: Shengjiu Wang, Xiubo Li, Fabio Estevam, Nicolin Chen,
Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai
Cc: Alexander Stein, linux-sound, linuxppc-dev, linux-kernel
Hi,
this series fixes the error regarding duplicate debugfs directory creation on
TQMa8MPxL (imx8mp) when easrc is enabled:
debugfs: '30c90000.easrc' already exists in 'tqm-tlv320aic32'
This is caused because fsl_easrc adds two components which use the device name
as component name. Debugfs directories for each component is created, resulting
on name conflict. Fix this by adding the debugfs_prefix for both component
drivers.
Before:
$ ls /sys/kernel/debug/asoc/tqm-tlv320aic32/
30c30000.sai 30c90000.easrc HiFi-ASRC-FE dapm dapm_pop_time
dma:30c30000.sai tlv320aic32x4.1-0018
After:
$ ls /sys/kernel/debug/asoc/tqm-tlv320aic32/
30c30000.sai HiFi-ASRC-FE asrc:30c90000.easrc dapm dapm_pop_time
dma:30c30000.sai easrc:30c90000.easrc tlv320aic32x4.1-0018
Best regards,
Alexander
Alexander Stein (2):
ASoC: fsl_easrc: fix duplicate debugfs directory error
ASoC: fsl_asrc_dma: fix duplicate debugfs directory error
sound/soc/fsl/fsl_asrc_dma.c | 3 +++
sound/soc/fsl/fsl_easrc.c | 3 +++
2 files changed, 6 insertions(+)
--
2.43.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] ASoC: fsl_easrc: fix duplicate debugfs directory error
2025-12-16 9:40 [PATCH 0/2] ASoC: fsl_easrc: Fix duplicate debufs entries Alexander Stein
@ 2025-12-16 9:40 ` Alexander Stein
2025-12-16 9:40 ` [PATCH 2/2] ASoC: fsl_asrc_dma: " Alexander Stein
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Alexander Stein @ 2025-12-16 9:40 UTC (permalink / raw)
To: Shengjiu Wang, Xiubo Li, Fabio Estevam, Nicolin Chen,
Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai
Cc: Alexander Stein, linux-sound, linuxppc-dev, linux-kernel
This driver registers two components: asrc and easrc, both attached using
the device name as component name. Eventually debugfs directories with
identical name are created in soc_init_component_debugfs(), leading to
error message:
debugfs: '30c90000.easrc' already exists in 'tqm-tlv320aic32'
Fix this by adding the debugfs_prefix.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
sound/soc/fsl/fsl_easrc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/fsl/fsl_easrc.c b/sound/soc/fsl/fsl_easrc.c
index f404a39009e1a..e64a0d97afd0c 100644
--- a/sound/soc/fsl/fsl_easrc.c
+++ b/sound/soc/fsl/fsl_easrc.c
@@ -1577,6 +1577,9 @@ static const struct snd_soc_component_driver fsl_easrc_component = {
.controls = fsl_easrc_snd_controls,
.num_controls = ARRAY_SIZE(fsl_easrc_snd_controls),
.legacy_dai_naming = 1,
+#ifdef CONFIG_DEBUG_FS
+ .debugfs_prefix = "easrc",
+#endif
};
static const struct reg_default fsl_easrc_reg_defaults[] = {
--
2.43.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] ASoC: fsl_asrc_dma: fix duplicate debugfs directory error
2025-12-16 9:40 [PATCH 0/2] ASoC: fsl_easrc: Fix duplicate debufs entries Alexander Stein
2025-12-16 9:40 ` [PATCH 1/2] ASoC: fsl_easrc: fix duplicate debugfs directory error Alexander Stein
@ 2025-12-16 9:40 ` Alexander Stein
2025-12-16 13:40 ` [PATCH 0/2] ASoC: fsl_easrc: Fix duplicate debufs entries Fabio Estevam
2025-12-19 14:09 ` Mark Brown
3 siblings, 0 replies; 5+ messages in thread
From: Alexander Stein @ 2025-12-16 9:40 UTC (permalink / raw)
To: Shengjiu Wang, Xiubo Li, Fabio Estevam, Nicolin Chen,
Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai
Cc: Alexander Stein, linux-sound, linuxppc-dev, linux-kernel
This driver registers a component for asrc. This is also used together
with easrc, both attached using the device name as component name.
Eventually debugfs directories with identical name are created in
soc_init_component_debugfs(), leading to error message:
debugfs: '30c90000.easrc' already exists in 'tqm-tlv320aic32'
Fix this by adding the debugfs_prefix.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
sound/soc/fsl/fsl_asrc_dma.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/fsl/fsl_asrc_dma.c b/sound/soc/fsl/fsl_asrc_dma.c
index 1bba48318e2dd..7dacc06b2f02e 100644
--- a/sound/soc/fsl/fsl_asrc_dma.c
+++ b/sound/soc/fsl/fsl_asrc_dma.c
@@ -473,5 +473,8 @@ struct snd_soc_component_driver fsl_asrc_component = {
.pointer = fsl_asrc_dma_pcm_pointer,
.pcm_construct = fsl_asrc_dma_pcm_new,
.legacy_dai_naming = 1,
+#ifdef CONFIG_DEBUG_FS
+ .debugfs_prefix = "asrc",
+#endif
};
EXPORT_SYMBOL_GPL(fsl_asrc_component);
--
2.43.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] ASoC: fsl_easrc: Fix duplicate debufs entries
2025-12-16 9:40 [PATCH 0/2] ASoC: fsl_easrc: Fix duplicate debufs entries Alexander Stein
2025-12-16 9:40 ` [PATCH 1/2] ASoC: fsl_easrc: fix duplicate debugfs directory error Alexander Stein
2025-12-16 9:40 ` [PATCH 2/2] ASoC: fsl_asrc_dma: " Alexander Stein
@ 2025-12-16 13:40 ` Fabio Estevam
2025-12-19 14:09 ` Mark Brown
3 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2025-12-16 13:40 UTC (permalink / raw)
To: Alexander Stein
Cc: Shengjiu Wang, Xiubo Li, Nicolin Chen, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, linux-sound, linuxppc-dev,
linux-kernel
Hi Alexander,
On Tue, Dec 16, 2025 at 6:41 AM Alexander Stein
<alexander.stein@ew.tq-group.com> wrote:
>
> Hi,
>
> this series fixes the error regarding duplicate debugfs directory creation on
> TQMa8MPxL (imx8mp) when easrc is enabled:
> debugfs: '30c90000.easrc' already exists in 'tqm-tlv320aic32'
>
> This is caused because fsl_easrc adds two components which use the device name
> as component name. Debugfs directories for each component is created, resulting
> on name conflict. Fix this by adding the debugfs_prefix for both component
> drivers.
>
> Before:
> $ ls /sys/kernel/debug/asoc/tqm-tlv320aic32/
> 30c30000.sai 30c90000.easrc HiFi-ASRC-FE dapm dapm_pop_time
> dma:30c30000.sai tlv320aic32x4.1-0018
>
> After:
> $ ls /sys/kernel/debug/asoc/tqm-tlv320aic32/
> 30c30000.sai HiFi-ASRC-FE asrc:30c90000.easrc dapm dapm_pop_time
> dma:30c30000.sai easrc:30c90000.easrc tlv320aic32x4.1-0018
Thanks for fixing these error messages.
For the series:
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] ASoC: fsl_easrc: Fix duplicate debufs entries
2025-12-16 9:40 [PATCH 0/2] ASoC: fsl_easrc: Fix duplicate debufs entries Alexander Stein
` (2 preceding siblings ...)
2025-12-16 13:40 ` [PATCH 0/2] ASoC: fsl_easrc: Fix duplicate debufs entries Fabio Estevam
@ 2025-12-19 14:09 ` Mark Brown
3 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2025-12-19 14:09 UTC (permalink / raw)
To: Shengjiu Wang, Xiubo Li, Fabio Estevam, Nicolin Chen,
Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Alexander Stein
Cc: linux-sound, linuxppc-dev, linux-kernel
On Tue, 16 Dec 2025 10:40:41 +0100, Alexander Stein wrote:
> this series fixes the error regarding duplicate debugfs directory creation on
> TQMa8MPxL (imx8mp) when easrc is enabled:
> debugfs: '30c90000.easrc' already exists in 'tqm-tlv320aic32'
>
> This is caused because fsl_easrc adds two components which use the device name
> as component name. Debugfs directories for each component is created, resulting
> on name conflict. Fix this by adding the debugfs_prefix for both component
> drivers.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/2] ASoC: fsl_easrc: fix duplicate debugfs directory error
commit: 9f5f3583ba423e6eed0a96e4d4b7d808d618f3aa
[2/2] ASoC: fsl_asrc_dma: fix duplicate debugfs directory error
commit: 4de6cea0d8e10c9e3f38ccff7edd45891976e67a
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-12-19 14:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-16 9:40 [PATCH 0/2] ASoC: fsl_easrc: Fix duplicate debufs entries Alexander Stein
2025-12-16 9:40 ` [PATCH 1/2] ASoC: fsl_easrc: fix duplicate debugfs directory error Alexander Stein
2025-12-16 9:40 ` [PATCH 2/2] ASoC: fsl_asrc_dma: " Alexander Stein
2025-12-16 13:40 ` [PATCH 0/2] ASoC: fsl_easrc: Fix duplicate debufs entries Fabio Estevam
2025-12-19 14:09 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®