From: Xiaoyao Li <xiaoyao.li@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>, Tony Luck <tony.luck@intel.com>,
linux-kernel@vger.kernel.org, xiaoyao.li@intel.com
Subject: [PATCH 1/2] x86/split_lock: Fix handling in split_lock_init()
Date: Thu, 18 Dec 2025 16:00:43 +0800 [thread overview]
Message-ID: <20251218080044.2615106-2-xiaoyao.li@intel.com> (raw)
In-Reply-To: <20251218080044.2615106-1-xiaoyao.li@intel.com>
Per commit 009bce1df0bb ("x86/split_lock: Don't write MSR_TEST_CTRL on
CPUs that aren't whitelisted"), cpu_model_supports_sld was introduced to
guard writes on MSR_TEST_CTRL in split_lock_init(). However, the
sld_ratelimit case handling added later was not covered by the
cpu_model_supports_sld check.
Fix this by checking cpu_model_supports_sld at the beginning of
split_lock_init().
Fixes: ef4ae6e44131 ("x86/bus_lock: Set rate limit for bus lock")
Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
---
arch/x86/kernel/cpu/bus_lock.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/bus_lock.c b/arch/x86/kernel/cpu/bus_lock.c
index dbc99a47be45..28bf208b92cb 100644
--- a/arch/x86/kernel/cpu/bus_lock.c
+++ b/arch/x86/kernel/cpu/bus_lock.c
@@ -169,6 +169,9 @@ static void sld_update_msr(bool on)
void split_lock_init(void)
{
+ if (!cpu_model_supports_sld)
+ return;
+
/*
* #DB for bus lock handles ratelimit and #AC for split lock is
* disabled.
@@ -178,8 +181,7 @@ void split_lock_init(void)
return;
}
- if (cpu_model_supports_sld)
- split_lock_verify_msr(sld_state != sld_off);
+ split_lock_verify_msr(sld_state != sld_off);
}
static void __split_lock_reenable_unlock(struct work_struct *work)
--
2.43.0
next prev parent reply other threads:[~2025-12-18 8:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 8:00 [PATCH 0/2] x86/split_lock: Fix and cleanup of cpu_model_supports_sld Xiaoyao Li
2025-12-18 8:00 ` Xiaoyao Li [this message]
2025-12-18 8:00 ` [PATCH 2/2] x86/split_lock: Drop cpu_model_supports_sld Xiaoyao Li
2026-03-06 2:59 ` [PATCH 0/2] x86/split_lock: Fix and cleanup of cpu_model_supports_sld Xiaoyao Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251218080044.2615106-2-xiaoyao.li@intel.com \
--to=xiaoyao.li@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®