mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v5] x86/headers: Replace __ASSEMBLY__ stragglers with __ASSEMBLER__
@ 2025-12-18 18:20 Thomas Huth
  2026-02-12 19:12 ` Thomas Huth
  2026-02-23 10:25 ` [tip: x86/urgent] " tip-bot2 for Thomas Huth
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2025-12-18 18:20 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen
  Cc: x86, H. Peter Anvin, Peter Zijlstra, linux-kernel

From: Thomas Huth <thuth@redhat.com>

After converting the __ASSEMBLY__ statements to __ASSEMBLER__ in
commit 24a295e4ef1ca ("x86/headers: Replace __ASSEMBLY__ with
__ASSEMBLER__ in non-UAPI headers"), some new code has been
added that uses __ASSEMBLY__ again. Convert these stragglers, too.

This is a mechanical patch, done with a simple "sed -i" command.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 v5: Fix new occurances in bug.h

 arch/x86/include/asm/bug.h           | 6 +++---
 arch/x86/include/asm/irqflags.h      | 4 ++--
 arch/x86/include/asm/percpu.h        | 2 +-
 arch/x86/include/asm/runtime-const.h | 6 +++---
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/x86/include/asm/bug.h b/arch/x86/include/asm/bug.h
index d561a8443c137..e9987061598b3 100644
--- a/arch/x86/include/asm/bug.h
+++ b/arch/x86/include/asm/bug.h
@@ -7,7 +7,7 @@
 #include <linux/objtool.h>
 #include <asm/asm.h>
 
-#ifndef __ASSEMBLY__
+#ifndef __ASSEMBLER__
 struct bug_entry;
 extern void __WARN_trap(struct bug_entry *bug, ...);
 #endif
@@ -137,7 +137,7 @@ do {									\
 
 #ifdef HAVE_ARCH_BUG_FORMAT_ARGS
 
-#ifndef __ASSEMBLY__
+#ifndef __ASSEMBLER__
 #include <linux/static_call_types.h>
 DECLARE_STATIC_CALL(WARN_trap, __WARN_trap);
 
@@ -153,7 +153,7 @@ struct arch_va_list {
 	struct sysv_va_list args;
 };
 extern void *__warn_args(struct arch_va_list *args, struct pt_regs *regs);
-#endif /* __ASSEMBLY__ */
+#endif /* __ASSEMBLER__ */
 
 #define __WARN_bug_entry(flags, format) ({				\
 	struct bug_entry *bug;						\
diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h
index b30e5474c18e1..5feaac1d235f0 100644
--- a/arch/x86/include/asm/irqflags.h
+++ b/arch/x86/include/asm/irqflags.h
@@ -77,7 +77,7 @@ static __always_inline void native_local_irq_restore(unsigned long flags)
 #endif
 
 #ifndef CONFIG_PARAVIRT
-#ifndef __ASSEMBLY__
+#ifndef __ASSEMBLER__
 /*
  * Used in the idle loop; sti takes one instruction cycle
  * to complete:
@@ -95,7 +95,7 @@ static __always_inline void halt(void)
 {
 	native_halt();
 }
-#endif /* __ASSEMBLY__ */
+#endif /* __ASSEMBLER__ */
 #endif /* CONFIG_PARAVIRT */
 
 #ifdef CONFIG_PARAVIRT_XXL
diff --git a/arch/x86/include/asm/percpu.h b/arch/x86/include/asm/percpu.h
index 725d0eff7acdf..50f73a8df7f6c 100644
--- a/arch/x86/include/asm/percpu.h
+++ b/arch/x86/include/asm/percpu.h
@@ -20,7 +20,7 @@
 
 #define PER_CPU_VAR(var)	__percpu(var)__percpu_rel
 
-#else /* !__ASSEMBLY__: */
+#else /* !__ASSEMBLER__: */
 
 #include <linux/args.h>
 #include <linux/bits.h>
diff --git a/arch/x86/include/asm/runtime-const.h b/arch/x86/include/asm/runtime-const.h
index e5a13dc8816e2..4cd94fdcb45e2 100644
--- a/arch/x86/include/asm/runtime-const.h
+++ b/arch/x86/include/asm/runtime-const.h
@@ -6,7 +6,7 @@
   #error "Cannot use runtime-const infrastructure from modules"
 #endif
 
-#ifdef __ASSEMBLY__
+#ifdef __ASSEMBLER__
 
 .macro RUNTIME_CONST_PTR sym reg
 	movq	$0x0123456789abcdef, %\reg
@@ -16,7 +16,7 @@
 	.popsection
 .endm
 
-#else /* __ASSEMBLY__ */
+#else /* __ASSEMBLER__ */
 
 #define runtime_const_ptr(sym) ({				\
 	typeof(sym) __ret;					\
@@ -74,5 +74,5 @@ static inline void runtime_const_fixup(void (*fn)(void *, unsigned long),
 	}
 }
 
-#endif /* __ASSEMBLY__ */
+#endif /* __ASSEMBLER__ */
 #endif
-- 
2.52.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v5] x86/headers: Replace __ASSEMBLY__ stragglers with __ASSEMBLER__
  2025-12-18 18:20 [PATCH v5] x86/headers: Replace __ASSEMBLY__ stragglers with __ASSEMBLER__ Thomas Huth
@ 2026-02-12 19:12 ` Thomas Huth
  2026-02-23 10:25 ` [tip: x86/urgent] " tip-bot2 for Thomas Huth
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2026-02-12 19:12 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen
  Cc: x86, H. Peter Anvin, Peter Zijlstra, linux-kernel

On 18/12/2025 19.20, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> After converting the __ASSEMBLY__ statements to __ASSEMBLER__ in
> commit 24a295e4ef1ca ("x86/headers: Replace __ASSEMBLY__ with
> __ASSEMBLER__ in non-UAPI headers"), some new code has been
> added that uses __ASSEMBLY__ again. Convert these stragglers, too.
> 
> This is a mechanical patch, done with a simple "sed -i" command.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   v5: Fix new occurances in bug.h

Friendly ping!

  Thomas

>   arch/x86/include/asm/bug.h           | 6 +++---
>   arch/x86/include/asm/irqflags.h      | 4 ++--
>   arch/x86/include/asm/percpu.h        | 2 +-
>   arch/x86/include/asm/runtime-const.h | 6 +++---
>   4 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/x86/include/asm/bug.h b/arch/x86/include/asm/bug.h
> index d561a8443c137..e9987061598b3 100644
> --- a/arch/x86/include/asm/bug.h
> +++ b/arch/x86/include/asm/bug.h
> @@ -7,7 +7,7 @@
>   #include <linux/objtool.h>
>   #include <asm/asm.h>
>   
> -#ifndef __ASSEMBLY__
> +#ifndef __ASSEMBLER__
>   struct bug_entry;
>   extern void __WARN_trap(struct bug_entry *bug, ...);
>   #endif
> @@ -137,7 +137,7 @@ do {									\
>   
>   #ifdef HAVE_ARCH_BUG_FORMAT_ARGS
>   
> -#ifndef __ASSEMBLY__
> +#ifndef __ASSEMBLER__
>   #include <linux/static_call_types.h>
>   DECLARE_STATIC_CALL(WARN_trap, __WARN_trap);
>   
> @@ -153,7 +153,7 @@ struct arch_va_list {
>   	struct sysv_va_list args;
>   };
>   extern void *__warn_args(struct arch_va_list *args, struct pt_regs *regs);
> -#endif /* __ASSEMBLY__ */
> +#endif /* __ASSEMBLER__ */
>   
>   #define __WARN_bug_entry(flags, format) ({				\
>   	struct bug_entry *bug;						\
> diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h
> index b30e5474c18e1..5feaac1d235f0 100644
> --- a/arch/x86/include/asm/irqflags.h
> +++ b/arch/x86/include/asm/irqflags.h
> @@ -77,7 +77,7 @@ static __always_inline void native_local_irq_restore(unsigned long flags)
>   #endif
>   
>   #ifndef CONFIG_PARAVIRT
> -#ifndef __ASSEMBLY__
> +#ifndef __ASSEMBLER__
>   /*
>    * Used in the idle loop; sti takes one instruction cycle
>    * to complete:
> @@ -95,7 +95,7 @@ static __always_inline void halt(void)
>   {
>   	native_halt();
>   }
> -#endif /* __ASSEMBLY__ */
> +#endif /* __ASSEMBLER__ */
>   #endif /* CONFIG_PARAVIRT */
>   
>   #ifdef CONFIG_PARAVIRT_XXL
> diff --git a/arch/x86/include/asm/percpu.h b/arch/x86/include/asm/percpu.h
> index 725d0eff7acdf..50f73a8df7f6c 100644
> --- a/arch/x86/include/asm/percpu.h
> +++ b/arch/x86/include/asm/percpu.h
> @@ -20,7 +20,7 @@
>   
>   #define PER_CPU_VAR(var)	__percpu(var)__percpu_rel
>   
> -#else /* !__ASSEMBLY__: */
> +#else /* !__ASSEMBLER__: */
>   
>   #include <linux/args.h>
>   #include <linux/bits.h>
> diff --git a/arch/x86/include/asm/runtime-const.h b/arch/x86/include/asm/runtime-const.h
> index e5a13dc8816e2..4cd94fdcb45e2 100644
> --- a/arch/x86/include/asm/runtime-const.h
> +++ b/arch/x86/include/asm/runtime-const.h
> @@ -6,7 +6,7 @@
>     #error "Cannot use runtime-const infrastructure from modules"
>   #endif
>   
> -#ifdef __ASSEMBLY__
> +#ifdef __ASSEMBLER__
>   
>   .macro RUNTIME_CONST_PTR sym reg
>   	movq	$0x0123456789abcdef, %\reg
> @@ -16,7 +16,7 @@
>   	.popsection
>   .endm
>   
> -#else /* __ASSEMBLY__ */
> +#else /* __ASSEMBLER__ */
>   
>   #define runtime_const_ptr(sym) ({				\
>   	typeof(sym) __ret;					\
> @@ -74,5 +74,5 @@ static inline void runtime_const_fixup(void (*fn)(void *, unsigned long),
>   	}
>   }
>   
> -#endif /* __ASSEMBLY__ */
> +#endif /* __ASSEMBLER__ */
>   #endif


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip: x86/urgent] x86/headers: Replace __ASSEMBLY__ stragglers with __ASSEMBLER__
  2025-12-18 18:20 [PATCH v5] x86/headers: Replace __ASSEMBLY__ stragglers with __ASSEMBLER__ Thomas Huth
  2026-02-12 19:12 ` Thomas Huth
@ 2026-02-23 10:25 ` tip-bot2 for Thomas Huth
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Thomas Huth @ 2026-02-23 10:25 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: Thomas Huth, Peter Zijlstra (Intel), x86, linux-kernel

The following commit has been merged into the x86/urgent branch of tip:

Commit-ID:     237dc6a054f6787c2a8f61c59086030267e5e1c5
Gitweb:        https://git.kernel.org/tip/237dc6a054f6787c2a8f61c59086030267e5e1c5
Author:        Thomas Huth <thuth@redhat.com>
AuthorDate:    Thu, 18 Dec 2025 19:20:29 +01:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Mon, 23 Feb 2026 11:19:12 +01:00

x86/headers: Replace __ASSEMBLY__ stragglers with __ASSEMBLER__

After converting the __ASSEMBLY__ statements to __ASSEMBLER__ in
commit 24a295e4ef1ca ("x86/headers: Replace __ASSEMBLY__ with
__ASSEMBLER__ in non-UAPI headers"), some new code has been
added that uses __ASSEMBLY__ again. Convert these stragglers, too.

This is a mechanical patch, done with a simple "sed -i" command.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://patch.msgid.link/20251218182029.166993-1-thuth@redhat.com
---
 arch/x86/include/asm/bug.h           | 6 +++---
 arch/x86/include/asm/irqflags.h      | 4 ++--
 arch/x86/include/asm/percpu.h        | 2 +-
 arch/x86/include/asm/runtime-const.h | 6 +++---
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/x86/include/asm/bug.h b/arch/x86/include/asm/bug.h
index 9b4e046..80c1696 100644
--- a/arch/x86/include/asm/bug.h
+++ b/arch/x86/include/asm/bug.h
@@ -7,7 +7,7 @@
 #include <linux/objtool.h>
 #include <asm/asm.h>
 
-#ifndef __ASSEMBLY__
+#ifndef __ASSEMBLER__
 struct bug_entry;
 extern void __WARN_trap(struct bug_entry *bug, ...);
 #endif
@@ -137,7 +137,7 @@ do {									\
 
 #ifdef HAVE_ARCH_BUG_FORMAT_ARGS
 
-#ifndef __ASSEMBLY__
+#ifndef __ASSEMBLER__
 #include <linux/static_call_types.h>
 DECLARE_STATIC_CALL(WARN_trap, __WARN_trap);
 
@@ -153,7 +153,7 @@ struct arch_va_list {
 	struct sysv_va_list args;
 };
 extern void *__warn_args(struct arch_va_list *args, struct pt_regs *regs);
-#endif /* __ASSEMBLY__ */
+#endif /* __ASSEMBLER__ */
 
 #define __WARN_bug_entry(flags, format) ({				\
 	struct bug_entry *bug;						\
diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h
index a1193e9..462754b 100644
--- a/arch/x86/include/asm/irqflags.h
+++ b/arch/x86/include/asm/irqflags.h
@@ -77,7 +77,7 @@ static __always_inline void native_local_irq_restore(unsigned long flags)
 #endif
 
 #ifndef CONFIG_PARAVIRT
-#ifndef __ASSEMBLY__
+#ifndef __ASSEMBLER__
 /*
  * Used in the idle loop; sti takes one instruction cycle
  * to complete:
@@ -95,7 +95,7 @@ static __always_inline void halt(void)
 {
 	native_halt();
 }
-#endif /* __ASSEMBLY__ */
+#endif /* __ASSEMBLER__ */
 #endif /* CONFIG_PARAVIRT */
 
 #ifdef CONFIG_PARAVIRT_XXL
diff --git a/arch/x86/include/asm/percpu.h b/arch/x86/include/asm/percpu.h
index c55058f..4099814 100644
--- a/arch/x86/include/asm/percpu.h
+++ b/arch/x86/include/asm/percpu.h
@@ -20,7 +20,7 @@
 
 #define PER_CPU_VAR(var)	__percpu(var)__percpu_rel
 
-#else /* !__ASSEMBLY__: */
+#else /* !__ASSEMBLER__: */
 
 #include <linux/args.h>
 #include <linux/bits.h>
diff --git a/arch/x86/include/asm/runtime-const.h b/arch/x86/include/asm/runtime-const.h
index e5a13dc..4cd94fd 100644
--- a/arch/x86/include/asm/runtime-const.h
+++ b/arch/x86/include/asm/runtime-const.h
@@ -6,7 +6,7 @@
   #error "Cannot use runtime-const infrastructure from modules"
 #endif
 
-#ifdef __ASSEMBLY__
+#ifdef __ASSEMBLER__
 
 .macro RUNTIME_CONST_PTR sym reg
 	movq	$0x0123456789abcdef, %\reg
@@ -16,7 +16,7 @@
 	.popsection
 .endm
 
-#else /* __ASSEMBLY__ */
+#else /* __ASSEMBLER__ */
 
 #define runtime_const_ptr(sym) ({				\
 	typeof(sym) __ret;					\
@@ -74,5 +74,5 @@ static inline void runtime_const_fixup(void (*fn)(void *, unsigned long),
 	}
 }
 
-#endif /* __ASSEMBLY__ */
+#endif /* __ASSEMBLER__ */
 #endif

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-02-23 10:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-18 18:20 [PATCH v5] x86/headers: Replace __ASSEMBLY__ stragglers with __ASSEMBLER__ Thomas Huth
2026-02-12 19:12 ` Thomas Huth
2026-02-23 10:25 ` [tip: x86/urgent] " tip-bot2 for Thomas Huth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®