From: Breno Leitao <leitao@debian.org>
To: Breno Leitao <leitao@debian.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
asantostc@gmail.com, efault@gmx.de, gustavold@gmail.com,
calvin@wbinvd.org, jv@jvosburgh.net, kernel-team@meta.com,
Petr Mladek <pmladek@suse.com>, Simon Horman <horms@kernel.org>
Subject: [PATCH net-next 1/2] netconsole: extract message fragmentation into send_msg_udp()
Date: Mon, 22 Dec 2025 06:52:10 -0800 [thread overview]
Message-ID: <20251222-nbcon-v1-1-65b43c098708@debian.org> (raw)
In-Reply-To: <20251222-nbcon-v1-0-65b43c098708@debian.org>
Extract the message fragmentation logic from write_msg() into a
dedicated send_msg_udp() function. This improves code readability
and prepares for future enhancements.
The new send_msg_udp() function handles splitting messages that
exceed MAX_PRINT_CHUNK into smaller fragments and sending them
sequentially. This function is placed before send_ext_msg_udp()
to maintain a logical ordering of related functions.
No functional changes - this is purely a refactoring commit.
Reviewed-by: Petr Mladek <pmladek@suse.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Breno Leitao <leitao@debian.org>
---
drivers/net/netconsole.c | 24 +++++++++++++++---------
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
index 9cb4dfc242f5..dc3bd7c9b049 100644
--- a/drivers/net/netconsole.c
+++ b/drivers/net/netconsole.c
@@ -1725,12 +1725,24 @@ static void write_ext_msg(struct console *con, const char *msg,
spin_unlock_irqrestore(&target_list_lock, flags);
}
+static void send_msg_udp(struct netconsole_target *nt, const char *msg,
+ unsigned int len)
+{
+ const char *tmp = msg;
+ int frag, left = len;
+
+ while (left > 0) {
+ frag = min(left, MAX_PRINT_CHUNK);
+ send_udp(nt, tmp, frag);
+ tmp += frag;
+ left -= frag;
+ }
+}
+
static void write_msg(struct console *con, const char *msg, unsigned int len)
{
- int frag, left;
unsigned long flags;
struct netconsole_target *nt;
- const char *tmp;
if (oops_only && !oops_in_progress)
return;
@@ -1747,13 +1759,7 @@ static void write_msg(struct console *con, const char *msg, unsigned int len)
* at least one target if we die inside here, instead
* of unnecessarily keeping all targets in lock-step.
*/
- tmp = msg;
- for (left = len; left;) {
- frag = min(left, MAX_PRINT_CHUNK);
- send_udp(nt, tmp, frag);
- tmp += frag;
- left -= frag;
- }
+ send_msg_udp(nt, msg, len);
}
}
spin_unlock_irqrestore(&target_list_lock, flags);
--
2.47.3
next prev parent reply other threads:[~2025-12-22 14:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-22 14:52 [PATCH net-next 0/2] net: netconsole: convert to NBCON console infrastructure Breno Leitao
2025-12-22 14:52 ` Breno Leitao [this message]
2025-12-22 14:52 ` [PATCH net-next 2/2] " Breno Leitao
2026-01-02 3:54 ` Marcos Paulo de Souza
2026-01-06 15:43 ` Breno Leitao
2026-01-07 15:04 ` Marcos Paulo de Souza
2025-12-23 7:12 ` [PATCH net-next 0/2] net: " Paolo Abeni
2025-12-23 9:44 ` Breno Leitao
2026-01-07 14:49 ` Breno Leitao
2026-01-07 15:50 ` John Ogness
2026-01-07 16:58 ` Breno Leitao
2026-01-08 11:08 ` Breno Leitao
2026-01-08 16:50 ` John Ogness
2026-01-09 10:48 ` Breno Leitao
2026-01-09 13:29 ` Petr Mladek
2026-01-09 14:03 ` Petr Mladek
2026-01-09 15:13 ` John Ogness
2026-01-12 10:55 ` Breno Leitao
2026-01-12 12:44 ` Breno Leitao
2026-01-16 15:51 ` Petr Mladek
2026-01-16 15:53 ` Petr Mladek
2026-01-16 18:07 ` Breno Leitao
2026-01-19 14:00 ` Petr Mladek
2026-01-19 16:34 ` Breno Leitao
2026-01-20 8:59 ` Petr Mladek
2026-01-20 9:17 ` Breno Leitao
2026-01-20 10:10 ` John Ogness
2026-01-12 14:17 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251222-nbcon-v1-1-65b43c098708@debian.org \
--to=leitao@debian.org \
--cc=andrew+netdev@lunn.ch \
--cc=asantostc@gmail.com \
--cc=calvin@wbinvd.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=efault@gmx.de \
--cc=gustavold@gmail.com \
--cc=horms@kernel.org \
--cc=jv@jvosburgh.net \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®