From: Marcos Paulo de Souza <mpdesouza@suse.com>
To: Breno Leitao <leitao@debian.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
asantostc@gmail.com, efault@gmx.de, gustavold@gmail.com,
calvin@wbinvd.org, jv@jvosburgh.net, kernel-team@meta.com
Subject: Re: [PATCH net-next 2/2] netconsole: convert to NBCON console infrastructure
Date: Wed, 07 Jan 2026 12:04:55 -0300 [thread overview]
Message-ID: <737d6c96a51b5975c9fd7ed302df014e0d5e4fe1.camel@suse.com> (raw)
In-Reply-To: <l5u6w3ydgfbrah22dbm2vcpytqejfw6aomvzl5uzh5vssljqxd@suspm42neo2z>
On Tue, 2026-01-06 at 07:43 -0800, Breno Leitao wrote:
> Hello Marcos,
>
> On Fri, Jan 02, 2026 at 12:54:14AM -0300, Marcos Paulo de Souza
> wrote:
> > On Mon, 22 Dec 2025 06:52:11 -0800 Breno Leitao <leitao@debian.org>
> > wrote:
> > > + if (!nbcon_enter_unsafe(wctxt))
> > > + continue;
> >
> > In this case, I believe that it should return directly? If it can't
> > enter in the
> > unsafe region the output buffer is not reliable anymore, so
> > retrying the send
> > the buffer to a different target isn't correct anymore. Petr, John,
> > do you
> > agree?
>
> That makes sense. I undersatnd that the ownership will not be
> re-acquired here by just looping through the netconsole targets,
> right?
Yes, take a look into the drivers/tty/serial/*, some of the only
reacquire the context to reset some hardware registers, since the
printing context was lost. In this case, for you, I don't believe that
you can't continue trying to send data to other targets, since the
original data is gone.
In any case, the context reacquire method is nbcon_reacquire_nobuf.
next prev parent reply other threads:[~2026-01-07 15:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-22 14:52 [PATCH net-next 0/2] net: " Breno Leitao
2025-12-22 14:52 ` [PATCH net-next 1/2] netconsole: extract message fragmentation into send_msg_udp() Breno Leitao
2025-12-22 14:52 ` [PATCH net-next 2/2] netconsole: convert to NBCON console infrastructure Breno Leitao
2026-01-02 3:54 ` Marcos Paulo de Souza
2026-01-06 15:43 ` Breno Leitao
2026-01-07 15:04 ` Marcos Paulo de Souza [this message]
2025-12-23 7:12 ` [PATCH net-next 0/2] net: " Paolo Abeni
2025-12-23 9:44 ` Breno Leitao
2026-01-07 14:49 ` Breno Leitao
2026-01-07 15:50 ` John Ogness
2026-01-07 16:58 ` Breno Leitao
2026-01-08 11:08 ` Breno Leitao
2026-01-08 16:50 ` John Ogness
2026-01-09 10:48 ` Breno Leitao
2026-01-09 13:29 ` Petr Mladek
2026-01-09 14:03 ` Petr Mladek
2026-01-09 15:13 ` John Ogness
2026-01-12 10:55 ` Breno Leitao
2026-01-12 12:44 ` Breno Leitao
2026-01-16 15:51 ` Petr Mladek
2026-01-16 15:53 ` Petr Mladek
2026-01-16 18:07 ` Breno Leitao
2026-01-19 14:00 ` Petr Mladek
2026-01-19 16:34 ` Breno Leitao
2026-01-20 8:59 ` Petr Mladek
2026-01-20 9:17 ` Breno Leitao
2026-01-20 10:10 ` John Ogness
2026-01-12 14:17 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=737d6c96a51b5975c9fd7ed302df014e0d5e4fe1.camel@suse.com \
--to=mpdesouza@suse.com \
--cc=andrew+netdev@lunn.ch \
--cc=asantostc@gmail.com \
--cc=calvin@wbinvd.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=efault@gmx.de \
--cc=gustavold@gmail.com \
--cc=jv@jvosburgh.net \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®