mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Damien Riégel" <damien.riegel@silabs.com>
To: greybus-dev@lists.linaro.org
Cc: linux-kernel@vger.kernel.org, "Johan Hovold" <johan@kernel.org>,
	"Alex Elder" <elder@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-devel@silabs.com,
	"Damien Riégel" <damien.riegel@silabs.com>
Subject: [PATCH 8/8] greybus: add function to probe p2p module
Date: Tue, 23 Dec 2025 13:31:42 -0500	[thread overview]
Message-ID: <20251223183142.31897-9-damien.riegel@silabs.com> (raw)
In-Reply-To: <20251223183142.31897-1-damien.riegel@silabs.com>

In a normal Greybus topology, the enumeration of an interface would
start with a "Module Inserted" event, issued by the SVC. In a
point-to-point configuration, the SVC is absent and the host device must
enumerate the module manually.

In order to do so, export a new function that lets the host device
driver start the enumeration. Note that this function issues commands to
the module in a blocking way and should not be called in a probe
function, but should rather be called from a workqueue.

Signed-off-by: Damien Riégel <damien.riegel@silabs.com>
---
 drivers/greybus/hd.c       | 30 ++++++++++++++++++++++++++++++
 include/linux/greybus/hd.h |  2 ++
 2 files changed, 32 insertions(+)

diff --git a/drivers/greybus/hd.c b/drivers/greybus/hd.c
index 2fc9fbe987f..165775b6b8b 100644
--- a/drivers/greybus/hd.c
+++ b/drivers/greybus/hd.c
@@ -132,6 +132,36 @@ const struct device_type greybus_hd_type = {
 	.release	= gb_hd_release,
 };
 
+int gb_hd_p2p_probe_module(struct gb_host_device *hd)
+{
+	struct gb_module *module;
+	int ret;
+
+	if (!gb_hd_is_p2p(hd))
+		return -EOPNOTSUPP;
+
+	/* In P2P mode, only one module is supported. */
+	if (!list_empty(&hd->modules))
+		return -EBUSY;
+
+	module = gb_module_create_p2p(hd);
+	if (!module) {
+		dev_err(&hd->dev, "failed to create module\n");
+		return -ENOMEM;
+	}
+
+	ret = gb_module_add(module);
+	if (ret) {
+		gb_module_put(module);
+		return ret;
+	}
+
+	list_add(&module->hd_node, &hd->modules);
+
+	return 0;
+}
+EXPORT_SYMBOL_GPL(gb_hd_p2p_probe_module);
+
 struct gb_host_device *gb_hd_create_p2p(struct gb_hd_driver *driver,
 					struct device *parent,
 					size_t buffer_size_max,
diff --git a/include/linux/greybus/hd.h b/include/linux/greybus/hd.h
index 28ee7fca1d1..096b9642d11 100644
--- a/include/linux/greybus/hd.h
+++ b/include/linux/greybus/hd.h
@@ -83,6 +83,8 @@ void gb_hd_put(struct gb_host_device *hd);
 int gb_hd_output(struct gb_host_device *hd, void *req, u16 size, u8 cmd,
 		 bool in_irq);
 
+int gb_hd_p2p_probe_module(struct gb_host_device *hd);
+
 int gb_hd_init(void);
 void gb_hd_exit(void);
 
-- 
2.49.0


  parent reply	other threads:[~2025-12-23 19:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-23 18:31 [PATCH 0/8] greybus: support point-to-point topology Damien Riégel
2025-12-23 18:31 ` [PATCH 1/8] greybus: add P2P interface type Damien Riégel
2025-12-23 18:31 ` [PATCH 2/8] greybus: let gb_interface_create take additional p2p argument Damien Riégel
2025-12-23 18:31 ` [PATCH 3/8] greybus: force CPort ID allocation in P2P mode Damien Riégel
2025-12-23 18:31 ` [PATCH 4/8] greybus: split module creation function Damien Riégel
2025-12-23 18:31 ` [PATCH 5/8] greybus: add function create module in P2P mode Damien Riégel
2025-12-23 18:31 ` [PATCH 6/8] greybus: make host API work without SVC Damien Riégel
2025-12-23 18:31 ` [PATCH 7/8] greybus: add function to create SVC-less host device Damien Riégel
2025-12-23 18:31 ` Damien Riégel [this message]
2026-01-16 15:09 ` [PATCH 0/8] greybus: support point-to-point topology Greg Kroah-Hartman
2026-01-27 20:23   ` Damien Riégel
2026-01-28  6:04     ` Greg Kroah-Hartman
2026-01-28 15:39       ` Damien Riégel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251223183142.31897-9-damien.riegel@silabs.com \
    --to=damien.riegel@silabs.com \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-devel@silabs.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®