mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Damien Riégel" <damien.riegel@silabs.com>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Damien Riégel" <damien.riegel@silabs.com>
Cc: <greybus-dev@lists.linaro.org>, <linux-kernel@vger.kernel.org>,
	"Johan Hovold" <johan@kernel.org>,
	"Alex Elder" <elder@kernel.org>, <linux-devel@silabs.com>
Subject: Re: [PATCH 0/8] greybus: support point-to-point topology
Date: Wed, 28 Jan 2026 10:39:38 -0500	[thread overview]
Message-ID: <DG0C329Q24U8.2959NJ9J9KXV4@silabs.com> (raw)
In-Reply-To: <2026012834-parrot-schilling-d4b0@gregkh>

On Wed Jan 28, 2026 at 1:04 AM EST, Greg Kroah-Hartman wrote:
> On Tue, Jan 27, 2026 at 03:23:44PM -0500, Damien Riégel wrote:
>> On Fri Jan 16, 2026 at 10:09 AM EST, Greg Kroah-Hartman wrote:
>> [...]
>>
>> >>
>> >> The SVC doesn' really serve a purpose here, as there is no bus to
>> >> manage, and adding its support only increase the complexity and the code
>> >> size needed on memory-constrained devices.
>> >
>> > Exactly how much memory does a "single point" SVC driver take, vs.
>> > adding new P2P functionality everywhere in the code like you just did?
>> > Finding that out would be good first before worrying about adding
>> > another type of "bus" here please.
>>
>> Sorry for not giving numbers in the cover letter. We measured 10kB of
>> code size difference (which may be on the higher end of the spectrum)
>> and in Zephyr [1] they measured a 2kB difference (which is probably on
>> the lower end considering the implementation is pretty barebone).
>
> Please submit your "empty" SVC driver, 10kb seems too big to me, I think
> we can slim it down, or at the very least, see what is making it "large"
> and potentially work to reduce that.

The comparison I did originally was pretty naive. When I tested without
the SVC, the C files were not even compiled. What I didn't account for
is that our SVC currently logs pretty extensively, and guess where these
log strings are stored...

After removing the logs, I could compare apples to apples:
 - with SVC: 59,272 B
 - without SVC: 57,556 B

So not even 2kB difference.

> For Zephyr, I thought it was 1kb in the github comments, but still 2kb
> seems reasonable :)

The last comment in the thread says 2kB, but it's in the same ballpark.

So I think we have our number, an empty SVC would be in the 1kB to 2kB
range.

      reply	other threads:[~2026-01-28 15:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-23 18:31 Damien Riégel
2025-12-23 18:31 ` [PATCH 1/8] greybus: add P2P interface type Damien Riégel
2025-12-23 18:31 ` [PATCH 2/8] greybus: let gb_interface_create take additional p2p argument Damien Riégel
2025-12-23 18:31 ` [PATCH 3/8] greybus: force CPort ID allocation in P2P mode Damien Riégel
2025-12-23 18:31 ` [PATCH 4/8] greybus: split module creation function Damien Riégel
2025-12-23 18:31 ` [PATCH 5/8] greybus: add function create module in P2P mode Damien Riégel
2025-12-23 18:31 ` [PATCH 6/8] greybus: make host API work without SVC Damien Riégel
2025-12-23 18:31 ` [PATCH 7/8] greybus: add function to create SVC-less host device Damien Riégel
2025-12-23 18:31 ` [PATCH 8/8] greybus: add function to probe p2p module Damien Riégel
2026-01-16 15:09 ` [PATCH 0/8] greybus: support point-to-point topology Greg Kroah-Hartman
2026-01-27 20:23   ` Damien Riégel
2026-01-28  6:04     ` Greg Kroah-Hartman
2026-01-28 15:39       ` Damien Riégel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DG0C329Q24U8.2959NJ9J9KXV4@silabs.com \
    --to=damien.riegel@silabs.com \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-devel@silabs.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®