[PATCH] scsi: ufs: amd-versal2: Fix PHY initialization in HCE enable notify

[PATCH] scsi: ufs: amd-versal2: Fix PHY initialization in HCE enable notify

[Ajay Neeli]

Move the PHY initialization from PRE_CHANGE to POST_CHANGE in the
ufs_versal2_hce_enable_notify() callback. This ensures that the PHY
is initialized after the host controller enable sequence is complete,
rather than before it starts.

The PHY initialization requires the UFS host controller to be in a
stable enabled state to properly configure the MPHY registers. Moving
this to POST_CHANGE aligns with the expected initialization order and
prevents potential timing issues during controller startup.

Fixes: 769b8b2ffded ("scsi: ufs: amd-versal2: Add UFS support for AMD Versal Gen 2 SoC")
Signed-off-by: Ajay Neeli <ajay.neeli@amd.com>
---
 drivers/ufs/host/ufs-amd-versal2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ufs/host/ufs-amd-versal2.c b/drivers/ufs/host/ufs-amd-versal2.c
index 40543db621a1..6c454ae8a9c8 100644
--- a/drivers/ufs/host/ufs-amd-versal2.c
+++ b/drivers/ufs/host/ufs-amd-versal2.c
@@ -367,7 +367,7 @@ static int ufs_versal2_hce_enable_notify(struct ufs_hba *hba,
 {
 	int ret = 0;
 
-	if (status == PRE_CHANGE) {
+	if (status == POST_CHANGE) {
 		ret = ufs_versal2_phy_init(hba);
 		if (ret)
 			dev_err(hba->dev, "Phy init failed (%d)\n", ret);
-- 
2.43.0

Re: [PATCH] scsi: ufs: amd-versal2: Fix PHY initialization in HCE enable notify

[Martin K. Petersen]

On Wed, 24 Dec 2025 11:09:50 +0530, Ajay Neeli wrote:

> Move the PHY initialization from PRE_CHANGE to POST_CHANGE in the
> ufs_versal2_hce_enable_notify() callback. This ensures that the PHY
> is initialized after the host controller enable sequence is complete,
> rather than before it starts.
> 
> The PHY initialization requires the UFS host controller to be in a
> stable enabled state to properly configure the MPHY registers. Moving
> this to POST_CHANGE aligns with the expected initialization order and
> prevents potential timing issues during controller startup.
> 
> [...]

Applied to 6.19/scsi-fixes, thanks!

[1/1] scsi: ufs: amd-versal2: Fix PHY initialization in HCE enable notify
      https://git.kernel.org/mkp/scsi/c/0444568edbf8

-- 
Martin K. Petersen