io_uring/rsrc.c:457:7: error: unexpected token, expected comma

io_uring/rsrc.c:457:7: error: unexpected token, expected comma

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   b69053dd3ffbc0d2dedbbc86182cdef6f641fe1b
commit: 3615e3f7947a3c1cb15d362da921ac46d771e02c io_uring/rsrc: use get/put_user() for integer copy
date:   8 weeks ago
config: mips-randconfig-r051-20251231 (https://download.01.org/0day-ci/archive/20260101/202601012317.QyR84Xo9-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project f43d6834093b19baf79beda8c0337ab020ac5f17)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260101/202601012317.QyR84Xo9-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601012317.QyR84Xo9-lkp@intel.com/

All errors (new ones prefixed by >>):

>> io_uring/rsrc.c:457:7: error: unexpected token, expected comma
     457 |                 if (get_user(fd, &fds[done])) {
         |                     ^
   arch/mips/include/asm/uaccess.h:97:33: note: expanded from macro 'get_user'
      97 |         access_ok(__p, sizeof(*__p)) ? __get_user((x), __p) :           \
         |                                        ^
   arch/mips/include/asm/uaccess.h:183:23: note: expanded from macro '__get_user'
     183 |                 __get_data_asm((x), user_lw, __gu_ptr);                 \
         |                                     ^
   <inline asm>:3:10: note: instantiated into assembly here
       3 |         .set    eva
         |                    ^
   io_uring/rsrc.c:457:7: error: instruction requires a CPU feature not currently enabled
     457 |                 if (get_user(fd, &fds[done])) {
         |                     ^
   arch/mips/include/asm/uaccess.h:97:33: note: expanded from macro 'get_user'
      97 |         access_ok(__p, sizeof(*__p)) ? __get_user((x), __p) :           \
         |                                        ^
   arch/mips/include/asm/uaccess.h:183:23: note: expanded from macro '__get_user'
     183 |                 __get_data_asm((x), user_lw, __gu_ptr);                 \
         |                                     ^
   <inline asm>:4:2: note: instantiated into assembly here
       4 |         lwe $4, 0($21)
         |         ^
   io_uring/rsrc.c:471:7: error: unexpected token, expected comma
     471 |                 if (put_user(ret, &fds[done])) {
         |                     ^
   arch/mips/include/asm/uaccess.h:71:33: note: expanded from macro 'put_user'
      71 |         access_ok(__p, sizeof(*__p)) ? __put_user((x), __p) : -EFAULT;  \
         |                                        ^
   arch/mips/include/asm/uaccess.h:136:18: note: expanded from macro '__put_user'
     136 |                 __put_data_asm(user_sw, __pu_ptr);                      \
         |                                ^
   <inline asm>:3:10: note: instantiated into assembly here
       3 |         .set    eva
         |                    ^
   io_uring/rsrc.c:471:7: error: instruction requires a CPU feature not currently enabled
     471 |                 if (put_user(ret, &fds[done])) {
         |                     ^
   arch/mips/include/asm/uaccess.h:71:33: note: expanded from macro 'put_user'
      71 |         access_ok(__p, sizeof(*__p)) ? __put_user((x), __p) : -EFAULT;  \
         |                                        ^
   arch/mips/include/asm/uaccess.h:136:18: note: expanded from macro '__put_user'
     136 |                 __put_data_asm(user_sw, __pu_ptr);                      \
         |                                ^
   <inline asm>:4:2: note: instantiated into assembly here
       4 |         swe $17, 0($21)
         |         ^
   4 errors generated.


vim +457 io_uring/rsrc.c

   443	
   444	static int io_files_update_with_index_alloc(struct io_kiocb *req,
   445						    unsigned int issue_flags)
   446	{
   447		struct io_rsrc_update *up = io_kiocb_to_cmd(req, struct io_rsrc_update);
   448		__s32 __user *fds = u64_to_user_ptr(up->arg);
   449		unsigned int done;
   450		struct file *file;
   451		int ret, fd;
   452	
   453		if (!req->ctx->file_table.data.nr)
   454			return -ENXIO;
   455	
   456		for (done = 0; done < up->nr_args; done++) {
 > 457			if (get_user(fd, &fds[done])) {
   458				ret = -EFAULT;
   459				break;
   460			}
   461	
   462			file = fget(fd);
   463			if (!file) {
   464				ret = -EBADF;
   465				break;
   466			}
   467			ret = io_fixed_fd_install(req, issue_flags, file,
   468						  IORING_FILE_INDEX_ALLOC);
   469			if (ret < 0)
   470				break;
   471			if (put_user(ret, &fds[done])) {
   472				__io_close_fixed(req->ctx, issue_flags, ret);
   473				ret = -EFAULT;
   474				break;
   475			}
   476		}
   477	
   478		if (done)
   479			return done;
   480		return ret;
   481	}
   482	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki