* [PATCH net] wifi: ath12k: fix dma_free_coherent() pointer
@ 2026-01-06 8:49 Thomas Fourier
2026-01-06 10:01 ` Baochen Qiang
2026-01-09 15:45 ` Jeff Johnson
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Fourier @ 2026-01-06 8:49 UTC (permalink / raw)
Cc: Thomas Fourier, stable, Jeff Johnson, Pradeep Kumar Chitrapu,
Sriram R, Kalle Valo, Wen Gong, linux-wireless, ath12k,
linux-kernel
dma_alloc_coherent() allocates a DMA mapped buffer and stores the
addresses in XXX_unaligned fields. Those should be reused when freeing
the buffer rather than the aligned addresses.
Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
Cc: <stable@vger.kernel.org>
Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
---
drivers/net/wireless/ath/ath12k/ce.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/ce.c b/drivers/net/wireless/ath/ath12k/ce.c
index 9a63608838ac..4aea58446838 100644
--- a/drivers/net/wireless/ath/ath12k/ce.c
+++ b/drivers/net/wireless/ath/ath12k/ce.c
@@ -984,8 +984,8 @@ void ath12k_ce_free_pipes(struct ath12k_base *ab)
dma_free_coherent(ab->dev,
pipe->src_ring->nentries * desc_sz +
CE_DESC_RING_ALIGN,
- pipe->src_ring->base_addr_owner_space,
- pipe->src_ring->base_addr_ce_space);
+ pipe->src_ring->base_addr_owner_space_unaligned,
+ pipe->src_ring->base_addr_ce_space_unaligned);
kfree(pipe->src_ring);
pipe->src_ring = NULL;
}
@@ -995,8 +995,8 @@ void ath12k_ce_free_pipes(struct ath12k_base *ab)
dma_free_coherent(ab->dev,
pipe->dest_ring->nentries * desc_sz +
CE_DESC_RING_ALIGN,
- pipe->dest_ring->base_addr_owner_space,
- pipe->dest_ring->base_addr_ce_space);
+ pipe->dest_ring->base_addr_owner_space_unaligned,
+ pipe->dest_ring->base_addr_ce_space_unaligned);
kfree(pipe->dest_ring);
pipe->dest_ring = NULL;
}
@@ -1007,8 +1007,8 @@ void ath12k_ce_free_pipes(struct ath12k_base *ab)
dma_free_coherent(ab->dev,
pipe->status_ring->nentries * desc_sz +
CE_DESC_RING_ALIGN,
- pipe->status_ring->base_addr_owner_space,
- pipe->status_ring->base_addr_ce_space);
+ pipe->status_ring->base_addr_owner_space_unaligned,
+ pipe->status_ring->base_addr_ce_space_unaligned);
kfree(pipe->status_ring);
pipe->status_ring = NULL;
}
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] wifi: ath12k: fix dma_free_coherent() pointer
2026-01-06 8:49 [PATCH net] wifi: ath12k: fix dma_free_coherent() pointer Thomas Fourier
@ 2026-01-06 10:01 ` Baochen Qiang
2026-01-09 15:45 ` Jeff Johnson
1 sibling, 0 replies; 3+ messages in thread
From: Baochen Qiang @ 2026-01-06 10:01 UTC (permalink / raw)
To: Thomas Fourier
Cc: stable, Jeff Johnson, Pradeep Kumar Chitrapu, Sriram R,
Kalle Valo, Wen Gong, linux-wireless, ath12k, linux-kernel
On 1/6/2026 4:49 PM, Thomas Fourier wrote:
> dma_alloc_coherent() allocates a DMA mapped buffer and stores the
> addresses in XXX_unaligned fields. Those should be reused when freeing
> the buffer rather than the aligned addresses.
>
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
> ---
> drivers/net/wireless/ath/ath12k/ce.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath12k/ce.c b/drivers/net/wireless/ath/ath12k/ce.c
> index 9a63608838ac..4aea58446838 100644
> --- a/drivers/net/wireless/ath/ath12k/ce.c
> +++ b/drivers/net/wireless/ath/ath12k/ce.c
> @@ -984,8 +984,8 @@ void ath12k_ce_free_pipes(struct ath12k_base *ab)
> dma_free_coherent(ab->dev,
> pipe->src_ring->nentries * desc_sz +
> CE_DESC_RING_ALIGN,
> - pipe->src_ring->base_addr_owner_space,
> - pipe->src_ring->base_addr_ce_space);
> + pipe->src_ring->base_addr_owner_space_unaligned,
> + pipe->src_ring->base_addr_ce_space_unaligned);
> kfree(pipe->src_ring);
> pipe->src_ring = NULL;
> }
> @@ -995,8 +995,8 @@ void ath12k_ce_free_pipes(struct ath12k_base *ab)
> dma_free_coherent(ab->dev,
> pipe->dest_ring->nentries * desc_sz +
> CE_DESC_RING_ALIGN,
> - pipe->dest_ring->base_addr_owner_space,
> - pipe->dest_ring->base_addr_ce_space);
> + pipe->dest_ring->base_addr_owner_space_unaligned,
> + pipe->dest_ring->base_addr_ce_space_unaligned);
> kfree(pipe->dest_ring);
> pipe->dest_ring = NULL;
> }
> @@ -1007,8 +1007,8 @@ void ath12k_ce_free_pipes(struct ath12k_base *ab)
> dma_free_coherent(ab->dev,
> pipe->status_ring->nentries * desc_sz +
> CE_DESC_RING_ALIGN,
> - pipe->status_ring->base_addr_owner_space,
> - pipe->status_ring->base_addr_ce_space);
> + pipe->status_ring->base_addr_owner_space_unaligned,
> + pipe->status_ring->base_addr_ce_space_unaligned);
> kfree(pipe->status_ring);
> pipe->status_ring = NULL;
> }
Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] wifi: ath12k: fix dma_free_coherent() pointer
2026-01-06 8:49 [PATCH net] wifi: ath12k: fix dma_free_coherent() pointer Thomas Fourier
2026-01-06 10:01 ` Baochen Qiang
@ 2026-01-09 15:45 ` Jeff Johnson
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Johnson @ 2026-01-09 15:45 UTC (permalink / raw)
To: Thomas Fourier
Cc: stable, Jeff Johnson, Pradeep Kumar Chitrapu, Sriram R,
Kalle Valo, Wen Gong, linux-wireless, ath12k, linux-kernel
On Tue, 06 Jan 2026 09:49:04 +0100, Thomas Fourier wrote:
> dma_alloc_coherent() allocates a DMA mapped buffer and stores the
> addresses in XXX_unaligned fields. Those should be reused when freeing
> the buffer rather than the aligned addresses.
>
>
Applied, thanks!
[1/1] wifi: ath12k: fix dma_free_coherent() pointer
commit: bb97131fbf9b708dd9616ac2bdc793ad102b5c48
Best regards,
--
Jeff Johnson <jeff.johnson@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-09 15:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-06 8:49 [PATCH net] wifi: ath12k: fix dma_free_coherent() pointer Thomas Fourier
2026-01-06 10:01 ` Baochen Qiang
2026-01-09 15:45 ` Jeff Johnson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®