mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shankari Anand <shankari.ak0208@gmail.com>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Todd Kjos" <tkjos@android.com>,
	"Martijn Coenen" <maco@android.com>,
	"Joel Fernandes" <joelagnelf@nvidia.com>,
	"Christian Brauner" <brauner@kernel.org>,
	"Carlos Llamas" <cmllamas@google.com>,
	"Suren Baghdasaryan" <surenb@google.com>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Alexandre Courbot" <acourbot@nvidia.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Igor Korotin" <igor.korotin.linux@gmail.com>,
	"Michal Wilczynski" <m.wilczynski@samsung.com>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Abdiel Janulgue" <abdiel.janulgue@gmail.com>,
	"Robin Murphy" <robin.murphy@arm.com>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	"Shankari Anand" <shankari.ak0208@gmail.com>
Subject: Re: [PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted
Date: Wed,  7 Jan 2026 20:17:39 +0530	[thread overview]
Message-ID: <20260107144739.5847-1-shankari.ak0208@gmail.com> (raw)
In-Reply-To: <20260107143935.5757-1-shankari.ak0208@gmail.com>

On Wed, Jan 07, 2026 at 08:09:35PM +0530, Shankari Anand wrote:
> 
> 
> Hello Miguel and all,
> 
> > >> error[E0432]: unresolved import `crate::types::ARef`
> >    --> rust/kernel/scatterlist.rs:41:13
> >    |
> >    41 |     types::{ARef, Opaque},
> >    |             ^^^^ no `ARef` in `types`
> >    |
> >    = help: consider importing this struct instead:
> >    crate::sync::aref::ARef
> > --
> 
> This change has already been made in [1]. Probably it has showed up on the linux-next
> recently which has caused the kernel bot to detect the error.
> 
> 
> > >> error[E0405]: cannot find trait `AlwaysRefCounted` in module `crate::types`
> >    --> rust/kernel/device/property.rs:362:27
> >    |
> >    362 | unsafe impl crate::types::AlwaysRefCounted for FwNode {
> >    |                           ^^^^^^^^^^^^^^^^ not found in `crate::types`
> >    |
> >    help: consider importing this trait
> >    |
> >    7   + use crate::sync::aref::AlwaysRefCounted;
> >    |
> >    help: if you import `AlwaysRefCounted`, refer to it directly
> >    |
> >    362 - unsafe impl crate::types::AlwaysRefCounted for FwNode {
> >    362 + unsafe impl AlwaysRefCounted for FwNode {
> >    |
> > 
> > --
> 
> I haven't raised a patch for this file change I suppose. Should I do it in the same patch v3
> or put up a separate patch and reference it there?
>  
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
> 
> 
> Please let me know which one would be appropriate and accordingly I'll send the revised patch.
> I'll try to complete this refactoring soon. Sincere apologies that this has been going since quite a while now.
> 
> Thanks a lot!
> 
> Regards,
> Shankari


Apologies, I forgot to link [1]


[1] - https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2da67beda68776842fd0a26f2374e42a5e9b12c8

  reply	other threads:[~2026-01-07 16:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-07 14:39 Shankari Anand
2026-01-07 14:47 ` Shankari Anand [this message]
2026-01-07 17:00 ` Miguel Ojeda
2026-01-07 21:42 ` Danilo Krummrich
     [not found] <<DFIONMNAAA7L.790NWN6D7VS4@kernel.org>
2026-01-31 12:04 ` Shankari Anand
  -- strict thread matches above, loose matches on Subject: below --
2026-01-02 20:27 [PATCH v2 0/4] rust: refactor ARef and AlwaysRefCounted imports Shankari Anand
2026-01-02 20:27 ` [PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted Shankari Anand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260107144739.5847-1-shankari.ak0208@gmail.com \
    --to=shankari.ak0208@gmail.com \
    --cc=a.hindborg@kernel.org \
    --cc=abdiel.janulgue@gmail.com \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=arve@android.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=brauner@kernel.org \
    --cc=cmllamas@google.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=igor.korotin.linux@gmail.com \
    --cc=joelagnelf@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=m.wilczynski@samsung.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=maco@android.com \
    --cc=mripard@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rafael@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=surenb@google.com \
    --cc=tkjos@android.com \
    --cc=tmgross@umich.edu \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®