From: Jim Cromie <jim.cromie@gmail.com>
To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Cc: "Jim Cromie" <jim.cromie@gmail.com>,
"Jason Baron" <jbaron@akamai.com>,
"Łukasz Bartosik" <ukaszb@chromium.org>,
"Louis Chauvet" <louis.chauvet@bootlin.com>,
"Bagas Sanjaya" <bagasdotme@gmail.com>,
"Dave Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org, "Petr Mladek" <pmladek@suse.com>,
"Shuah Khan" <skhan@linuxfoundation.org>,
linux-doc@vger.kernel.org, "Steven Rostedt" <rostedt@goodmis.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>
Subject: [PATCH v8 16/31] dyndbg: hoist classmap-filter-by-modname up to ddebug_add_module
Date: Tue, 13 Jan 2026 18:57:32 -0700 [thread overview]
Message-ID: <20260114015815.1565725-17-jim.cromie@gmail.com> (raw)
In-Reply-To: <20260114015815.1565725-1-jim.cromie@gmail.com>
The body of ddebug_attach_module_classes() is dominated by a
code-block that finds the contiguous subrange of classmaps matching on
modname, and saves it into the ddebug_table's info record.
Implement this block in a macro to accommodate different component
vectors in the "box" (as named in the for_subvec macro). We will
reuse this macro shortly.
And hoist its invocation out of ddebug_attach_module_classes() up into
ddebug_add_module(). This moves the filtering step up closer to
dynamic_debug_init(), which already segments the builtin pr_debug
descriptors on their mod_name boundaries.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
reordered params to match kdoc
---
lib/dynamic_debug.c | 57 ++++++++++++++++++++++++++-------------------
1 file changed, 33 insertions(+), 24 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index c9377a444fc8..d668140794ac 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -170,8 +170,8 @@ static void vpr_info_dq(const struct ddebug_query *query, const char *msg)
}
static struct _ddebug_class_map *ddebug_find_valid_class(struct ddebug_table const *dt,
- const char *class_string,
- int *class_id)
+ const char *class_string,
+ int *class_id)
{
struct _ddebug_class_map *map;
int i, idx;
@@ -1247,30 +1247,35 @@ static const struct proc_ops proc_fops = {
static void ddebug_attach_module_classes(struct ddebug_table *dt, struct _ddebug_info *di)
{
- struct _ddebug_class_map *cm;
- int i, nc = 0;
-
- /*
- * Find this module's classmaps in a subrange/wholerange of
- * the builtin/modular classmap vector/section. Save the start
- * and length of the subrange at its edges.
- */
- for_subvec(i, cm, di, maps) {
- if (!strcmp(cm->mod_name, dt->mod_name)) {
- if (!nc) {
- v2pr_info("start subrange, class[%d]: module:%s base:%d len:%d ty:%d\n",
- i, cm->mod_name, cm->base, cm->length, cm->map_type);
- dt->info.maps.start = cm;
- }
- nc++;
- }
- }
- if (nc) {
- dt->info.maps.len = nc;
- vpr_info("module:%s attached %d classes\n", dt->mod_name, nc);
- }
+ vpr_info("module:%s attached %d classes\n", dt->mod_name, dt->info.maps.len);
}
+/*
+ * Walk the @_box->@_vec member, over @_vec.start[0..len], and find
+ * the contiguous subrange of elements matching on ->mod_name. Copy
+ * the subrange into @_dst. This depends on vars defd by caller.
+ *
+ * @_i: caller provided counter var, init'd by macro
+ * @_sp: cursor into @_vec.
+ * @_box: contains member named @_vec
+ * @_vec: member-name of a type with: .start .len fields.
+ * @_dst: an array-ref: to remember the module's subrange
+ */
+#define dd_mark_vector_subrange(_i, _sp, _box, _vec, _dst) ({ \
+ typeof(_dst) __dst = (_dst); \
+ int __nc = 0; \
+ for_subvec(_i, _sp, _box, _vec) { \
+ if (!strcmp((_sp)->mod_name, (_dst)->mod_name)) { \
+ if (!__nc++) \
+ (__dst)->info._vec.start = (_sp); \
+ } else { \
+ if (__nc) \
+ break; /* end of consecutive matches */ \
+ } \
+ } \
+ (__dst)->info._vec.len = __nc; \
+})
+
/*
* Allocate a new ddebug_table for the given module
* and add it to the global list.
@@ -1278,6 +1283,8 @@ static void ddebug_attach_module_classes(struct ddebug_table *dt, struct _ddebug
static int ddebug_add_module(struct _ddebug_info *di, const char *modname)
{
struct ddebug_table *dt;
+ struct _ddebug_class_map *cm;
+ int i;
if (!di->descs.len)
return 0;
@@ -1300,6 +1307,8 @@ static int ddebug_add_module(struct _ddebug_info *di, const char *modname)
INIT_LIST_HEAD(&dt->link);
+ dd_mark_vector_subrange(i, cm, di, maps, dt);
+
if (di->maps.len)
ddebug_attach_module_classes(dt, di);
--
2.52.0
next prev parent reply other threads:[~2026-01-14 1:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 1:57 [PATCH v8 00/31] dyndbg: fix dynamic-debug regression in DRM Jim Cromie
2026-01-14 1:57 ` [PATCH v8 01/31] dyndbg: factor ddebug_match_desc out from ddebug_change Jim Cromie
2026-01-14 1:57 ` [PATCH v8 02/31] dyndbg: add stub macro for DECLARE_DYNDBG_CLASSMAP Jim Cromie
2026-01-14 1:57 ` [PATCH v8 03/31] docs/dyndbg: update examples \012 to \n Jim Cromie
2026-01-14 1:57 ` [PATCH v8 04/31] docs/dyndbg: explain flags parse 1st Jim Cromie
2026-01-14 1:57 ` [PATCH v8 05/31] test-dyndbg: fixup CLASSMAP usage error Jim Cromie
2026-01-14 1:57 ` [PATCH v8 06/31] dyndbg: reword "class unknown," to "class:_UNKNOWN_" Jim Cromie
2026-01-14 1:57 ` [PATCH v8 07/31] dyndbg: make ddebug_class_param union members same size Jim Cromie
2026-01-14 1:57 ` [PATCH v8 08/31] dyndbg: drop NUM_TYPE_ARRAY Jim Cromie
2026-01-14 1:57 ` [PATCH v8 09/31] dyndbg: tweak pr_fmt to avoid expansion conflicts Jim Cromie
2026-01-14 1:57 ` [PATCH v8 10/31] dyndbg: reduce verbose/debug clutter Jim Cromie
2026-01-14 1:57 ` [PATCH v8 11/31] dyndbg: refactor param_set_dyndbg_classes and below Jim Cromie
2026-01-14 1:57 ` [PATCH v8 12/31] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Jim Cromie
2026-01-14 1:57 ` [PATCH v8 13/31] dyndbg: replace classmap list with a vector Jim Cromie
2026-01-14 1:57 ` [PATCH v8 14/31] dyndbg: macrofy a 2-index for-loop pattern Jim Cromie
2026-01-14 1:57 ` [PATCH v8 15/31] dyndbg,module: make proper substructs in _ddebug_info Jim Cromie
2026-01-14 1:57 ` Jim Cromie [this message]
2026-01-14 1:57 ` [PATCH v8 17/31] dyndbg: move mod_name down from struct ddebug_table to _ddebug_info Jim Cromie
2026-01-14 1:57 ` [PATCH v8 18/31] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code Jim Cromie
2026-01-14 1:57 ` [PATCH v8 19/31] selftests-dyndbg: add a dynamic_debug run_tests target Jim Cromie
2026-01-14 1:57 ` [PATCH v8 20/31] dyndbg: change __dynamic_func_call_cls* macros into expressions Jim Cromie
2026-01-14 1:57 ` [PATCH v8 21/31] dyndbg-API: replace DECLARE_DYNDBG_CLASSMAP Jim Cromie
2026-01-14 1:57 ` [PATCH v8 22/31] dyndbg: detect class_id reservation conflicts Jim Cromie
2026-01-14 1:57 ` [PATCH v8 23/31] dyndbg: check DYNAMIC_DEBUG_CLASSMAP_DEFINE args at compile-time Jim Cromie
2026-01-14 1:57 ` [PATCH v8 24/31] dyndbg-test: change do_prints testpoint to accept a loopct Jim Cromie
2026-01-14 1:57 ` [PATCH v8 25/31] dyndbg-API: promote DYNAMIC_DEBUG_CLASSMAP_PARAM to API Jim Cromie
2026-01-14 1:57 ` [PATCH v8 26/31] dyndbg: treat comma as a token separator Jim Cromie
2026-01-14 1:57 ` [PATCH v8 27/31] dyndbg: split multi-query strings with % Jim Cromie
2026-01-14 1:57 ` [PATCH v8 28/31] selftests-dyndbg: add test_mod_submod Jim Cromie
2026-01-14 1:57 ` [PATCH v8 29/31] dyndbg: resolve "protection" of class'd pr_debug Jim Cromie
2026-01-14 1:57 ` [PATCH v8 30/31] dyndbg: add DYNAMIC_DEBUG_CLASSMAP_USE_(dd_class_name, offset) Jim Cromie
2026-01-14 1:57 ` [PATCH v8 31/31] docs/dyndbg: add classmap info to howto Jim Cromie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260114015815.1565725-17-jim.cromie@gmail.com \
--to=jim.cromie@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=airlied@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jbaron@akamai.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.chauvet@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=skhan@linuxfoundation.org \
--cc=tzimmermann@suse.de \
--cc=ukaszb@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®