mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Cc: "Jim Cromie" <jim.cromie@gmail.com>,
	"Jason Baron" <jbaron@akamai.com>,
	"Łukasz Bartosik" <ukaszb@chromium.org>,
	"Louis Chauvet" <louis.chauvet@bootlin.com>,
	"Bagas Sanjaya" <bagasdotme@gmail.com>,
	"Dave Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	dri-devel@lists.freedesktop.org, "Petr Mladek" <pmladek@suse.com>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	linux-doc@vger.kernel.org, "Steven Rostedt" <rostedt@goodmis.org>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>
Subject: [PATCH v8 05/31] test-dyndbg: fixup CLASSMAP usage error
Date: Tue, 13 Jan 2026 18:57:21 -0700	[thread overview]
Message-ID: <20260114015815.1565725-6-jim.cromie@gmail.com> (raw)
In-Reply-To: <20260114015815.1565725-1-jim.cromie@gmail.com>

commit 6ea3bf466ac6 ("dyndbg: test DECLARE_DYNDBG_CLASSMAP, sysfs nodes")

A closer look at test_dynamic_debug.ko logging output reveals a macro
usage error:

lib/test_dynamic_debug.c:105 [test_dynamic_debug]do_cats =p "LOW msg\n" class:MID
lib/test_dynamic_debug.c:106 [test_dynamic_debug]do_cats =p "MID msg\n" class:HI
lib/test_dynamic_debug.c:107 [test_dynamic_debug]do_cats =_ "HI msg\n" class unknown, _id:13

107 says: HI is unknown, and 105,106 have a LOW/MID and MID/HI skew.

DECLARE_DYNDBG_CLASSMAP() _base arg must equal the enum's 1st value,
in this case it was _base + 1.  This leaves HI class un-selectable.

NB: the macro could better validate its arguments.

Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
Tested-by: Louis Chauvet <louis.chauvet@bootlin.com>
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 lib/test_dynamic_debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_dynamic_debug.c b/lib/test_dynamic_debug.c
index 77c2a669b6af..396144cf351b 100644
--- a/lib/test_dynamic_debug.c
+++ b/lib/test_dynamic_debug.c
@@ -75,7 +75,7 @@ DD_SYS_WRAP(disjoint_bits, p);
 DD_SYS_WRAP(disjoint_bits, T);
 
 /* symbolic input, independent bits */
-enum cat_disjoint_names { LOW = 11, MID, HI };
+enum cat_disjoint_names { LOW = 10, MID, HI };
 DECLARE_DYNDBG_CLASSMAP(map_disjoint_names, DD_CLASS_TYPE_DISJOINT_NAMES, 10,
 			"LOW", "MID", "HI");
 DD_SYS_WRAP(disjoint_names, p);
-- 
2.52.0


  parent reply	other threads:[~2026-01-14  1:59 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-14  1:57 [PATCH v8 00/31] dyndbg: fix dynamic-debug regression in DRM Jim Cromie
2026-01-14  1:57 ` [PATCH v8 01/31] dyndbg: factor ddebug_match_desc out from ddebug_change Jim Cromie
2026-01-14  1:57 ` [PATCH v8 02/31] dyndbg: add stub macro for DECLARE_DYNDBG_CLASSMAP Jim Cromie
2026-01-14  1:57 ` [PATCH v8 03/31] docs/dyndbg: update examples \012 to \n Jim Cromie
2026-01-14  1:57 ` [PATCH v8 04/31] docs/dyndbg: explain flags parse 1st Jim Cromie
2026-01-14  1:57 ` Jim Cromie [this message]
2026-01-14  1:57 ` [PATCH v8 06/31] dyndbg: reword "class unknown," to "class:_UNKNOWN_" Jim Cromie
2026-01-14  1:57 ` [PATCH v8 07/31] dyndbg: make ddebug_class_param union members same size Jim Cromie
2026-01-14  1:57 ` [PATCH v8 08/31] dyndbg: drop NUM_TYPE_ARRAY Jim Cromie
2026-01-14  1:57 ` [PATCH v8 09/31] dyndbg: tweak pr_fmt to avoid expansion conflicts Jim Cromie
2026-01-14  1:57 ` [PATCH v8 10/31] dyndbg: reduce verbose/debug clutter Jim Cromie
2026-01-14  1:57 ` [PATCH v8 11/31] dyndbg: refactor param_set_dyndbg_classes and below Jim Cromie
2026-01-14  1:57 ` [PATCH v8 12/31] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Jim Cromie
2026-01-14  1:57 ` [PATCH v8 13/31] dyndbg: replace classmap list with a vector Jim Cromie
2026-01-14  1:57 ` [PATCH v8 14/31] dyndbg: macrofy a 2-index for-loop pattern Jim Cromie
2026-01-14  1:57 ` [PATCH v8 15/31] dyndbg,module: make proper substructs in _ddebug_info Jim Cromie
2026-01-14  1:57 ` [PATCH v8 16/31] dyndbg: hoist classmap-filter-by-modname up to ddebug_add_module Jim Cromie
2026-01-14  1:57 ` [PATCH v8 17/31] dyndbg: move mod_name down from struct ddebug_table to _ddebug_info Jim Cromie
2026-01-14  1:57 ` [PATCH v8 18/31] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code Jim Cromie
2026-01-14  1:57 ` [PATCH v8 19/31] selftests-dyndbg: add a dynamic_debug run_tests target Jim Cromie
2026-01-14  1:57 ` [PATCH v8 20/31] dyndbg: change __dynamic_func_call_cls* macros into expressions Jim Cromie
2026-01-14  1:57 ` [PATCH v8 21/31] dyndbg-API: replace DECLARE_DYNDBG_CLASSMAP Jim Cromie
2026-01-14  1:57 ` [PATCH v8 22/31] dyndbg: detect class_id reservation conflicts Jim Cromie
2026-01-14  1:57 ` [PATCH v8 23/31] dyndbg: check DYNAMIC_DEBUG_CLASSMAP_DEFINE args at compile-time Jim Cromie
2026-01-14  1:57 ` [PATCH v8 24/31] dyndbg-test: change do_prints testpoint to accept a loopct Jim Cromie
2026-01-14  1:57 ` [PATCH v8 25/31] dyndbg-API: promote DYNAMIC_DEBUG_CLASSMAP_PARAM to API Jim Cromie
2026-01-14  1:57 ` [PATCH v8 26/31] dyndbg: treat comma as a token separator Jim Cromie
2026-01-14  1:57 ` [PATCH v8 27/31] dyndbg: split multi-query strings with % Jim Cromie
2026-01-14  1:57 ` [PATCH v8 28/31] selftests-dyndbg: add test_mod_submod Jim Cromie
2026-01-14  1:57 ` [PATCH v8 29/31] dyndbg: resolve "protection" of class'd pr_debug Jim Cromie
2026-01-14  1:57 ` [PATCH v8 30/31] dyndbg: add DYNAMIC_DEBUG_CLASSMAP_USE_(dd_class_name, offset) Jim Cromie
2026-01-14  1:57 ` [PATCH v8 31/31] docs/dyndbg: add classmap info to howto Jim Cromie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260114015815.1565725-6-jim.cromie@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=airlied@gmail.com \
    --cc=bagasdotme@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbaron@akamai.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=louis.chauvet@bootlin.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tzimmermann@suse.de \
    --cc=ukaszb@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®