From: Borislav Petkov <bp@alien8.de>
To: Hou Wenlong <houwenlong.hwl@antgroup.com>
Cc: linux-kernel@vger.kernel.org, Rik van Riel <riel@surriel.com>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Will Deacon <will@kernel.org>,
Ryan Roberts <ryan.roberts@arm.com>, Jann Horn <jannh@google.com>,
Barry Song <baohua@kernel.org>
Subject: Re: [PATCH v2] x86/mm: Hide mm_free_global_asid() definition under 'CONFIG_BROADCAST_TLB_FLUSH'
Date: Thu, 15 Jan 2026 10:15:06 +0100 [thread overview]
Message-ID: <20260115091506.GAaWiwGnvRTOOUVGtv@fat_crate.local> (raw)
In-Reply-To: <b262a8ec8076fb26bb692aaf113848b1e6f40e40.1768448079.git.houwenlong.hwl@antgroup.com>
On Thu, Jan 15, 2026 at 11:38:34AM +0800, Hou Wenlong wrote:
> When 'CONFIG_BROADCAST_TLB_FLUSH' is not enabled, mm_free_global_asid()
> remains a globally visible symbol and generates a useless function call
> to it in destroy_context(). Therefore, hide the mm_free_global_asid()
> definition under 'CONFIG_BROADCAST_TLB_FLUSH' and provide a static
> inline empty version when it is not enabled to remove the function call.
>
> Reviewed-by: Rik van Riel <riel@surriel.com>
> Signed-off-by: Hou Wenlong <houwenlong.hwl@antgroup.com>
> ---
> v1->v2:
> Keep the declarations of mm_init_global_asid() and mm_free_global_asid()
> in 'asm/mmu_context.h' to fix the compilation failure of module
> building.
> ---
> arch/x86/include/asm/mmu_context.h | 2 --
> arch/x86/include/asm/tlbflush.h | 3 +++
> arch/x86/mm/tlb.c | 4 ++--
> 3 files changed, 5 insertions(+), 4 deletions(-)
Did you run the build tests I asked you to do before you sent this?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2026-01-15 9:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 13:21 [PATCH] " Hou Wenlong
2026-01-14 15:09 ` Rik van Riel
2026-01-14 19:28 ` Borislav Petkov
2026-01-15 3:28 ` Hou Wenlong
2026-01-15 3:38 ` [PATCH v2] " Hou Wenlong
2026-01-15 9:15 ` Borislav Petkov [this message]
2026-01-16 3:47 ` Hou Wenlong
2026-01-16 20:47 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260115091506.GAaWiwGnvRTOOUVGtv@fat_crate.local \
--to=bp@alien8.de \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=houwenlong.hwl@antgroup.com \
--cc=hpa@zytor.com \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=ryan.roberts@arm.com \
--cc=tglx@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®