mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Harry Austen <hpausten@protonmail.com>
Cc: Huacai Chen <chenhuacai@kernel.org>,
	linux-kernel@vger.kernel.org,
	Lillian Berry <lillian@star-ark.net>
Subject: Re: [PATCH] init/main.c: prevent warning on lack of default implicit rdinit
Date: Thu, 15 Jan 2026 15:28:57 -0800	[thread overview]
Message-ID: <20260115152857.12f32b47493d61d9948afd85@linux-foundation.org> (raw)
In-Reply-To: <dP25Qm8geQeWowSGauwnJ0Mi7Hpv5H_WQUl5J7q2T3Xjz6bt16rXUP45Q9nwkvdQEVsM3bLdxA7Z0RgomgshJN9q1zFE19UF-VzBqGEjY_Q=@protonmail.com>

On Thu, 15 Jan 2026 23:09:07 +0000 Harry Austen <hpausten@protonmail.com> wrote:

> On Thursday, 15 January 2026 at 20:02, Andrew Morton <akpm@linux-foundation.org> wrote:
> 
> > 
> > 
> > On Wed, 14 Jan 2026 22:02:27 +0000 Harry Austen hpausten@protonmail.com wrote:
> > 
> > > If rdinit was not explicitly provided on cmdline, and default /init does
> > > not exist, no warning should be printed.
> > 
> > 
> > Seems that we already have a very similar patch from Lillian:
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/init-mainc-check-if-rdinit-was-explicitly-set-before-printing-warning.patch
> > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/init-mainc-check-if-rdinit-was-explicitly-set-before-printing-warning-fix.patch
> > 
> > What's happening here?
> 
> Oh, interesting. Have those already been accepted?

They're in the mm.git queue for the next merge window.  As such they
are subject to test/review/alteration/dropping/etc.

> Looks like there's no
> additional ENOENT check, so the warning gets printed even less often, which is fine by me.
> 
> Apologies for missing that this appears to have already been fixed and feel free
> to ignore my patch.

OK, no probs, thanks, please send along any alterations to Lillian's
patch if you see a need.  linux-next would be a suitable base for
that.


      reply	other threads:[~2026-01-15 23:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-14 22:02 Harry Austen
2026-01-15  2:47 ` Andrew Morton
2026-01-15  7:32   ` Harry Austen
2026-01-15 20:02 ` Andrew Morton
2026-01-15 23:09   ` Harry Austen
2026-01-15 23:28     ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260115152857.12f32b47493d61d9948afd85@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=chenhuacai@kernel.org \
    --cc=hpausten@protonmail.com \
    --cc=lillian@star-ark.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®