From: Phil Auld <pauld@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-tip-commits@vger.kernel.org,
Gabriele Monaco <gmonaco@redhat.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
x86@kernel.org
Subject: Re: [tip: sched/core] sched: Fix build for modules using set_tsk_need_resched()
Date: Thu, 15 Jan 2026 18:38:03 -0500 [thread overview]
Message-ID: <20260115233803.GD1039042@pauld.westford.csb> (raw)
In-Reply-To: <176851345987.510.6507406232761244840.tip-bot2@tip-bot2>
On Thu, Jan 15, 2026 at 09:44:19PM -0000 tip-bot2 for Gabriele Monaco wrote:
> The following commit has been merged into the sched/core branch of tip:
>
> Commit-ID: 8d737320166bd145af70a3133a9964b00ca81cba
> Gitweb: https://git.kernel.org/tip/8d737320166bd145af70a3133a9964b00ca81cba
> Author: Gabriele Monaco <gmonaco@redhat.com>
> AuthorDate: Mon, 12 Jan 2026 15:04:13 +01:00
> Committer: Peter Zijlstra <peterz@infradead.org>
> CommitterDate: Thu, 15 Jan 2026 22:41:26 +01:00
>
Thank you for both of these, Peter!
Cheers,
Phil
> sched: Fix build for modules using set_tsk_need_resched()
>
> Commit adcc3bfa8806 ("sched: Adapt sched tracepoints for RV task model")
> added a tracepoint to the need_resched action that can be triggered also
> by set_tsk_need_resched.
> This function was previously accessible from out-of-tree modules but
> it's no longer available because the __trace_set_need_resched() symbol
> is not exported (together with the tracepoint itself, which was exported
> in a separate patch) and building such modules fails.
>
> Export __trace_set_need_resched to modules to fix those build issues.
>
> Fixes: adcc3bfa8806 ("sched: Adapt sched tracepoints for RV task model")
> Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Reviewed-by: Phil Auld <pauld@redhat.com>
> Link: https://patch.msgid.link/20260112140413.362202-1-gmonaco@redhat.com
> ---
> kernel/sched/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index b033f97..3cca012 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -1139,6 +1139,7 @@ void __trace_set_need_resched(struct task_struct *curr, int tif)
> {
> trace_sched_set_need_resched_tp(curr, smp_processor_id(), tif);
> }
> +EXPORT_SYMBOL_GPL(__trace_set_need_resched);
>
> void resched_curr(struct rq *rq)
> {
>
--
next prev parent reply other threads:[~2026-01-15 23:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 14:04 [PATCH] " Gabriele Monaco
2026-01-12 14:50 ` Phil Auld
2026-01-15 21:44 ` [tip: sched/core] " tip-bot2 for Gabriele Monaco
2026-01-15 23:38 ` Phil Auld [this message]
2026-01-28 22:48 ` Phil Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260115233803.GD1039042@pauld.westford.csb \
--to=pauld@redhat.com \
--cc=gmonaco@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®