From: Alex Williamson <alex@shazbot.org>
To: Julia Lawall <Julia.Lawall@inria.fr>
Cc: Kirti Wankhede <kwankhede@nvidia.com>,
yunbolyu@smu.edu.sg, kexinsun@smail.nju.edu.cn,
ratnadiraw@smu.edu.sg, xutong.ma@inria.fr, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio/mdev: update outdated comment
Date: Mon, 19 Jan 2026 13:37:57 -0700 [thread overview]
Message-ID: <20260119133757.3c0dac5c@shazbot.org> (raw)
In-Reply-To: <20251230164113.102604-1-Julia.Lawall@inria.fr>
On Tue, 30 Dec 2025 17:41:13 +0100
Julia Lawall <Julia.Lawall@inria.fr> wrote:
> The function add_mdev_supported_type() was renamed mdev_type_add() in
> commit da44c340c4fe ("vfio/mdev: simplify mdev_type handling").
> Update the comment accordingly.
>
> Note that just as mdev_type_release() now states that its put pairs
> with the get in mdev_type_add(), mdev_type_add() already stated that
> its get pairs with the put in mdev_type_release().
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
>
> ---
> drivers/vfio/mdev/mdev_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/mdev/mdev_sysfs.c b/drivers/vfio/mdev/mdev_sysfs.c
> index e44bb44c581e..b2596020e62f 100644
> --- a/drivers/vfio/mdev/mdev_sysfs.c
> +++ b/drivers/vfio/mdev/mdev_sysfs.c
> @@ -156,7 +156,7 @@ static void mdev_type_release(struct kobject *kobj)
> struct mdev_type *type = to_mdev_type(kobj);
>
> pr_debug("Releasing group %s\n", kobj->name);
> - /* Pairs with the get in add_mdev_supported_type() */
> + /* Pairs with the get in mdev_type_add() */
> put_device(type->parent->dev);
> }
>
>
>
Applied to vfio next branch for v6.20/7.0. Thanks,
Alex
prev parent reply other threads:[~2026-01-19 20:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-30 16:41 Julia Lawall
2026-01-05 15:04 ` Jason Gunthorpe
2026-01-12 9:53 ` Kirti Wankhede
2026-01-19 20:37 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260119133757.3c0dac5c@shazbot.org \
--to=alex@shazbot.org \
--cc=Julia.Lawall@inria.fr \
--cc=kexinsun@smail.nju.edu.cn \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ratnadiraw@smu.edu.sg \
--cc=xutong.ma@inria.fr \
--cc=yunbolyu@smu.edu.sg \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®