[PATCH] vfio/mdev: update outdated comment

[PATCH] vfio/mdev: update outdated comment

[Julia Lawall]

The function add_mdev_supported_type() was renamed mdev_type_add() in
commit da44c340c4fe ("vfio/mdev: simplify mdev_type handling").
Update the comment accordingly.

Note that just as mdev_type_release() now states that its put pairs
with the get in mdev_type_add(), mdev_type_add() already stated that
its get pairs with the put in mdev_type_release().

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

---
 drivers/vfio/mdev/mdev_sysfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/vfio/mdev/mdev_sysfs.c b/drivers/vfio/mdev/mdev_sysfs.c
index e44bb44c581e..b2596020e62f 100644
--- a/drivers/vfio/mdev/mdev_sysfs.c
+++ b/drivers/vfio/mdev/mdev_sysfs.c
@@ -156,7 +156,7 @@ static void mdev_type_release(struct kobject *kobj)
 	struct mdev_type *type = to_mdev_type(kobj);
 
 	pr_debug("Releasing group %s\n", kobj->name);
-	/* Pairs with the get in add_mdev_supported_type() */
+	/* Pairs with the get in mdev_type_add() */
 	put_device(type->parent->dev);
 }
 

Re: [PATCH] vfio/mdev: update outdated comment

[Jason Gunthorpe]

On Tue, Dec 30, 2025 at 05:41:13PM +0100, Julia Lawall wrote:
> The function add_mdev_supported_type() was renamed mdev_type_add() in
> commit da44c340c4fe ("vfio/mdev: simplify mdev_type handling").
> Update the comment accordingly.
> 
> Note that just as mdev_type_release() now states that its put pairs
> with the get in mdev_type_add(), mdev_type_add() already stated that
> its get pairs with the put in mdev_type_release().
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
> 
> ---
>  drivers/vfio/mdev/mdev_sysfs.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason

RE: [PATCH] vfio/mdev: update outdated comment

[Kirti Wankhede]

> -----Original Message-----
> From: Julia Lawall <Julia.Lawall@inria.fr>
> Sent: 30 December 2025 10:11 PM
> To: Kirti Wankhede <kwankhede@nvidia.com>
> Cc: yunbolyu@smu.edu.sg; kexinsun@smail.nju.edu.cn;
> ratnadiraw@smu.edu.sg; xutong.ma@inria.fr; Alex Williamson
> <alex@shazbot.org>; kvm@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] vfio/mdev: update outdated comment
> 
> The function add_mdev_supported_type() was renamed mdev_type_add() in
> commit da44c340c4fe ("vfio/mdev: simplify mdev_type handling").
> Update the comment accordingly.
> 
> Note that just as mdev_type_release() now states that its put pairs
> with the get in mdev_type_add(), mdev_type_add() already stated that
> its get pairs with the put in mdev_type_release().
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
> 
> ---
>  drivers/vfio/mdev/mdev_sysfs.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Kirti Wankhede <kwankhede@nvidia.com>

Re: [PATCH] vfio/mdev: update outdated comment

[Alex Williamson]

On Tue, 30 Dec 2025 17:41:13 +0100
Julia Lawall <Julia.Lawall@inria.fr> wrote:

> The function add_mdev_supported_type() was renamed mdev_type_add() in
> commit da44c340c4fe ("vfio/mdev: simplify mdev_type handling").
> Update the comment accordingly.
> 
> Note that just as mdev_type_release() now states that its put pairs
> with the get in mdev_type_add(), mdev_type_add() already stated that
> its get pairs with the put in mdev_type_release().
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
> 
> ---
>  drivers/vfio/mdev/mdev_sysfs.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vfio/mdev/mdev_sysfs.c b/drivers/vfio/mdev/mdev_sysfs.c
> index e44bb44c581e..b2596020e62f 100644
> --- a/drivers/vfio/mdev/mdev_sysfs.c
> +++ b/drivers/vfio/mdev/mdev_sysfs.c
> @@ -156,7 +156,7 @@ static void mdev_type_release(struct kobject *kobj)
>  	struct mdev_type *type = to_mdev_type(kobj);
>  
>  	pr_debug("Releasing group %s\n", kobj->name);
> -	/* Pairs with the get in add_mdev_supported_type() */
> +	/* Pairs with the get in mdev_type_add() */
>  	put_device(type->parent->dev);
>  }
>  
> 
> 

Applied to vfio next branch for v6.20/7.0.  Thanks,

Alex