From: Peter Zijlstra <peterz@infradead.org>
To: tglx@linutronix.de, mathieu.desnoyers@efficios.com
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
paulmck@kernel.org, boqun.feng@gmail.com, corbet@lwn.net,
prakash.sangappa@oracle.com, vineethr@linux.ibm.com,
kprateek.nayak@amd.com, rostedt@goodmis.org,
bigeasy@linutronix.de, arnd@arndb.de, rdunlap@infradead.org,
rongevarg@gmail.com, longman@redhat.com
Subject: [PATCH 4/5] hrtimer: Fix trace oddity
Date: Wed, 21 Jan 2026 15:25:01 +0100 [thread overview]
Message-ID: <20260121143208.219595606@infradead.org> (raw)
In-Reply-To: <20260121142457.242071831@infradead.org>
It turns out that __run_hrtimer() will trace like:
<idle>-0 [032] d.h2. 20705.474563: hrtimer_cancel: hrtimer=0xff2db8f77f8226e8
<idle>-0 [032] d.h1. 20705.474563: hrtimer_expire_entry: hrtimer=0xff2db8f77f8226e8 now=20699452001850 function=tick_nohz_handler/0x0
Which is a bit nonsensical, the timer doesn't get canceled on
expiration. The cause is the use of the incorrect debug helper.
Fixes: c6a2a1770245 ("hrtimer: Add tracepoint for hrtimers")
Reported-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
kernel/time/hrtimer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/kernel/time/hrtimer.c
+++ b/kernel/time/hrtimer.c
@@ -1750,7 +1750,7 @@ static void __run_hrtimer(struct hrtimer
lockdep_assert_held(&cpu_base->lock);
- debug_deactivate(timer);
+ debug_hrtimer_deactivate(timer);
base->running = timer;
/*
next prev parent reply other threads:[~2026-01-21 14:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 14:24 [PATCH 0/5] rseq: Various slice-ext changes Peter Zijlstra
2026-01-21 14:24 ` [PATCH 1/5] rseq: Allow registering RSEQ with slice extension Peter Zijlstra
2026-01-22 10:15 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2026-01-21 14:24 ` [PATCH 2/5] rseq: Move slice_ext_nsec to debugfs Peter Zijlstra
2026-01-21 14:50 ` Thomas Weißschuh
2026-01-21 14:56 ` Peter Zijlstra
2026-01-21 15:15 ` Peter Zijlstra
2026-01-22 10:15 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2026-01-21 14:25 ` [PATCH 3/5] rseq: Lower default slice extension Peter Zijlstra
2026-01-22 10:15 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2026-01-21 14:25 ` Peter Zijlstra [this message]
2026-01-22 10:15 ` [tip: sched/core] hrtimer: Fix trace oddity tip-bot2 for Thomas Gleixner
2026-01-21 14:25 ` [PATCH 5/5] selftests/rseq: Add rseq slice histogram script Peter Zijlstra
2026-01-22 10:15 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260121143208.219595606@infradead.org \
--to=peterz@infradead.org \
--cc=arnd@arndb.de \
--cc=bigeasy@linutronix.de \
--cc=boqun.feng@gmail.com \
--cc=corbet@lwn.net \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=prakash.sangappa@oracle.com \
--cc=rdunlap@infradead.org \
--cc=rongevarg@gmail.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vineethr@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®