* [PATCH] drm/nouveau/disp: Set drm_mode_config_funcs.atomic_(check|commit)
@ 2026-01-21 19:13 Lyude Paul
2026-01-21 20:39 ` Dave Airlie
0 siblings, 1 reply; 2+ messages in thread
From: Lyude Paul @ 2026-01-21 19:13 UTC (permalink / raw)
To: dri-devel, linux-kernel, nouveau
Cc: stable, Maarten Lankhorst, Simona Vetter, David Airlie,
Thomas Zimmermann, Maxime Ripard, Danilo Krummrich, Lyude Paul
Apparently we never actually filled these in, despite the fact that we do
in fact technically support atomic modesetting.
Since not having these filled in causes us to potentially forget to disable
fbdev and friends during suspend/resume, let's fix it.
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/nouveau/nouveau_display.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
index 00515623a2cc7..829c2b573971c 100644
--- a/drivers/gpu/drm/nouveau/nouveau_display.c
+++ b/drivers/gpu/drm/nouveau/nouveau_display.c
@@ -352,6 +352,8 @@ nouveau_user_framebuffer_create(struct drm_device *dev,
static const struct drm_mode_config_funcs nouveau_mode_config_funcs = {
.fb_create = nouveau_user_framebuffer_create,
+ .atomic_commit = drm_atomic_helper_commit,
+ .atomic_check = drm_atomic_helper_check,
};
base-commit: 68b271a3a94cfd6c7695a96b6398b52feb89e2c2
--
2.52.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm/nouveau/disp: Set drm_mode_config_funcs.atomic_(check|commit)
2026-01-21 19:13 [PATCH] drm/nouveau/disp: Set drm_mode_config_funcs.atomic_(check|commit) Lyude Paul
@ 2026-01-21 20:39 ` Dave Airlie
0 siblings, 0 replies; 2+ messages in thread
From: Dave Airlie @ 2026-01-21 20:39 UTC (permalink / raw)
To: Lyude Paul
Cc: dri-devel, linux-kernel, nouveau, stable, Maarten Lankhorst,
Simona Vetter, Thomas Zimmermann, Maxime Ripard,
Danilo Krummrich
On Thu, 22 Jan 2026 at 05:13, Lyude Paul <lyude@redhat.com> wrote:
>
> Apparently we never actually filled these in, despite the fact that we do
> in fact technically support atomic modesetting.
>
> Since not having these filled in causes us to potentially forget to disable
> fbdev and friends during suspend/resume, let's fix it.
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/gpu/drm/nouveau/nouveau_display.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
> index 00515623a2cc7..829c2b573971c 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_display.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_display.c
> @@ -352,6 +352,8 @@ nouveau_user_framebuffer_create(struct drm_device *dev,
>
> static const struct drm_mode_config_funcs nouveau_mode_config_funcs = {
> .fb_create = nouveau_user_framebuffer_create,
> + .atomic_commit = drm_atomic_helper_commit,
> + .atomic_check = drm_atomic_helper_check,
> };
>
>
>
> base-commit: 68b271a3a94cfd6c7695a96b6398b52feb89e2c2
> --
> 2.52.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-21 20:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-21 19:13 [PATCH] drm/nouveau/disp: Set drm_mode_config_funcs.atomic_(check|commit) Lyude Paul
2026-01-21 20:39 ` Dave Airlie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®