* [PATCH 0/2] interconnect: qcom: remove some duplicated defines
@ 2026-01-22 19:34 Gabor Juhos
2026-01-22 19:34 ` [PATCH 1/2] interconnect: qcom: smd-rpm: drop duplicated QCOM_RPM_SMD_KEY_RATE define Gabor Juhos
2026-01-22 19:34 ` [PATCH 2/2] interconnect: qcom: msm8974: drop duplicated RPM_BUS_{MASTER,SLAVE}_REQ defines Gabor Juhos
0 siblings, 2 replies; 7+ messages in thread
From: Gabor Juhos @ 2026-01-22 19:34 UTC (permalink / raw)
To: Georgi Djakov; +Cc: linux-arm-msm, linux-pm, linux-kernel, Gabor Juhos
The series consist of two small patches to remove some duplicated
defines from the 'smd-rpm' and the 'msm8974' drivers.
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
---
Gabor Juhos (2):
interconnect: qcom: smd-rpm: drop duplicated QCOM_RPM_SMD_KEY_RATE define
interconnect: qcom: msm8974: drop duplicated RPM_BUS_{MASTER,SLAVE}_REQ defines
drivers/interconnect/qcom/msm8974.c | 3 ---
drivers/interconnect/qcom/smd-rpm.c | 1 -
2 files changed, 4 deletions(-)
---
base-commit: cd796ca8b83be6bcab7610e420078539fe67ea03
change-id: 20260101-icc-qcom-dupe-defines-2971d60480ad
Best regards,
--
Gabor Juhos <j4g8y7@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 1/2] interconnect: qcom: smd-rpm: drop duplicated QCOM_RPM_SMD_KEY_RATE define
2026-01-22 19:34 [PATCH 0/2] interconnect: qcom: remove some duplicated defines Gabor Juhos
@ 2026-01-22 19:34 ` Gabor Juhos
2026-01-22 19:43 ` Konrad Dybcio
2026-01-22 20:12 ` Dmitry Baryshkov
2026-01-22 19:34 ` [PATCH 2/2] interconnect: qcom: msm8974: drop duplicated RPM_BUS_{MASTER,SLAVE}_REQ defines Gabor Juhos
1 sibling, 2 replies; 7+ messages in thread
From: Gabor Juhos @ 2026-01-22 19:34 UTC (permalink / raw)
To: Georgi Djakov; +Cc: linux-arm-msm, linux-pm, linux-kernel, Gabor Juhos
The 'linux/soc/qcom/smd-rpm.h' header defines QCOM_RPM_SMD_KEY_RATE
with the exact same value.
$ git grep -nHE 'define[[:blank:]]+QCOM_RPM_SMD_KEY_RATE[[:blank:]]'
drivers/interconnect/qcom/smd-rpm.c:17:#define QCOM_RPM_SMD_KEY_RATE 0x007a484b
include/linux/soc/qcom/smd-rpm.h:52:#define QCOM_RPM_SMD_KEY_RATE 0x007a484b
Drop the local define to avoid the duplication.
No functional changes intended. Compile tested only.
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
---
drivers/interconnect/qcom/smd-rpm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/interconnect/qcom/smd-rpm.c b/drivers/interconnect/qcom/smd-rpm.c
index 8316c87a2c60f5f99edece3443cc60e9e75fa11f..dbc7ae50b02b7948217c856e3b1bee53c56f46e3 100644
--- a/drivers/interconnect/qcom/smd-rpm.c
+++ b/drivers/interconnect/qcom/smd-rpm.c
@@ -14,7 +14,6 @@
#include "icc-rpm.h"
#define RPM_KEY_BW 0x00007762
-#define QCOM_RPM_SMD_KEY_RATE 0x007a484b
static struct qcom_smd_rpm *icc_smd_rpm;
--
2.52.0
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] interconnect: qcom: smd-rpm: drop duplicated QCOM_RPM_SMD_KEY_RATE define
2026-01-22 19:34 ` [PATCH 1/2] interconnect: qcom: smd-rpm: drop duplicated QCOM_RPM_SMD_KEY_RATE define Gabor Juhos
@ 2026-01-22 19:43 ` Konrad Dybcio
2026-01-22 20:12 ` Dmitry Baryshkov
1 sibling, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2026-01-22 19:43 UTC (permalink / raw)
To: Gabor Juhos, Georgi Djakov; +Cc: linux-arm-msm, linux-pm, linux-kernel
On 1/22/26 8:34 PM, Gabor Juhos wrote:
> The 'linux/soc/qcom/smd-rpm.h' header defines QCOM_RPM_SMD_KEY_RATE
> with the exact same value.
>
> $ git grep -nHE 'define[[:blank:]]+QCOM_RPM_SMD_KEY_RATE[[:blank:]]'
> drivers/interconnect/qcom/smd-rpm.c:17:#define QCOM_RPM_SMD_KEY_RATE 0x007a484b
> include/linux/soc/qcom/smd-rpm.h:52:#define QCOM_RPM_SMD_KEY_RATE 0x007a484b
>
> Drop the local define to avoid the duplication.
>
> No functional changes intended. Compile tested only.
>
> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] interconnect: qcom: smd-rpm: drop duplicated QCOM_RPM_SMD_KEY_RATE define
2026-01-22 19:34 ` [PATCH 1/2] interconnect: qcom: smd-rpm: drop duplicated QCOM_RPM_SMD_KEY_RATE define Gabor Juhos
2026-01-22 19:43 ` Konrad Dybcio
@ 2026-01-22 20:12 ` Dmitry Baryshkov
1 sibling, 0 replies; 7+ messages in thread
From: Dmitry Baryshkov @ 2026-01-22 20:12 UTC (permalink / raw)
To: Gabor Juhos; +Cc: Georgi Djakov, linux-arm-msm, linux-pm, linux-kernel
On Thu, Jan 22, 2026 at 08:34:22PM +0100, Gabor Juhos wrote:
> The 'linux/soc/qcom/smd-rpm.h' header defines QCOM_RPM_SMD_KEY_RATE
> with the exact same value.
>
> $ git grep -nHE 'define[[:blank:]]+QCOM_RPM_SMD_KEY_RATE[[:blank:]]'
> drivers/interconnect/qcom/smd-rpm.c:17:#define QCOM_RPM_SMD_KEY_RATE 0x007a484b
> include/linux/soc/qcom/smd-rpm.h:52:#define QCOM_RPM_SMD_KEY_RATE 0x007a484b
>
> Drop the local define to avoid the duplication.
>
> No functional changes intended. Compile tested only.
>
> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
> ---
> drivers/interconnect/qcom/smd-rpm.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] interconnect: qcom: msm8974: drop duplicated RPM_BUS_{MASTER,SLAVE}_REQ defines
2026-01-22 19:34 [PATCH 0/2] interconnect: qcom: remove some duplicated defines Gabor Juhos
2026-01-22 19:34 ` [PATCH 1/2] interconnect: qcom: smd-rpm: drop duplicated QCOM_RPM_SMD_KEY_RATE define Gabor Juhos
@ 2026-01-22 19:34 ` Gabor Juhos
2026-01-22 19:43 ` Konrad Dybcio
2026-01-22 20:12 ` Dmitry Baryshkov
1 sibling, 2 replies; 7+ messages in thread
From: Gabor Juhos @ 2026-01-22 19:34 UTC (permalink / raw)
To: Georgi Djakov; +Cc: linux-arm-msm, linux-pm, linux-kernel, Gabor Juhos
Both the RPM_BUS_MASTER_REQ and the RPM_BUS_SLAVE_REQ constants are
also defined in the 'icc-rpm.h' header.
$ git grep -nHE 'define[[:blank:]]+RPM_BUS_MASTER_REQ[[:blank:]]'
drivers/interconnect/qcom/icc-rpm.h:16:#define RPM_BUS_MASTER_REQ 0x73616d62
drivers/interconnect/qcom/msm8974.c:176:#define RPM_BUS_MASTER_REQ 0x73616d62
$ git grep -nHE 'define[[:blank:]]+RPM_BUS_SLAVE_REQ[[:blank:]]'
drivers/interconnect/qcom/icc-rpm.h:17:#define RPM_BUS_SLAVE_REQ 0x766c7362
drivers/interconnect/qcom/msm8974.c:177:#define RPM_BUS_SLAVE_REQ 0x766c7362
Drop the local defines to avoid the duplications.
No functional changes intended. Compile tested only.
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
---
drivers/interconnect/qcom/msm8974.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/interconnect/qcom/msm8974.c b/drivers/interconnect/qcom/msm8974.c
index 469fc48ebfe94d9ebb723132564583f4790d4850..3239edc37f02f20bd65fbbcb4aa48dc7953c7c09 100644
--- a/drivers/interconnect/qcom/msm8974.c
+++ b/drivers/interconnect/qcom/msm8974.c
@@ -173,9 +173,6 @@ enum {
MSM8974_SNOC_SLV_QDSS_STM,
};
-#define RPM_BUS_MASTER_REQ 0x73616d62
-#define RPM_BUS_SLAVE_REQ 0x766c7362
-
#define to_msm8974_icc_provider(_provider) \
container_of(_provider, struct msm8974_icc_provider, provider)
--
2.52.0
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] interconnect: qcom: msm8974: drop duplicated RPM_BUS_{MASTER,SLAVE}_REQ defines
2026-01-22 19:34 ` [PATCH 2/2] interconnect: qcom: msm8974: drop duplicated RPM_BUS_{MASTER,SLAVE}_REQ defines Gabor Juhos
@ 2026-01-22 19:43 ` Konrad Dybcio
2026-01-22 20:12 ` Dmitry Baryshkov
1 sibling, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2026-01-22 19:43 UTC (permalink / raw)
To: Gabor Juhos, Georgi Djakov; +Cc: linux-arm-msm, linux-pm, linux-kernel
On 1/22/26 8:34 PM, Gabor Juhos wrote:
> Both the RPM_BUS_MASTER_REQ and the RPM_BUS_SLAVE_REQ constants are
> also defined in the 'icc-rpm.h' header.
>
> $ git grep -nHE 'define[[:blank:]]+RPM_BUS_MASTER_REQ[[:blank:]]'
> drivers/interconnect/qcom/icc-rpm.h:16:#define RPM_BUS_MASTER_REQ 0x73616d62
> drivers/interconnect/qcom/msm8974.c:176:#define RPM_BUS_MASTER_REQ 0x73616d62
>
> $ git grep -nHE 'define[[:blank:]]+RPM_BUS_SLAVE_REQ[[:blank:]]'
> drivers/interconnect/qcom/icc-rpm.h:17:#define RPM_BUS_SLAVE_REQ 0x766c7362
> drivers/interconnect/qcom/msm8974.c:177:#define RPM_BUS_SLAVE_REQ 0x766c7362
>
> Drop the local defines to avoid the duplications.
>
> No functional changes intended. Compile tested only.
>
> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] interconnect: qcom: msm8974: drop duplicated RPM_BUS_{MASTER,SLAVE}_REQ defines
2026-01-22 19:34 ` [PATCH 2/2] interconnect: qcom: msm8974: drop duplicated RPM_BUS_{MASTER,SLAVE}_REQ defines Gabor Juhos
2026-01-22 19:43 ` Konrad Dybcio
@ 2026-01-22 20:12 ` Dmitry Baryshkov
1 sibling, 0 replies; 7+ messages in thread
From: Dmitry Baryshkov @ 2026-01-22 20:12 UTC (permalink / raw)
To: Gabor Juhos; +Cc: Georgi Djakov, linux-arm-msm, linux-pm, linux-kernel
On Thu, Jan 22, 2026 at 08:34:23PM +0100, Gabor Juhos wrote:
> Both the RPM_BUS_MASTER_REQ and the RPM_BUS_SLAVE_REQ constants are
> also defined in the 'icc-rpm.h' header.
>
> $ git grep -nHE 'define[[:blank:]]+RPM_BUS_MASTER_REQ[[:blank:]]'
> drivers/interconnect/qcom/icc-rpm.h:16:#define RPM_BUS_MASTER_REQ 0x73616d62
> drivers/interconnect/qcom/msm8974.c:176:#define RPM_BUS_MASTER_REQ 0x73616d62
>
> $ git grep -nHE 'define[[:blank:]]+RPM_BUS_SLAVE_REQ[[:blank:]]'
> drivers/interconnect/qcom/icc-rpm.h:17:#define RPM_BUS_SLAVE_REQ 0x766c7362
> drivers/interconnect/qcom/msm8974.c:177:#define RPM_BUS_SLAVE_REQ 0x766c7362
>
> Drop the local defines to avoid the duplications.
>
> No functional changes intended. Compile tested only.
>
> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
> ---
> drivers/interconnect/qcom/msm8974.c | 3 ---
> 1 file changed, 3 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-01-22 20:12 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-22 19:34 [PATCH 0/2] interconnect: qcom: remove some duplicated defines Gabor Juhos
2026-01-22 19:34 ` [PATCH 1/2] interconnect: qcom: smd-rpm: drop duplicated QCOM_RPM_SMD_KEY_RATE define Gabor Juhos
2026-01-22 19:43 ` Konrad Dybcio
2026-01-22 20:12 ` Dmitry Baryshkov
2026-01-22 19:34 ` [PATCH 2/2] interconnect: qcom: msm8974: drop duplicated RPM_BUS_{MASTER,SLAVE}_REQ defines Gabor Juhos
2026-01-22 19:43 ` Konrad Dybcio
2026-01-22 20:12 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®