[PATCH 1/2] exfat: remove unnecessary else after return statement

[PATCH 1/2] exfat: remove unnecessary else after return statement

[William Hansen-Baird]

Else-branch is unnecessary after return statement in if-branch.
Remove to enhance readability and reduce indentation.

Signed-off-by: William Hansen-Baird <william.hansen.baird@gmail.com>
---
 fs/exfat/inode.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/exfat/inode.c b/fs/exfat/inode.c
index f9501c3a3666..234a9f41e083 100644
--- a/fs/exfat/inode.c
+++ b/fs/exfat/inode.c
@@ -511,8 +511,9 @@ static ssize_t exfat_direct_IO(struct kiocb *iocb, struct iov_iter *iter)
 			exfat_write_failed(mapping, size);
 
 		return ret;
-	} else
-		size = pos + ret;
+	}
+
+	size = pos + ret;
 
 	if (rw == WRITE) {
 		/*
-- 
2.52.0

[PATCH 2/2] exfat: add blank line after declarations

[William Hansen-Baird]

Add a blank line after variable declarations in fatent.c and file.c.
This improves readability and makes code style more consistent
across the exfat subsystem.

Signed-off-by: William Hansen-Baird <william.hansen.baird@gmail.com>
---
 fs/exfat/fatent.c | 1 +
 fs/exfat/file.c   | 1 +
 2 files changed, 2 insertions(+)

diff --git a/fs/exfat/fatent.c b/fs/exfat/fatent.c
index c9c5f2e3a05e..543ce7e8d367 100644
--- a/fs/exfat/fatent.c
+++ b/fs/exfat/fatent.c
@@ -192,6 +192,7 @@ static int __exfat_free_cluster(struct inode *inode, struct exfat_chain *p_chain
 	if (p_chain->flags == ALLOC_NO_FAT_CHAIN) {
 		int err;
 		unsigned int last_cluster = p_chain->dir + p_chain->size - 1;
+
 		do {
 			bool sync = false;
 
diff --git a/fs/exfat/file.c b/fs/exfat/file.c
index 536c8078f0c1..c7cfa28a3e11 100644
--- a/fs/exfat/file.c
+++ b/fs/exfat/file.c
@@ -682,6 +682,7 @@ static ssize_t exfat_file_write_iter(struct kiocb *iocb, struct iov_iter *iter)
 
 	if (iocb->ki_pos > pos) {
 		ssize_t err = generic_write_sync(iocb, iocb->ki_pos - pos);
+
 		if (err < 0)
 			return err;
 	}
-- 
2.52.0

Re: [PATCH 1/2] exfat: remove unnecessary else after return statement

[Namjae Jeon]

On Thu, Jan 22, 2026 at 9:05 AM William Hansen-Baird
<william.hansen.baird@gmail.com> wrote:
>
> Else-branch is unnecessary after return statement in if-branch.
> Remove to enhance readability and reduce indentation.
>
> Signed-off-by: William Hansen-Baird <william.hansen.baird@gmail.com>
Applied it to #dev.
Thanks!

Re: [PATCH 2/2] exfat: add blank line after declarations

[Namjae Jeon]

On Thu, Jan 22, 2026 at 9:05 AM William Hansen-Baird
<william.hansen.baird@gmail.com> wrote:
>
> Add a blank line after variable declarations in fatent.c and file.c.
> This improves readability and makes code style more consistent
> across the exfat subsystem.
>
> Signed-off-by: William Hansen-Baird <william.hansen.baird@gmail.com>
Applied it to #dev.
Thanks!