mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
To: Yaxiong Tian <tianyaxiong@kylinos.cn>
Cc: srinivas.pandruvada@linux.intel.com, lenb@kernel.org,
	rafael@kernel.org, viresh.kumar@linaro.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: intel_pstate: Disable SMT when hybrid systems are enabled
Date: Thu, 22 Jan 2026 07:55:49 -0800	[thread overview]
Message-ID: <20260122155549.GA18021@ranerica-svr.sc.intel.com> (raw)
In-Reply-To: <20260119074118.835922-1-tianyaxiong@kylinos.cn>

On Mon, Jan 19, 2026 at 03:41:18PM +0800, Yaxiong Tian wrote:
> When hwp_is_hybrid && !sched_smt_active(), the driver enables
> hybrid_capacity_scale and disables ITMT. According to the original code
> logic, these related actions are one-time operations; therefore, I
> believe the original design intent did not support dynamic runtime
> switching.
> 
> However, SMT can be toggled via related interfaces in /sys. When SMT is
> enabled, the system is no longer hybrid, and the original settings become
> incorrect.

Indeed I was able to enable SMT siblings:

	$ echo on > /sys/devices/system/cpu/smt
	$ echo 1 > /sys/devices/system/cpu/cpu1/online

> 
> To resolve this confusion, permanently disable SMT by calling
> cpuhp_smt_disable().

IMHO, the user should be able to enable SMT back if she or he chooses to. Instead,
the sched domains should be rebuilt with asym packing and without asymmetric
capacity.

  reply	other threads:[~2026-01-22 15:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-19  7:41 Yaxiong Tian
2026-01-22 15:55 ` Ricardo Neri [this message]
2026-01-23  1:20   ` Yaxiong Tian
2026-01-23 20:12     ` Rafael J. Wysocki
2026-01-26  2:15       ` Yaxiong Tian
2026-01-27 16:08         ` Rafael J. Wysocki
2026-01-28  3:24           ` Yaxiong Tian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260122155549.GA18021@ranerica-svr.sc.intel.com \
    --to=ricardo.neri-calderon@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=tianyaxiong@kylinos.cn \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®