Re: [PATCH] cpufreq: intel_pstate: Disable SMT when hybrid systems are enabled

[Yaxiong Tian <tianyaxiong@kylinos.cn>]

在 2026/1/22 23:55, Ricardo Neri 写道:
> On Mon, Jan 19, 2026 at 03:41:18PM +0800, Yaxiong Tian wrote:
>> When hwp_is_hybrid && !sched_smt_active(), the driver enables
>> hybrid_capacity_scale and disables ITMT. According to the original code
>> logic, these related actions are one-time operations; therefore, I
>> believe the original design intent did not support dynamic runtime
>> switching.
>>
>> However, SMT can be toggled via related interfaces in /sys. When SMT is
>> enabled, the system is no longer hybrid, and the original settings become
>> incorrect.
> Indeed I was able to enable SMT siblings:
>
> 	$ echo on > /sys/devices/system/cpu/smt
> 	$ echo 1 > /sys/devices/system/cpu/cpu1/online
>
>> To resolve this confusion, permanently disable SMT by calling
>> cpuhp_smt_disable().
> IMHO, the user should be able to enable SMT back if she or he chooses to. Instead,
> the sched domains should be rebuilt with asym packing and without asymmetric
> capacity.
Yes, I also agree with this viewpoint. I think a better solution is to 
place it within cpufreq online for heterogeneous judgment and to clearly 
address sched domain rebuilt and asymmetry issues. I ran some tests the 
day before yesterday and encountered a few locking problems. I will 
publish the patch a bit later.