mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Huang <tehsiu.huang@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Michael Huang <tehsiu.huang@gmail.com>
Subject: [PATCH v5 0/7] staging: rtl8723bs: cleanup and refactorcleanup and indentation refactoring
Date: Sat, 24 Jan 2026 15:15:50 -0800	[thread overview]
Message-ID: <20260124231557.18189-1-tehsiu.huang@gmail.com> (raw)
In-Reply-To: <20260124104920.5721-1-tehsiu.huang@gmail.com>

This series refactors the function in rtw_mlme_ext.c to
improve readability and comply with Linux kernel coding standards.

Following feedback from Dan Carpenter, this version (v5) deconstructs
the previous changes into seven atomic patches. This separation ensures
that logical changes (such as flattening nested loops) are isolated
from purely stylistic cleanups (such as fixing indentation or NULL
checks), making the review process more straightforward and less
error-prone.

Each patch focuses on a single category of improvement:
1. Logic flattening: Use continue statements to reduce indentation.
2. Comment positioning: Adjust comments to align with new logic.
3. New lines cleanup: Removed unnecessary new lines
4. Line length compliance: Resolve 100-column limit warnings.
5. Operator spacing: Add missing spaces around logical operators.
6. Braces removal: Clean up unnecessary braces in single-line branches.
7. NULL check simplification: Use the "!ptr" convention for brevity.

---
Changes in v5:
- Split the series into 7 atomic patches for easier review.
- Renamed "guard clauses" to "continue statements" description per feedback.
- Separated logic changes, comment refactoring, and style cleanups.
- Fixed indentation issues (replaced spaces with tabs).
- Simplified NULL pointer checks to use the !ptr convention.

Changes in v4:
- Corrected the patch format by moving the changelog below the "---" line.
- Initial clean public submission of this series.


Michael Huang (7):
  staging: rtl8723bs: use continue statements to reduce indentation
  staging: rtl8723bs: refactor comments to fix the line length warning
    for exceeding 100 columns
  staging: rtl8723bs: remove unnecessary new lines
  staging: rtl8723bs: Fix the line length exceeding 100 columns warning
    in the code
  staging: rtl8723bs: add missing space around operators
  staging: rtl8723bs: remove unnecessary braces
  staging: rtl8723bs: use !ptr instead of ptr == NULL

 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 129 ++++++++++--------
 1 file changed, 70 insertions(+), 59 deletions(-)

--
2.43.0


  parent reply	other threads:[~2026-01-24 23:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-23 21:19 [PATCH v3 0/2] staging: rtl8723bs: cleanup " Michael Huang
2026-01-23 21:19 ` [PATCH v3 1/2] staging: rtl8723bs: refactor nested loops to reduce indentation Michael Huang
2026-01-24 10:59   ` Dan Carpenter
2026-01-23 21:19 ` [PATCH v3 2/2] staging: rtl8723bs: fix line length and coding style issues Michael Huang
2026-01-24  6:51 ` [PATCH v3 0/2] staging: rtl8723bs: cleanup and indentation refactoring Greg Kroah-Hartman
2026-01-24 10:49 ` [PATCH v4 " Michael Huang
2026-01-24 10:49   ` [PATCH v4 1/2] staging: rtl8723bs: refactor nested loops to reduce indentation Michael Huang
2026-01-24 10:49   ` [PATCH v4 2/2] staging: rtl8723bs: fix line length and coding style issues Michael Huang
2026-01-24 11:02     ` Dan Carpenter
2026-01-24 23:15   ` Michael Huang [this message]
2026-01-24 23:15     ` [PATCH v5 1/7] staging: rtl8723bs: use continue statements to reduce indentation Michael Huang
2026-01-25 18:13       ` Joe Perches
2026-01-25 23:20         ` Te-Hsiu Huang
2026-01-24 23:15     ` [PATCH v5 2/7] staging: rtl8723bs: refactor comments to fix the line length warning for exceeding 100 columns Michael Huang
2026-01-24 23:15     ` [PATCH v5 3/7] staging: rtl8723bs: remove unnecessary new lines Michael Huang
2026-01-24 23:15     ` [PATCH v5 4/7] staging: rtl8723bs: Fix the line length exceeding 100 columns warning in the code Michael Huang
2026-01-24 23:15     ` [PATCH v5 5/7] staging: rtl8723bs: add missing space around operators Michael Huang
2026-01-24 23:15     ` [PATCH v5 6/7] staging: rtl8723bs: remove unnecessary braces Michael Huang
2026-01-24 23:15     ` [PATCH v5 7/7] staging: rtl8723bs: use !ptr instead of ptr == NULL Michael Huang
2026-01-25 22:22     ` [PATCH v5 0/7] staging: rtl8723bs: cleanup and refactorcleanup and indentation refactoring Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260124231557.18189-1-tehsiu.huang@gmail.com \
    --to=tehsiu.huang@gmail.com \
    --cc=dan.carpenter@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®