* [PATCH] objtool: Print bfd_vma as unsigned long long on ia32-x86_64 cross build
@ 2026-01-26 4:57 Dmitry Safonov via B4 Relay
2026-01-27 0:22 ` Josh Poimboeuf
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dmitry Safonov via B4 Relay @ 2026-01-26 4:57 UTC (permalink / raw)
To: Josh Poimboeuf, Peter Zijlstra, Alexandre Chartre
Cc: Dmitry Safonov, linux-kernel, Dmitry Safonov
From: Dmitry Safonov <dima@arista.com>
When objtool is cross-compiled in ia32 container for x86_64 target it
fails with the following errors:
> disas.c: In function 'disas_print_addr_sym':
> disas.c:173:38: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'bfd_vma' {aka 'long long unsigned int'} [-Werror=format=]
> 173 | DINFO_FPRINTF(dinfo, "0x%lx <%s>", addr, symstr);
> | ^~~~~~~~~~~~ ~~~~
> | |
> | bfd_vma {aka long long unsigned int}
Provide a correct printf-fmt depending on sizeof(bfd_vma).
Cc: Alexandre Chartre <alexandre.chartre@oracle.com>
Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Josh Poimboeuf <jpoimboe@kernel.org>
Fixes: 5d859dff266f ("objtool: Print symbol during disassembly")
Signed-off-by: Dmitry Safonov <dima@arista.com>
---
tools/objtool/disas.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/tools/objtool/disas.c b/tools/objtool/disas.c
index 2b5059f55e40..26f08d41f2b1 100644
--- a/tools/objtool/disas.c
+++ b/tools/objtool/disas.c
@@ -108,6 +108,8 @@ static int sprint_name(char *str, const char *name, unsigned long offset)
#define DINFO_FPRINTF(dinfo, ...) \
((*(dinfo)->fprintf_func)((dinfo)->stream, __VA_ARGS__))
+#define bfd_vma_fmt \
+ __builtin_choose_expr(sizeof(bfd_vma) == sizeof(unsigned long), "%#lx <%s>", "%#llx <%s>")
static int disas_result_fprintf(struct disas_context *dctx,
const char *fmt, va_list ap)
@@ -170,10 +172,10 @@ static void disas_print_addr_sym(struct section *sec, struct symbol *sym,
if (sym) {
sprint_name(symstr, sym->name, addr - sym->offset);
- DINFO_FPRINTF(dinfo, "0x%lx <%s>", addr, symstr);
+ DINFO_FPRINTF(dinfo, bfd_vma_fmt, addr, symstr);
} else {
str = offstr(sec, addr);
- DINFO_FPRINTF(dinfo, "0x%lx <%s>", addr, str);
+ DINFO_FPRINTF(dinfo, bfd_vma_fmt, addr, str);
free(str);
}
}
@@ -252,7 +254,7 @@ static void disas_print_addr_reloc(bfd_vma addr, struct disassemble_info *dinfo)
* example: "lea 0x0(%rip),%rdi". The kernel can reference
* the next IP with _THIS_IP_ macro.
*/
- DINFO_FPRINTF(dinfo, "0x%lx <_THIS_IP_>", addr);
+ DINFO_FPRINTF(dinfo, bfd_vma_fmt, addr, "_THIS_IP_");
return;
}
@@ -264,11 +266,11 @@ static void disas_print_addr_reloc(bfd_vma addr, struct disassemble_info *dinfo)
*/
if (reloc->sym->type == STT_SECTION) {
str = offstr(reloc->sym->sec, reloc->sym->offset + offset);
- DINFO_FPRINTF(dinfo, "0x%lx <%s>", addr, str);
+ DINFO_FPRINTF(dinfo, bfd_vma_fmt, addr, str);
free(str);
} else {
sprint_name(symstr, reloc->sym->name, offset);
- DINFO_FPRINTF(dinfo, "0x%lx <%s>", addr, symstr);
+ DINFO_FPRINTF(dinfo, bfd_vma_fmt, addr, symstr);
}
}
@@ -311,7 +313,7 @@ static void disas_print_address(bfd_vma addr, struct disassemble_info *dinfo)
*/
sym = insn_call_dest(insn);
if (sym && (sym->offset == addr || (sym->offset == 0 && is_reloc))) {
- DINFO_FPRINTF(dinfo, "0x%lx <%s>", addr, sym->name);
+ DINFO_FPRINTF(dinfo, bfd_vma_fmt, addr, sym->name);
return;
}
---
base-commit: ca3a02fda4da8e2c1cb6baee5d72352e9e2cfaea
change-id: 20260126-objtool-ia32-84f2ba28de2a
Best regards,
--
Dmitry Safonov <dima@arista.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] objtool: Print bfd_vma as unsigned long long on ia32-x86_64 cross build
2026-01-26 4:57 [PATCH] objtool: Print bfd_vma as unsigned long long on ia32-x86_64 cross build Dmitry Safonov via B4 Relay
@ 2026-01-27 0:22 ` Josh Poimboeuf
2026-01-27 8:43 ` Alexandre Chartre
2026-01-28 8:46 ` [tip: objtool/urgent] " tip-bot2 for Dmitry Safonov
2 siblings, 0 replies; 4+ messages in thread
From: Josh Poimboeuf @ 2026-01-27 0:22 UTC (permalink / raw)
To: Dmitry Safonov
Cc: Peter Zijlstra, Alexandre Chartre, Dmitry Safonov, linux-kernel
On Mon, Jan 26, 2026 at 04:57:35AM +0000, Dmitry Safonov wrote:
> When objtool is cross-compiled in ia32 container for x86_64 target it
> fails with the following errors:
>
> > disas.c: In function 'disas_print_addr_sym':
> > disas.c:173:38: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'bfd_vma' {aka 'long long unsigned int'} [-Werror=format=]
> > 173 | DINFO_FPRINTF(dinfo, "0x%lx <%s>", addr, symstr);
> > | ^~~~~~~~~~~~ ~~~~
> > | |
> > | bfd_vma {aka long long unsigned int}
>
> Provide a correct printf-fmt depending on sizeof(bfd_vma).
>
> Cc: Alexandre Chartre <alexandre.chartre@oracle.com>
> Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
> Cc: Josh Poimboeuf <jpoimboe@kernel.org>
> Fixes: 5d859dff266f ("objtool: Print symbol during disassembly")
> Signed-off-by: Dmitry Safonov <dima@arista.com>
Thanks!
Acked-by: Josh Poimboeuf <jpoimboe@kernel.org>
--
Josh
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] objtool: Print bfd_vma as unsigned long long on ia32-x86_64 cross build
2026-01-26 4:57 [PATCH] objtool: Print bfd_vma as unsigned long long on ia32-x86_64 cross build Dmitry Safonov via B4 Relay
2026-01-27 0:22 ` Josh Poimboeuf
@ 2026-01-27 8:43 ` Alexandre Chartre
2026-01-28 8:46 ` [tip: objtool/urgent] " tip-bot2 for Dmitry Safonov
2 siblings, 0 replies; 4+ messages in thread
From: Alexandre Chartre @ 2026-01-27 8:43 UTC (permalink / raw)
To: dima, Josh Poimboeuf, Peter Zijlstra
Cc: alexandre.chartre, Dmitry Safonov, linux-kernel
On 1/26/26 05:57, Dmitry Safonov via B4 Relay wrote:
> From: Dmitry Safonov <dima@arista.com>
>
> When objtool is cross-compiled in ia32 container for x86_64 target it
> fails with the following errors:
>
>> disas.c: In function 'disas_print_addr_sym':
>> disas.c:173:38: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'bfd_vma' {aka 'long long unsigned int'} [-Werror=format=]
>> 173 | DINFO_FPRINTF(dinfo, "0x%lx <%s>", addr, symstr);
>> | ^~~~~~~~~~~~ ~~~~
>> | |
>> | bfd_vma {aka long long unsigned int}
>
> Provide a correct printf-fmt depending on sizeof(bfd_vma).
>
> Cc: Alexandre Chartre <alexandre.chartre@oracle.com>
> Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
> Cc: Josh Poimboeuf <jpoimboe@kernel.org>
> Fixes: 5d859dff266f ("objtool: Print symbol during disassembly")
> Signed-off-by: Dmitry Safonov <dima@arista.com>
> ---
> tools/objtool/disas.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
Reviewed-by: Alexandre Chartre <alexandre.chartre@oracle.com>
Thanks,
alex.
^ permalink raw reply [flat|nested] 4+ messages in thread* [tip: objtool/urgent] objtool: Print bfd_vma as unsigned long long on ia32-x86_64 cross build
2026-01-26 4:57 [PATCH] objtool: Print bfd_vma as unsigned long long on ia32-x86_64 cross build Dmitry Safonov via B4 Relay
2026-01-27 0:22 ` Josh Poimboeuf
2026-01-27 8:43 ` Alexandre Chartre
@ 2026-01-28 8:46 ` tip-bot2 for Dmitry Safonov
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot2 for Dmitry Safonov @ 2026-01-28 8:46 UTC (permalink / raw)
To: linux-tip-commits
Cc: Dmitry Safonov, Alexandre Chartre, Josh Poimboeuf, x86, linux-kernel
The following commit has been merged into the objtool/urgent branch of tip:
Commit-ID: fd4eeb30b9e30ca1118a618be0755287bcbb2da9
Gitweb: https://git.kernel.org/tip/fd4eeb30b9e30ca1118a618be0755287bcbb2da9
Author: Dmitry Safonov <dima@arista.com>
AuthorDate: Mon, 26 Jan 2026 04:57:35
Committer: Josh Poimboeuf <jpoimboe@kernel.org>
CommitterDate: Tue, 27 Jan 2026 08:19:35 -08:00
objtool: Print bfd_vma as unsigned long long on ia32-x86_64 cross build
When objtool is cross-compiled in ia32 container for x86_64 target it
fails with the following errors:
> disas.c: In function 'disas_print_addr_sym':
> disas.c:173:38: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'bfd_vma' {aka 'long long unsigned int'} [-Werror=format=]
> 173 | DINFO_FPRINTF(dinfo, "0x%lx <%s>", addr, symstr);
> | ^~~~~~~~~~~~ ~~~~
> | |
> | bfd_vma {aka long long unsigned int}
Provide a correct printf-fmt depending on sizeof(bfd_vma).
Fixes: 5d859dff266f ("objtool: Print symbol during disassembly")
Signed-off-by: Dmitry Safonov <dima@arista.com>
Reviewed-by: Alexandre Chartre <alexandre.chartre@oracle.com>
Link: https://patch.msgid.link/20260126-objtool-ia32-v1-1-bb6feaf17566@arista.com
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
---
tools/objtool/disas.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/tools/objtool/disas.c b/tools/objtool/disas.c
index 2b5059f..26f08d4 100644
--- a/tools/objtool/disas.c
+++ b/tools/objtool/disas.c
@@ -108,6 +108,8 @@ static int sprint_name(char *str, const char *name, unsigned long offset)
#define DINFO_FPRINTF(dinfo, ...) \
((*(dinfo)->fprintf_func)((dinfo)->stream, __VA_ARGS__))
+#define bfd_vma_fmt \
+ __builtin_choose_expr(sizeof(bfd_vma) == sizeof(unsigned long), "%#lx <%s>", "%#llx <%s>")
static int disas_result_fprintf(struct disas_context *dctx,
const char *fmt, va_list ap)
@@ -170,10 +172,10 @@ static void disas_print_addr_sym(struct section *sec, struct symbol *sym,
if (sym) {
sprint_name(symstr, sym->name, addr - sym->offset);
- DINFO_FPRINTF(dinfo, "0x%lx <%s>", addr, symstr);
+ DINFO_FPRINTF(dinfo, bfd_vma_fmt, addr, symstr);
} else {
str = offstr(sec, addr);
- DINFO_FPRINTF(dinfo, "0x%lx <%s>", addr, str);
+ DINFO_FPRINTF(dinfo, bfd_vma_fmt, addr, str);
free(str);
}
}
@@ -252,7 +254,7 @@ static void disas_print_addr_reloc(bfd_vma addr, struct disassemble_info *dinfo)
* example: "lea 0x0(%rip),%rdi". The kernel can reference
* the next IP with _THIS_IP_ macro.
*/
- DINFO_FPRINTF(dinfo, "0x%lx <_THIS_IP_>", addr);
+ DINFO_FPRINTF(dinfo, bfd_vma_fmt, addr, "_THIS_IP_");
return;
}
@@ -264,11 +266,11 @@ static void disas_print_addr_reloc(bfd_vma addr, struct disassemble_info *dinfo)
*/
if (reloc->sym->type == STT_SECTION) {
str = offstr(reloc->sym->sec, reloc->sym->offset + offset);
- DINFO_FPRINTF(dinfo, "0x%lx <%s>", addr, str);
+ DINFO_FPRINTF(dinfo, bfd_vma_fmt, addr, str);
free(str);
} else {
sprint_name(symstr, reloc->sym->name, offset);
- DINFO_FPRINTF(dinfo, "0x%lx <%s>", addr, symstr);
+ DINFO_FPRINTF(dinfo, bfd_vma_fmt, addr, symstr);
}
}
@@ -311,7 +313,7 @@ static void disas_print_address(bfd_vma addr, struct disassemble_info *dinfo)
*/
sym = insn_call_dest(insn);
if (sym && (sym->offset == addr || (sym->offset == 0 && is_reloc))) {
- DINFO_FPRINTF(dinfo, "0x%lx <%s>", addr, sym->name);
+ DINFO_FPRINTF(dinfo, bfd_vma_fmt, addr, sym->name);
return;
}
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-01-28 8:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-26 4:57 [PATCH] objtool: Print bfd_vma as unsigned long long on ia32-x86_64 cross build Dmitry Safonov via B4 Relay
2026-01-27 0:22 ` Josh Poimboeuf
2026-01-27 8:43 ` Alexandre Chartre
2026-01-28 8:46 ` [tip: objtool/urgent] " tip-bot2 for Dmitry Safonov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®