* [PATCH v1 1/1] spi: dw: Remove duplicate error message
@ 2026-01-28 9:57 Andy Shevchenko
2026-01-28 15:32 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2026-01-28 9:57 UTC (permalink / raw)
To: Mark Brown, Benoît Monin, linux-spi, linux-kernel; +Cc: Andy Shevchenko
devm_platform_ioremap_resource() prints an error message depending on
the actual error. The caller doesn't need to repeat that.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/spi/spi-dw-mmio.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c
index 33239b4778cb..1332fdbf9a21 100644
--- a/drivers/spi/spi-dw-mmio.c
+++ b/drivers/spi/spi-dw-mmio.c
@@ -104,10 +104,8 @@ static int dw_spi_mscc_init(struct platform_device *pdev,
return -ENOMEM;
dwsmscc->spi_mst = devm_platform_ioremap_resource(pdev, 1);
- if (IS_ERR(dwsmscc->spi_mst)) {
- dev_err(&pdev->dev, "SPI_MST region map failed\n");
+ if (IS_ERR(dwsmscc->spi_mst))
return PTR_ERR(dwsmscc->spi_mst);
- }
dwsmscc->syscon = syscon_regmap_lookup_by_compatible(cpu_syscon);
if (IS_ERR(dwsmscc->syscon))
--
2.50.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] spi: dw: Remove duplicate error message
2026-01-28 9:57 [PATCH v1 1/1] spi: dw: Remove duplicate error message Andy Shevchenko
@ 2026-01-28 15:32 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2026-01-28 15:32 UTC (permalink / raw)
To: Benoît Monin, linux-spi, linux-kernel, Andy Shevchenko
On Wed, 28 Jan 2026 10:57:48 +0100, Andy Shevchenko wrote:
> devm_platform_ioremap_resource() prints an error message depending on
> the actual error. The caller doesn't need to repeat that.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: dw: Remove duplicate error message
commit: 5c6808d10499f6c8a8d5ee948a22fc93814f6d66
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-28 15:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-28 9:57 [PATCH v1 1/1] spi: dw: Remove duplicate error message Andy Shevchenko
2026-01-28 15:32 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®