mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eliot Courtney <ecourtney@nvidia.com>
To: Danilo Krummrich <dakr@kernel.org>,
	 Alexandre Courbot <acourbot@nvidia.com>,
	Alice Ryhl <aliceryhl@google.com>,
	 David Airlie <airlied@gmail.com>,
	Simona Vetter <simona@ffwll.ch>,
	 Alistair Popple <apopple@nvidia.com>
Cc: nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org,
	 dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	 Eliot Courtney <ecourtney@nvidia.com>
Subject: [PATCH v3 0/5] gpu: nova-core: gsp: fix command queue ring buffer bugs
Date: Thu, 29 Jan 2026 16:44:58 +0900	[thread overview]
Message-ID: <20260129-nova-core-cmdq1-v3-0-2ede85493a27@nvidia.com> (raw)

This series fixes a few bugs in the GSP command queue ring buffer
implementation in nova-core and also clarifies some of the comments.

The ring buffer uses read and write pointers (rx/tx) to track which areas
are available for the CPU vs the GSP to read/write into.

In the ring buffers there were some indexing issues which could end up
causing panics, so I fixed those and added more rigorous proofs of
correctness in the panic comments.

Signed-off-by: Eliot Courtney <ecourtney@nvidia.com>
---
Changes in v3:
- Use `&mut []` instead of `&mut xyz[0..0]` for empty slices.
- Simplify driver_read_area by removing unnecessary split_at.
- Use range notation for comments (e.g., `is within 0..MSGQ_NUM_PAGES`).
- Fix up branch order to mirror existing code.
- Link to v2: https://lore.kernel.org/r/20260123-nova-core-cmdq1-v2-0-e797ec1b714c@nvidia.com

Changes in v2:
- Modified PANIC comments to match existing style.
- Link to v1: https://lore.kernel.org/r/20260122-nova-core-cmdq1-v1-0-7f8fe4683f11@nvidia.com

---
Eliot Courtney (5):
      gpu: nova-core: gsp: fix incorrect advancing of write pointer
      gpu: nova-core: gsp: clarify comments about invariants and pointer roles
      gpu: nova-core: gsp: use empty slices instead of [0..0] ranges
      gpu: nova-core: gsp: fix improper handling of empty slot in cmdq
      gpu: nova-core: gsp: fix improper indexing in driver_read_area

 drivers/gpu/nova-core/gsp/cmdq.rs | 71 +++++++++++++++++++++++----------------
 1 file changed, 42 insertions(+), 29 deletions(-)
---
base-commit: 58d26d42818c0f8c9b334cc7cf318b43046e675f
change-id: 20260121-nova-core-cmdq1-6aaa369824c4

Best regards,
-- 
Eliot Courtney <ecourtney@nvidia.com>


             reply	other threads:[~2026-01-29  7:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-29  7:44 Eliot Courtney [this message]
2026-01-29  7:44 ` [PATCH v3 1/5] gpu: nova-core: gsp: fix incorrect advancing of write pointer Eliot Courtney
2026-01-29  7:45 ` [PATCH v3 2/5] gpu: nova-core: gsp: clarify comments about invariants and pointer roles Eliot Courtney
2026-01-29  7:45 ` [PATCH v3 3/5] gpu: nova-core: gsp: use empty slices instead of [0..0] ranges Eliot Courtney
2026-01-29  7:45 ` [PATCH v3 4/5] gpu: nova-core: gsp: fix improper handling of empty slot in cmdq Eliot Courtney
2026-01-29  7:45 ` [PATCH v3 5/5] gpu: nova-core: gsp: fix improper indexing in driver_read_area Eliot Courtney
2026-01-29 14:21 ` [PATCH v3 0/5] gpu: nova-core: gsp: fix command queue ring buffer bugs Gary Guo
2026-02-06  7:29 ` Alexandre Courbot
2026-02-25  1:00   ` Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260129-nova-core-cmdq1-v3-0-2ede85493a27@nvidia.com \
    --to=ecourtney@nvidia.com \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=apopple@nvidia.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®