From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Eliot Courtney" <ecourtney@nvidia.com>
Cc: "Danilo Krummrich" <dakr@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Alistair Popple" <apopple@nvidia.com>,
<nouveau@lists.freedesktop.org>, <rust-for-linux@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 0/5] gpu: nova-core: gsp: fix command queue ring buffer bugs
Date: Wed, 25 Feb 2026 10:00:18 +0900 [thread overview]
Message-ID: <DGNMX1SJGJ8W.2FS8H3B0KQ1BQ@nvidia.com> (raw)
In-Reply-To: <DG7PAWIOZYWA.1S53TGBSPWGVW@nvidia.com>
On Fri Feb 6, 2026 at 4:29 PM JST, Alexandre Courbot wrote:
> On Thu Jan 29, 2026 at 4:44 PM JST, Eliot Courtney wrote:
>> This series fixes a few bugs in the GSP command queue ring buffer
>> implementation in nova-core and also clarifies some of the comments.
>>
>> The ring buffer uses read and write pointers (rx/tx) to track which areas
>> are available for the CPU vs the GSP to read/write into.
>>
>> In the ring buffers there were some indexing issues which could end up
>> causing panics, so I fixed those and added more rigorous proofs of
>> correctness in the panic comments.
>>
>> Signed-off-by: Eliot Courtney <ecourtney@nvidia.com>
>
> Staged the series for pushing into `drm-rust-next` as soon as it
> reopens. Thanks for these critical fixes!
Pushed into `drm-rust-next`.
prev parent reply other threads:[~2026-02-25 1:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 7:44 Eliot Courtney
2026-01-29 7:44 ` [PATCH v3 1/5] gpu: nova-core: gsp: fix incorrect advancing of write pointer Eliot Courtney
2026-01-29 7:45 ` [PATCH v3 2/5] gpu: nova-core: gsp: clarify comments about invariants and pointer roles Eliot Courtney
2026-01-29 7:45 ` [PATCH v3 3/5] gpu: nova-core: gsp: use empty slices instead of [0..0] ranges Eliot Courtney
2026-01-29 7:45 ` [PATCH v3 4/5] gpu: nova-core: gsp: fix improper handling of empty slot in cmdq Eliot Courtney
2026-01-29 7:45 ` [PATCH v3 5/5] gpu: nova-core: gsp: fix improper indexing in driver_read_area Eliot Courtney
2026-01-29 14:21 ` [PATCH v3 0/5] gpu: nova-core: gsp: fix command queue ring buffer bugs Gary Guo
2026-02-06 7:29 ` Alexandre Courbot
2026-02-25 1:00 ` Alexandre Courbot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGNMX1SJGJ8W.2FS8H3B0KQ1BQ@nvidia.com \
--to=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ecourtney@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®