From: Shivansh Dhiman <shivansh.dhiman@amd.com>
To: <seanjc@google.com>, <pbonzini@redhat.com>,
<linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>
Cc: <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
<xin@zytor.com>, <nikunj.dadhania@amd.com>,
<santosh.shukla@amd.com>
Subject: [PATCH 3/7] KVM: SVM: Save restore FRED_RSP0 for FRED supported guests
Date: Thu, 29 Jan 2026 06:36:49 +0000 [thread overview]
Message-ID: <20260129063653.3553076-4-shivansh.dhiman@amd.com> (raw)
In-Reply-To: <20260129063653.3553076-1-shivansh.dhiman@amd.com>
From: Neeraj Upadhyay <Neeraj.Upadhyay@amd.com>
Hardware does not save/restore FRED_RSP0 for Non-SEV-ES guests.
Save/restore it early in svm_vcpu_enter_exit() so that the
correct physical CPU state is updated.
Synchronize the current value of MSR_IA32_FRED_RSP0 in hardware to the kernel's
local cache. Note that the desired host's RSP0 will be set when the CPU exits to
userspace for servicing vCPU tasks.
Signed-off-by: Neeraj Upadhyay <Neeraj.Upadhyay@amd.com>
Co-developed-by: Shivansh Dhiman <shivansh.dhiman@amd.com>
Signed-off-by: Shivansh Dhiman <shivansh.dhiman@amd.com>
---
arch/x86/kvm/svm/svm.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
index 05e44e804aba..ddd8941af6f0 100644
--- a/arch/x86/kvm/svm/svm.c
+++ b/arch/x86/kvm/svm/svm.c
@@ -4192,6 +4192,15 @@ static noinstr void svm_vcpu_enter_exit(struct kvm_vcpu *vcpu, bool spec_ctrl_in
{
struct svm_cpu_data *sd = per_cpu_ptr(&svm_data, vcpu->cpu);
struct vcpu_svm *svm = to_svm(vcpu);
+ bool update_fred_rsp0;
+
+ /*
+ * Hardware does not save/restore FRED_RSP0 for Non-SEV-ES guests.
+ */
+ update_fred_rsp0 = !sev_es_guest(vcpu->kvm) && guest_cpu_cap_has(vcpu, X86_FEATURE_FRED);
+
+ if (update_fred_rsp0)
+ wrmsrq(MSR_IA32_FRED_RSP0, svm->vmcb->save.fred_rsp0);
guest_state_enter_irqoff();
@@ -4218,6 +4227,15 @@ static noinstr void svm_vcpu_enter_exit(struct kvm_vcpu *vcpu, bool spec_ctrl_in
raw_local_irq_disable();
guest_state_exit_irqoff();
+
+ if (update_fred_rsp0) {
+ rdmsrq(MSR_IA32_FRED_RSP0, svm->vmcb->save.fred_rsp0);
+ /*
+ * Sync hardware MSR value to per-CPU cache. This helps in restoring
+ * Host RSP0 when exiting to userspace in fred_update_rsp0().
+ */
+ fred_sync_rsp0(svm->vmcb->save.fred_rsp0);
+ }
}
static __no_kcsan fastpath_t svm_vcpu_run(struct kvm_vcpu *vcpu, u64 run_flags)
--
2.43.0
next prev parent reply other threads:[~2026-01-29 6:38 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 6:36 [PATCH 0/7] KVM: SVM: Enable FRED support Shivansh Dhiman
2026-01-29 6:36 ` [PATCH 1/7] KVM: SVM: Initialize FRED VMCB fields Shivansh Dhiman
2026-03-07 1:58 ` Sean Christopherson
2026-03-09 17:46 ` Shivansh Dhiman
2026-03-09 18:57 ` Sean Christopherson
2026-03-11 4:18 ` Shivansh Dhiman
2026-03-27 6:41 ` Shivansh Dhiman
2026-01-29 6:36 ` [PATCH 2/7] KVM: SVM: Disable interception of FRED MSRs for FRED supported guests Shivansh Dhiman
2026-03-07 2:10 ` Sean Christopherson
2026-03-09 17:47 ` Shivansh Dhiman
2026-01-29 6:36 ` Shivansh Dhiman [this message]
2026-03-05 20:37 ` [PATCH 3/7] KVM: SVM: Save restore FRED_RSP0 " Shivansh Dhiman
2026-01-29 6:36 ` [PATCH 4/7] KVM: SVM: Populate FRED event data on event injection Shivansh Dhiman
2026-03-06 11:31 ` Paolo Bonzini
2026-03-09 19:47 ` Shivansh Dhiman
2026-01-29 6:36 ` [PATCH 5/7] KVM: SVM: Support FRED nested exception injection Shivansh Dhiman
2026-03-07 2:07 ` Sean Christopherson
2026-03-10 15:56 ` Shivansh Dhiman
2026-03-10 16:20 ` Sean Christopherson
2026-03-11 4:12 ` Shivansh Dhiman
2026-01-29 6:36 ` [PATCH 6/7] KVM: SVM: Dump FRED context in dump_vmcb() Shivansh Dhiman
2026-03-07 2:03 ` Sean Christopherson
2026-03-09 19:57 ` Shivansh Dhiman
2026-01-29 6:36 ` [PATCH 7/7] KVM: SVM: Enable save/restore of FRED MSRs Shivansh Dhiman
2026-03-07 2:14 ` Sean Christopherson
2026-03-09 18:20 ` Shivansh Dhiman
2026-08-10 8:39 ` Shivansh Dhiman
2026-08-12 23:27 ` Sean Christopherson
2026-08-13 8:19 ` Nikunj A. Dadhania
2026-08-13 23:47 ` Sean Christopherson
2026-08-14 3:07 ` Nikunj A. Dadhania
2026-08-14 16:57 ` Sean Christopherson
2026-08-19 12:08 ` Shivansh Dhiman
2026-08-21 13:28 ` Sean Christopherson
2026-08-24 6:30 ` Shivansh Dhiman
2026-02-06 9:22 ` [PATCH 0/7] KVM: SVM: Enable FRED support Shivansh Dhiman
2026-02-11 0:53 ` Andrew Cooper
2026-03-06 9:33 ` Shivansh Dhiman
2026-03-03 17:58 ` Shivansh Dhiman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260129063653.3553076-4-shivansh.dhiman@amd.com \
--to=shivansh.dhiman@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nikunj.dadhania@amd.com \
--cc=pbonzini@redhat.com \
--cc=santosh.shukla@amd.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®