From: Shivansh Dhiman <shivansh.dhiman@amd.com>
To: <seanjc@google.com>, <pbonzini@redhat.com>,
<linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>
Cc: <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
<xin@zytor.com>, <nikunj.dadhania@amd.com>,
<santosh.shukla@amd.com>
Subject: [PATCH 4/7] KVM: SVM: Populate FRED event data on event injection
Date: Thu, 29 Jan 2026 06:36:50 +0000 [thread overview]
Message-ID: <20260129063653.3553076-5-shivansh.dhiman@amd.com> (raw)
In-Reply-To: <20260129063653.3553076-1-shivansh.dhiman@amd.com>
From: Neeraj Upadhyay <Neeraj.Upadhyay@amd.com>
Set injected-event data (in EVENTINJDATA) when injecting an event,
use EXITINTDATA for populating the injected-event data during
reinjection.
Unlike IDT using some extra CPU register as part of an event
context, e.g., %cr2 for #PF, FRED saves a complete event context
in its stack frame, e.g., FRED saves the faulting linear address
of a #PF into the event data field defined in its stack frame.
Populate the EVENTINJDATA during event injection. The event data
will be pushed into a FRED stack frame for VM entries that inject
an event using FRED event delivery.
Signed-off-by: Neeraj Upadhyay <Neeraj.Upadhyay@amd.com>
Co-developed-by: Shivansh Dhiman <shivansh.dhiman@amd.com>
Signed-off-by: Shivansh Dhiman <shivansh.dhiman@amd.com>
---
arch/x86/kvm/svm/svm.c | 22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
index ddd8941af6f0..693b46d715b4 100644
--- a/arch/x86/kvm/svm/svm.c
+++ b/arch/x86/kvm/svm/svm.c
@@ -374,6 +374,10 @@ static void svm_inject_exception(struct kvm_vcpu *vcpu)
| SVM_EVTINJ_VALID
| (ex->has_error_code ? SVM_EVTINJ_VALID_ERR : 0)
| SVM_EVTINJ_TYPE_EXEPT;
+
+ if (is_fred_enabled(vcpu))
+ svm->vmcb->control.event_inj_data = ex->event_data;
+
svm->vmcb->control.event_inj_err = ex->error_code;
}
@@ -4066,7 +4070,7 @@ static void svm_complete_soft_interrupt(struct kvm_vcpu *vcpu, u8 vector,
kvm_rip_write(vcpu, svm->soft_int_old_rip);
}
-static void svm_complete_interrupts(struct kvm_vcpu *vcpu)
+static void svm_complete_interrupts(struct kvm_vcpu *vcpu, bool reinject_on_vmexit)
{
struct vcpu_svm *svm = to_svm(vcpu);
u8 vector;
@@ -4111,6 +4115,7 @@ static void svm_complete_interrupts(struct kvm_vcpu *vcpu)
break;
case SVM_EXITINTINFO_TYPE_EXEPT: {
u32 error_code = 0;
+ u64 event_data = 0;
/*
* Never re-inject a #VC exception.
@@ -4121,9 +4126,18 @@ static void svm_complete_interrupts(struct kvm_vcpu *vcpu)
if (exitintinfo & SVM_EXITINTINFO_VALID_ERR)
error_code = svm->vmcb->control.exit_int_info_err;
+ /*
+ * FRED requires an additional field to pass injected-event
+ * data to the guest.
+ */
+ if (is_fred_enabled(vcpu) && (vector == PF_VECTOR || vector == DB_VECTOR))
+ event_data = reinject_on_vmexit ?
+ svm->vmcb->control.exit_int_data :
+ svm->vmcb->control.event_inj_data;
+
kvm_requeue_exception(vcpu, vector,
exitintinfo & SVM_EXITINTINFO_VALID_ERR,
- error_code, false, 0);
+ error_code, false, event_data);
break;
}
case SVM_EXITINTINFO_TYPE_INTR:
@@ -4146,7 +4160,7 @@ static void svm_cancel_injection(struct kvm_vcpu *vcpu)
control->exit_int_info = control->event_inj;
control->exit_int_info_err = control->event_inj_err;
control->event_inj = 0;
- svm_complete_interrupts(vcpu);
+ svm_complete_interrupts(vcpu, false);
}
static int svm_vcpu_pre_run(struct kvm_vcpu *vcpu)
@@ -4382,7 +4396,7 @@ static __no_kcsan fastpath_t svm_vcpu_run(struct kvm_vcpu *vcpu, u64 run_flags)
trace_kvm_exit(vcpu, KVM_ISA_SVM);
- svm_complete_interrupts(vcpu);
+ svm_complete_interrupts(vcpu, true);
return svm_exit_handlers_fastpath(vcpu);
}
--
2.43.0
next prev parent reply other threads:[~2026-01-29 6:39 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 6:36 [PATCH 0/7] KVM: SVM: Enable FRED support Shivansh Dhiman
2026-01-29 6:36 ` [PATCH 1/7] KVM: SVM: Initialize FRED VMCB fields Shivansh Dhiman
2026-03-07 1:58 ` Sean Christopherson
2026-03-09 17:46 ` Shivansh Dhiman
2026-03-09 18:57 ` Sean Christopherson
2026-03-11 4:18 ` Shivansh Dhiman
2026-03-27 6:41 ` Shivansh Dhiman
2026-01-29 6:36 ` [PATCH 2/7] KVM: SVM: Disable interception of FRED MSRs for FRED supported guests Shivansh Dhiman
2026-03-07 2:10 ` Sean Christopherson
2026-03-09 17:47 ` Shivansh Dhiman
2026-01-29 6:36 ` [PATCH 3/7] KVM: SVM: Save restore FRED_RSP0 " Shivansh Dhiman
2026-03-05 20:37 ` Shivansh Dhiman
2026-01-29 6:36 ` Shivansh Dhiman [this message]
2026-03-06 11:31 ` [PATCH 4/7] KVM: SVM: Populate FRED event data on event injection Paolo Bonzini
2026-03-09 19:47 ` Shivansh Dhiman
2026-01-29 6:36 ` [PATCH 5/7] KVM: SVM: Support FRED nested exception injection Shivansh Dhiman
2026-03-07 2:07 ` Sean Christopherson
2026-03-10 15:56 ` Shivansh Dhiman
2026-03-10 16:20 ` Sean Christopherson
2026-03-11 4:12 ` Shivansh Dhiman
2026-01-29 6:36 ` [PATCH 6/7] KVM: SVM: Dump FRED context in dump_vmcb() Shivansh Dhiman
2026-03-07 2:03 ` Sean Christopherson
2026-03-09 19:57 ` Shivansh Dhiman
2026-01-29 6:36 ` [PATCH 7/7] KVM: SVM: Enable save/restore of FRED MSRs Shivansh Dhiman
2026-03-07 2:14 ` Sean Christopherson
2026-03-09 18:20 ` Shivansh Dhiman
2026-08-10 8:39 ` Shivansh Dhiman
2026-08-12 23:27 ` Sean Christopherson
2026-08-13 8:19 ` Nikunj A. Dadhania
2026-08-13 23:47 ` Sean Christopherson
2026-08-14 3:07 ` Nikunj A. Dadhania
2026-08-14 16:57 ` Sean Christopherson
2026-08-19 12:08 ` Shivansh Dhiman
2026-08-21 13:28 ` Sean Christopherson
2026-08-24 6:30 ` Shivansh Dhiman
2026-02-06 9:22 ` [PATCH 0/7] KVM: SVM: Enable FRED support Shivansh Dhiman
2026-02-11 0:53 ` Andrew Cooper
2026-03-06 9:33 ` Shivansh Dhiman
2026-03-03 17:58 ` Shivansh Dhiman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260129063653.3553076-5-shivansh.dhiman@amd.com \
--to=shivansh.dhiman@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nikunj.dadhania@amd.com \
--cc=pbonzini@redhat.com \
--cc=santosh.shukla@amd.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®