mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH net] net: sched: act_api: size RTM_GETACTION reply by fill size
@ 2026-01-30 13:43 Paul Moses
  2026-01-30 16:05 ` Jamal Hadi Salim
  0 siblings, 1 reply; 18+ messages in thread
From: Paul Moses @ 2026-01-30 13:43 UTC (permalink / raw)
  To: netdev
  Cc: jhs, xiyou.wangcong, jiri, davem, edumazet, kuba, pabeni, horms,
	linux-kernel, Paul Moses, stable

tcf_action_fill_size() already computes the required dump size, but
RTM_GETACTION replies always allocate NLMSG_GOODSIZE. Large action
state can overrun that skb and make dumps fail.

Use the computed reply size for RTM_GETACTION replies so large actions
can be dumped, while still keeping NLMSG_GOODSIZE as a floor.

Fixes: 4e76e75d6aba ("net sched actions: calculate add/delete event message size")
Cc: stable@vger.kernel.org
Signed-off-by: Paul Moses <p@1g4.org>
---
 net/sched/act_api.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/net/sched/act_api.c b/net/sched/act_api.c
index e1ab0faeb8113..8ab016d352850 100644
--- a/net/sched/act_api.c
+++ b/net/sched/act_api.c
@@ -1685,12 +1685,12 @@ static int tca_get_fill(struct sk_buff *skb, struct tc_action *actions[],
 
 static int
 tcf_get_notify(struct net *net, u32 portid, struct nlmsghdr *n,
-	       struct tc_action *actions[], int event,
+	       struct tc_action *actions[], int event, size_t attr_size,
 	       struct netlink_ext_ack *extack)
 {
 	struct sk_buff *skb;
 
-	skb = alloc_skb(NLMSG_GOODSIZE, GFP_KERNEL);
+	skb = alloc_skb(max_t(size_t, attr_size, NLMSG_GOODSIZE), GFP_KERNEL);
 	if (!skb)
 		return -ENOBUFS;
 	if (tca_get_fill(skb, actions, portid, n->nlmsg_seq, 0, event,
@@ -2041,7 +2041,8 @@ tca_action_gd(struct net *net, struct nlattr *nla, struct nlmsghdr *n,
 	attr_size = tcf_action_full_attrs_size(attr_size);
 
 	if (event == RTM_GETACTION)
-		ret = tcf_get_notify(net, portid, n, actions, event, extack);
+		ret = tcf_get_notify(net, portid, n, actions, event,
+				     attr_size, extack);
 	else { /* delete */
 		ret = tcf_del_notify(net, n, actions, portid, attr_size, extack);
 		if (ret)
-- 
2.52.GIT



^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2026-02-06 13:33 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-30 13:43 [PATCH net] net: sched: act_api: size RTM_GETACTION reply by fill size Paul Moses
2026-01-30 16:05 ` Jamal Hadi Salim
2026-01-30 17:22   ` Paul Moses
2026-01-30 17:53     ` Jamal Hadi Salim
2026-01-30 20:47       ` Paul Moses
2026-01-31 16:51         ` Jamal Hadi Salim
2026-01-31 17:14           ` Jamal Hadi Salim
2026-01-31 17:18             ` Paul Moses
2026-01-31 17:34               ` Jamal Hadi Salim
2026-02-01  9:57                 ` Paul Moses
2026-02-02 14:33                   ` Jamal Hadi Salim
2026-02-02 20:49                     ` Paul Moses
2026-02-05 15:13                       ` Paul Moses
2026-02-05 19:23                         ` Jamal Hadi Salim
2026-02-05 20:36                           ` Vladimir Oltean
2026-02-05 21:30                             ` Jamal Hadi Salim
2026-02-05 22:11                               ` Vladimir Oltean
2026-02-06 13:33                                 ` Jamal Hadi Salim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®