* [PATCH] bus: moxtet: fix reference count leak in moxtet_add_device()
@ 2026-01-31 9:47 Salah Triki
2026-02-02 13:23 ` Marek Behún
0 siblings, 1 reply; 2+ messages in thread
From: Salah Triki @ 2026-01-31 9:47 UTC (permalink / raw)
To: Marek Behún; +Cc: linux-kernel, Salah Triki
If `device_add()` fails, the reference count of the device is not
dropped. This leads to a memory leak of the device and its associated
resources.
`put_device()` must be called if `device_add()` fails to properly clean up
the device structure.
Fixes: 5bc7f990cd98f ("bus: Add support for Moxtet bus")
Signed-off-by: Salah Triki <salah.triki@gmail.com>
---
drivers/bus/moxtet.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/moxtet.c b/drivers/bus/moxtet.c
index 7ce61d629a87..35795deba2a9 100644
--- a/drivers/bus/moxtet.c
+++ b/drivers/bus/moxtet.c
@@ -179,9 +179,11 @@ static int moxtet_add_device(struct moxtet_device *dev)
goto done;
ret = device_add(&dev->dev);
- if (ret < 0)
+ if (ret < 0) {
dev_err(dev->moxtet->dev, "can't add %s, status %d\n",
dev_name(dev->moxtet->dev), ret);
+ put_device(&dev->dev);
+ }
done:
mutex_unlock(&add_mutex);
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-02 13:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-31 9:47 [PATCH] bus: moxtet: fix reference count leak in moxtet_add_device() Salah Triki
2026-02-02 13:23 ` Marek Behún
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®