From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
borntraeger@de.ibm.com, frankja@linux.ibm.com, nsg@linux.ibm.com,
nrb@linux.ibm.com, seiden@linux.ibm.com, gra@linux.ibm.com,
schlameuss@linux.ibm.com, hca@linux.ibm.com, svens@linux.ibm.com,
agordeev@linux.ibm.com, gor@linux.ibm.com, david@kernel.org,
gerald.schaefer@linux.ibm.com
Subject: [PATCH v7 27/29] KVM: s390: Enable 1M pages for gmap
Date: Wed, 4 Feb 2026 16:02:56 +0100 [thread overview]
Message-ID: <20260204150259.60425-28-imbrenda@linux.ibm.com> (raw)
In-Reply-To: <20260204150259.60425-1-imbrenda@linux.ibm.com>
While userspace is allowed to have pages of any size, the new gmap
would always use 4k pages to back the guest.
Enable 1M pages for gmap.
This allows 1M pages to be used to back a guest when userspace is using
1M pages for the corresponding addresses (e.g. THP or hugetlbfs).
Remove the limitation that disallowed having nested guests and
hugepages at the same time.
Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
---
arch/s390/kvm/gmap.c | 2 +-
arch/s390/kvm/kvm-s390.c | 6 +-----
arch/s390/kvm/pv.c | 3 +++
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/arch/s390/kvm/gmap.c b/arch/s390/kvm/gmap.c
index fea1c66fcabe..da222962ef6d 100644
--- a/arch/s390/kvm/gmap.c
+++ b/arch/s390/kvm/gmap.c
@@ -620,7 +620,7 @@ static inline bool gmap_2g_allowed(struct gmap *gmap, gfn_t gfn)
static inline bool gmap_1m_allowed(struct gmap *gmap, gfn_t gfn)
{
- return false;
+ return test_bit(GMAP_FLAG_ALLOW_HPAGE_1M, &gmap->flags);
}
int gmap_link(struct kvm_s390_mmu_cache *mc, struct gmap *gmap, struct guest_fault *f)
diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
index bde55761bf8a..ac7b5f56f0b5 100644
--- a/arch/s390/kvm/kvm-s390.c
+++ b/arch/s390/kvm/kvm-s390.c
@@ -851,6 +851,7 @@ int kvm_vm_ioctl_enable_cap(struct kvm *kvm, struct kvm_enable_cap *cap)
r = -EINVAL;
else {
r = 0;
+ set_bit(GMAP_FLAG_ALLOW_HPAGE_1M, &kvm->arch.gmap->flags);
/*
* We might have to create fake 4k page
* tables. To avoid that the hardware works on
@@ -5729,11 +5730,6 @@ static int __init kvm_s390_init(void)
return -ENODEV;
}
- if (nested && hpage) {
- pr_info("A KVM host that supports nesting cannot back its KVM guests with huge pages\n");
- return -EINVAL;
- }
-
for (i = 0; i < 16; i++)
kvm_s390_fac_base[i] |=
stfle_fac_list[i] & nonhyp_mask(i);
diff --git a/arch/s390/kvm/pv.c b/arch/s390/kvm/pv.c
index a48a8afd40df..461b413c76a3 100644
--- a/arch/s390/kvm/pv.c
+++ b/arch/s390/kvm/pv.c
@@ -721,6 +721,9 @@ int kvm_s390_pv_init_vm(struct kvm *kvm, u16 *rc, u16 *rrc)
uvcb.flags.ap_allow_instr = kvm->arch.model.uv_feat_guest.ap;
uvcb.flags.ap_instr_intr = kvm->arch.model.uv_feat_guest.ap_intr;
+ clear_bit(GMAP_FLAG_ALLOW_HPAGE_1M, &kvm->arch.gmap->flags);
+ gmap_split_huge_pages(kvm->arch.gmap);
+
cc = uv_call_sched(0, (u64)&uvcb);
*rc = uvcb.header.rc;
*rrc = uvcb.header.rrc;
--
2.52.0
next prev parent reply other threads:[~2026-02-04 15:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 15:02 [PATCH v7 00/29] KVM: s390: gmap rewrite, the real deal Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 01/29] KVM: s390: Refactor pgste lock and unlock functions Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 02/29] KVM: s390: Add P bit in table entry bitfields, move union vaddress Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 03/29] s390: Make UV folio operations work on whole folio Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 04/29] s390: Move sske_frame() to a header Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 05/29] KVM: s390: Add gmap_helper_set_unused() Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 06/29] KVM: s390: Introduce import_lock Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 07/29] KVM: s390: Export two functions Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 08/29] s390/mm: Warn if uv_convert_from_secure_pte() fails Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 09/29] KVM: s390: vsie: Pass gmap explicitly as parameter Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 10/29] KVM: s390: Enable KVM_GENERIC_MMU_NOTIFIER Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 11/29] KVM: s390: Rename some functions in gaccess.c Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 12/29] KVM: s390: KVM-specific bitfields and helper functions Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 13/29] KVM: s390: KVM page table management functions: allocation Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 14/29] KVM: s390: KVM page table management functions: clear and replace Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 15/29] KVM: s390: KVM page table management functions: walks Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 16/29] KVM: s390: KVM page table management functions: storage keys Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 17/29] KVM: s390: KVM page table management functions: lifecycle management Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 18/29] KVM: s390: KVM page table management functions: CMMA Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 19/29] KVM: s390: New gmap code Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 20/29] KVM: s390: Add helper functions for fault handling Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 21/29] KVM: s390: Add some helper functions needed for vSIE Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 22/29] KVM: s390: Stop using CONFIG_PGSTE Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 23/29] KVM: s390: Storage key functions refactoring Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 24/29] KVM: s390: Switch to new gmap Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 25/29] KVM: s390: Remove gmap from s390/mm Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 26/29] KVM: S390: Remove PGSTE code from linux/s390 mm Claudio Imbrenda
2026-02-04 15:02 ` Claudio Imbrenda [this message]
2026-02-04 15:02 ` [PATCH v7 28/29] KVM: s390: Storage key manipulation IOCTL Claudio Imbrenda
2026-02-04 15:02 ` [PATCH v7 29/29] KVM: s390: selftests: Add selftest for the KVM_S390_KEYOP ioctl Claudio Imbrenda
2026-02-04 15:23 ` [PATCH v7 00/29] KVM: s390: gmap rewrite, the real deal Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260204150259.60425-28-imbrenda@linux.ibm.com \
--to=imbrenda@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=david@kernel.org \
--cc=frankja@linux.ibm.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=gra@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=nsg@linux.ibm.com \
--cc=schlameuss@linux.ibm.com \
--cc=seiden@linux.ibm.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®