From: Michael Dege <michael.dege@renesas.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Michael Dege <michael.dege@renesas.com>
Subject: [PATCH net] net: renesas: rswitch: fix forwarding offload statemachine
Date: Thu, 05 Feb 2026 08:14:40 +0100 [thread overview]
Message-ID: <20260205-fix-offloading-statemachine-v1-1-640224a531d0@renesas.com> (raw)
A change of the port state of one port, caused the state of another
port to change. This behvior was unintended.
Signed-off-by: Michael Dege <michael.dege@renesas.com>
---
A change of the port state of one port, caused the state of another
port to change. This behvior was unintended.
Fixes: b7502b1043de86967ff341819d05e09a8dbe8b2b ("net: renesas: rswitch: add offloading for L2 switching")
---
drivers/net/ethernet/renesas/rswitch_l2.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/renesas/rswitch_l2.c b/drivers/net/ethernet/renesas/rswitch_l2.c
index 4a69ec77d69c..dcf726793bdc 100644
--- a/drivers/net/ethernet/renesas/rswitch_l2.c
+++ b/drivers/net/ethernet/renesas/rswitch_l2.c
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/* Renesas Ethernet Switch device driver
*
- * Copyright (C) 2025 Renesas Electronics Corporation
+ * Copyright (C) 2025 - 2026 Renesas Electronics Corporation
*/
#include <linux/err.h>
@@ -88,7 +88,8 @@ static void rswitch_update_l2_hw_forwarding(struct rswitch_private *priv)
rdev->forwarding_requested &&
!rdev->forwarding_offloaded) {
rswitch_change_l2_hw_offloading(rdev, true, false);
- } else if (rdev->forwarding_offloaded) {
+ } else if (rdev->forwarding_offloaded &&
+ !rdev->forwarding_requested) {
rswitch_change_l2_hw_offloading(rdev, false, false);
}
}
---
base-commit: f14faaf3a1fb3b9e4cf2e56269711fb85fba9458
change-id: 20260205-fix-offloading-statemachine-1d301630a08d
Best regards,
--
Michael Dege <michael.dege@renesas.com>
next reply other threads:[~2026-02-05 7:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 7:14 Michael Dege [this message]
2026-02-05 7:47 ` Nikita Yushchenko
2026-02-05 7:48 ` Nikita Yushchenko
2026-02-05 7:51 ` Michael Dege
2026-02-05 7:58 ` Nikita Yushchenko
2026-02-05 12:49 ` Michael Dege
2026-02-05 13:38 ` Nikita Yushchenko
2026-02-05 13:46 ` Michael Dege
2026-02-05 13:57 ` Nikita Yushchenko
2026-02-05 14:35 ` Michael Dege
2026-02-05 14:41 ` Nikita Yushchenko
2026-02-05 14:44 ` Nikita Yushchenko
2026-02-06 5:41 ` Michael Dege
2026-02-06 10:31 ` Nikita Yushchenko
2026-02-06 10:34 ` Nikita Yushchenko
2026-02-06 13:21 ` Michael Dege
2026-02-06 15:55 ` Andrew Lunn
2026-02-06 16:10 ` Nikita Yushchenko
2026-02-06 17:17 ` Andrew Lunn
2026-02-05 15:03 ` Nikita Yushchenko
2026-02-06 5:54 ` Michael Dege
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260205-fix-offloading-statemachine-v1-1-640224a531d0@renesas.com \
--to=michael.dege@renesas.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikita.yoush@cogentembedded.com \
--cc=pabeni@redhat.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®