* [PATCH] crypto: inside-secure/eip93 - fix register definition
@ 2026-02-08 10:35 Aleksander Jan Bajkowski
2026-02-28 8:43 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Aleksander Jan Bajkowski @ 2026-02-08 10:35 UTC (permalink / raw)
To: ansuelsmth, atenart, herbert, davem, vschagen, linux-crypto,
linux-kernel
Cc: Aleksander Jan Bajkowski
Checked the register definitions with the documentation[1]. Turns out
that the PKTE_INBUF_CNT register has a bad offset. It's used in Direct
Host Mode (DHM). The driver uses Autonomous Ring Mode (ARM), so it
causes no harm.
1. ADSP-SC58x/ADSP-2158x SHARC+ Processor Hardware Reference
Fixes: 9739f5f93b78 ("crypto: eip93 - Add Inside Secure SafeXcel EIP-93 crypto engine support")
Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
---
drivers/crypto/inside-secure/eip93/eip93-regs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/inside-secure/eip93/eip93-regs.h b/drivers/crypto/inside-secure/eip93/eip93-regs.h
index 0490b8d15131..116b3fbb6ad7 100644
--- a/drivers/crypto/inside-secure/eip93/eip93-regs.h
+++ b/drivers/crypto/inside-secure/eip93/eip93-regs.h
@@ -109,7 +109,7 @@
#define EIP93_REG_PE_BUF_THRESH 0x10c
#define EIP93_PE_OUTBUF_THRESH GENMASK(23, 16)
#define EIP93_PE_INBUF_THRESH GENMASK(7, 0)
-#define EIP93_REG_PE_INBUF_COUNT 0x100
+#define EIP93_REG_PE_INBUF_COUNT 0x110
#define EIP93_REG_PE_OUTBUF_COUNT 0x114
#define EIP93_REG_PE_BUF_RW_PNTR 0x118 /* BUF_PNTR */
--
2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: inside-secure/eip93 - fix register definition
2026-02-08 10:35 [PATCH] crypto: inside-secure/eip93 - fix register definition Aleksander Jan Bajkowski
@ 2026-02-28 8:43 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2026-02-28 8:43 UTC (permalink / raw)
To: Aleksander Jan Bajkowski
Cc: ansuelsmth, atenart, davem, vschagen, linux-crypto, linux-kernel
On Sun, Feb 08, 2026 at 11:35:53AM +0100, Aleksander Jan Bajkowski wrote:
> Checked the register definitions with the documentation[1]. Turns out
> that the PKTE_INBUF_CNT register has a bad offset. It's used in Direct
> Host Mode (DHM). The driver uses Autonomous Ring Mode (ARM), so it
> causes no harm.
>
> 1. ADSP-SC58x/ADSP-2158x SHARC+ Processor Hardware Reference
> Fixes: 9739f5f93b78 ("crypto: eip93 - Add Inside Secure SafeXcel EIP-93 crypto engine support")
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
> ---
> drivers/crypto/inside-secure/eip93/eip93-regs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-28 8:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-08 10:35 [PATCH] crypto: inside-secure/eip93 - fix register definition Aleksander Jan Bajkowski
2026-02-28 8:43 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®