* [PATCH] md: suppress spurious superblock update warning for dm-raid
@ 2026-02-10 12:41 chencheng
2026-02-10 7:49 ` Paul Menzel
0 siblings, 1 reply; 2+ messages in thread
From: chencheng @ 2026-02-10 12:41 UTC (permalink / raw)
To: song, yukuai, linux-raid, linux-kernel; +Cc: chencheng
dm-raid have external metadata management (mddev->external = 1) and
no persistent superblock (mddev->persistent = 0). For these arrays,
there's no superblock to update, so the warning is spurious.
Signed-off-by: chencheng <chencheng@fnnas.com>
---
drivers/md/md.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 6d73f6e196a..e30b658641e 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -2790,7 +2790,9 @@ void md_update_sb(struct mddev *mddev, int force_change)
if (!md_is_rdwr(mddev)) {
if (force_change)
set_bit(MD_SB_CHANGE_DEVS, &mddev->sb_flags);
- pr_err("%s: can't update sb for read-only array %s\n", __func__, mdname(mddev));
+ if (!mddev_is_dm(mddev))
+ pr_err_ratelimited("%s: can't update sb for read-only array %s\n",
+ __func__, mdname(mddev));
return;
}
--
2.51.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] md: suppress spurious superblock update warning for dm-raid
2026-02-10 12:41 [PATCH] md: suppress spurious superblock update warning for dm-raid chencheng
@ 2026-02-10 7:49 ` Paul Menzel
0 siblings, 0 replies; 2+ messages in thread
From: Paul Menzel @ 2026-02-10 7:49 UTC (permalink / raw)
To: chencheng; +Cc: song, yukuai, linux-raid, linux-kernel
Dear Chen,
Thank you for your patch.
Am 10.02.26 um 13:41 schrieb chencheng:
> dm-raid have external metadata management (mddev->external = 1) and
> no persistent superblock (mddev->persistent = 0). For these arrays,
> there's no superblock to update, so the warning is spurious.
Please paste the warning.
Please also add a Fixes: tag.
> Signed-off-by: chencheng <chencheng@fnnas.com>
Would Chen Cheng be the official (transcribed) spelling of your name. If
you yes, it’d be great, if you updated it:
git config --global user.name "Chen Cheng"
git commit --amend -s --author="Chen Cheng <chencheng@fnnas.com>"
> ---
> drivers/md/md.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 6d73f6e196a..e30b658641e 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -2790,7 +2790,9 @@ void md_update_sb(struct mddev *mddev, int force_change)
> if (!md_is_rdwr(mddev)) {
> if (force_change)
> set_bit(MD_SB_CHANGE_DEVS, &mddev->sb_flags);
> - pr_err("%s: can't update sb for read-only array %s\n", __func__, mdname(mddev));
> + if (!mddev_is_dm(mddev))
> + pr_err_ratelimited("%s: can't update sb for read-only array %s\n",
> + __func__, mdname(mddev));
(It looks like it’s an error level message and not a warning level message.)
> return;
> }
With the commit message suggestions addressed, feel free to add:
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-10 7:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-10 12:41 [PATCH] md: suppress spurious superblock update warning for dm-raid chencheng
2026-02-10 7:49 ` Paul Menzel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®