* [PATCH] staging: rtl8723bs: split multiple assignment in osdep_service.c
@ 2026-02-11 7:04 Juyeong Jun
2026-02-11 8:59 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Juyeong Jun @ 2026-02-11 7:04 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, grizzo
From: grizzo <grizzo@ubuntu22.04.myguest.virtualbox.org>
Avoid multiple assignments in a single statement.
No functional change.
---
drivers/staging/rtl8723bs/os_dep/osdep_service.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
index a00f9f0c85c5..19b378b49809 100644
--- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
+++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
@@ -226,7 +226,8 @@ struct rtw_cbuf *rtw_cbuf_alloc(u32 size)
cbuf = rtw_malloc(struct_size(cbuf, bufs, size));
if (cbuf) {
- cbuf->write = cbuf->read = 0;
+ cbuf->write = 0;
+ cbuf->read = 0;
cbuf->size = size;
}
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: rtl8723bs: split multiple assignment in osdep_service.c
2026-02-11 7:04 [PATCH] staging: rtl8723bs: split multiple assignment in osdep_service.c Juyeong Jun
@ 2026-02-11 8:59 ` Greg Kroah-Hartman
2026-02-11 9:46 ` Juyeong Jun
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2026-02-11 8:59 UTC (permalink / raw)
To: Juyeong Jun; +Cc: linux-staging, linux-kernel, grizzo
On Wed, Feb 11, 2026 at 04:04:12PM +0900, Juyeong Jun wrote:
> From: grizzo <grizzo@ubuntu22.04.myguest.virtualbox.org>
Something went wrong with your git setup :(
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: rtl8723bs: split multiple assignment in osdep_service.c
2026-02-11 8:59 ` Greg Kroah-Hartman
@ 2026-02-11 9:46 ` Juyeong Jun
2026-02-11 10:58 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Juyeong Jun @ 2026-02-11 9:46 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, Juyeong Jun
v2:
- Fix incorrect Author email in commit
Sorry for the mistake. This is my first time, and I sent a new email instead of a reply. Resending as a reply. My apologies
Avoid multiple assignments in a single statement.
No functional change.
---
drivers/staging/rtl8723bs/os_dep/osdep_service.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
index a00f9f0c85c5..19b378b49809 100644
--- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
+++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
@@ -226,7 +226,8 @@ struct rtw_cbuf *rtw_cbuf_alloc(u32 size)
cbuf = rtw_malloc(struct_size(cbuf, bufs, size));
if (cbuf) {
- cbuf->write = cbuf->read = 0;
+ cbuf->write = 0;
+ cbuf->read = 0;
cbuf->size = size;
}
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: rtl8723bs: split multiple assignment in osdep_service.c
2026-02-11 9:46 ` Juyeong Jun
@ 2026-02-11 10:58 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2026-02-11 10:58 UTC (permalink / raw)
To: Juyeong Jun; +Cc: Greg Kroah-Hartman, linux-staging, linux-kernel
On Wed, Feb 11, 2026 at 06:46:34PM +0900, Juyeong Jun wrote:
> v2:
> - Fix incorrect Author email in commit
>
> Sorry for the mistake. This is my first time, and I sent a new email instead of a reply. Resending as a reply. My apologies
>
> Avoid multiple assignments in a single statement.
> No functional change.
> ---
This isn't the right format.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: rtl8723bs: split multiple assignment in osdep_service.c
@ 2026-02-11 9:37 Juyeong Jun
0 siblings, 0 replies; 5+ messages in thread
From: Juyeong Jun @ 2026-02-11 9:37 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, Juyeong Jun
v2:
- Fix incorrect Author email in commit
Avoid multiple assignments in a single statement.
No functional change.
---
drivers/staging/rtl8723bs/os_dep/osdep_service.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
index a00f9f0c85c5..19b378b49809 100644
--- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
+++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
@@ -226,7 +226,8 @@ struct rtw_cbuf *rtw_cbuf_alloc(u32 size)
cbuf = rtw_malloc(struct_size(cbuf, bufs, size));
if (cbuf) {
- cbuf->write = cbuf->read = 0;
+ cbuf->write = 0;
+ cbuf->read = 0;
cbuf->size = size;
}
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-02-11 10:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-11 7:04 [PATCH] staging: rtl8723bs: split multiple assignment in osdep_service.c Juyeong Jun
2026-02-11 8:59 ` Greg Kroah-Hartman
2026-02-11 9:46 ` Juyeong Jun
2026-02-11 10:58 ` Dan Carpenter
2026-02-11 9:37 Juyeong Jun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®