mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Metz <peter.metz@unarin.com>
To: hansg@kernel.org
Cc: alexhung@gmail.com, ilpo.jarvinen@linux.intel.com,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, 23edip@gmail.com
Subject: [PATCH 2/2] platform/x86: intel-hid: Add Dell 16 Plus 2-in-1 to dmi_vgbs_allow_list
Date: Fri, 13 Feb 2026 17:58:02 -0500	[thread overview]
Message-ID: <20260213230310.299974-1-peter.metz@unarin.com> (raw)
In-Reply-To: <21babe2b-89ed-419c-ac08-e9130ba576b4@kernel.org>

The Dell 16 Plus 2-in-1 (model DB06250) requires the VGBS allow list
entry to correctly enable the tablet mode switch. Without this, the
chassis state is not reported, and the hinge rotation only emits
unknown scancodes.

Link: https://lore.kernel.org/platform-driver-x86/CAP3yi-BWm0LqkhfzTrGy5n-KQ=3+T8eRMoR+Z+7Ke2VJB43kTA@mail.gmail.com/
Signed-off-by: Peter Metz <peter.metz@unarin.com>
---
Hi Hans,

Thanks for the review! I'd be happy to help out with more fixes.
Here is the follow-up patch for the Dell 16 Plus (DB06250)
to address that report.

Cheers,
Peter

 drivers/platform/x86/intel/hid.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c
index 60ce32f591ff..a8ae2dba7ffd 100644
--- a/drivers/platform/x86/intel/hid.c
+++ b/drivers/platform/x86/intel/hid.c
@@ -195,6 +195,12 @@ static const struct dmi_system_id dmi_vgbs_allow_list[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Dell 14 Plus 2-in-1 DB04250"),
 		},
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Dell 16 Plus 2-in-1 DB06250"),
+		},
+	},
 	{ }
 };
 
-- 
Cheers,
Peter Metz


  reply	other threads:[~2026-02-13 23:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13  4:46 [PATCH] platform/x86: intel-hid: Add Dell 14 " Peter Metz
2026-02-13 16:52 ` Hans de Goede
2026-02-13 16:54 ` Hans de Goede
2026-02-13 22:58   ` Peter Metz [this message]
2026-02-16 18:40     ` [PATCH 2/2] platform/x86: intel-hid: Add Dell 16 " Hans de Goede
2026-02-23 16:34 ` [PATCH] platform/x86: intel-hid: Add Dell 14 " Ilpo Järvinen
2026-02-27 23:58   ` Peter Metz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260213230310.299974-1-peter.metz@unarin.com \
    --to=peter.metz@unarin.com \
    --cc=23edip@gmail.com \
    --cc=alexhung@gmail.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®