mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans de Goede <hansg@kernel.org>
To: Peter Metz <peter.metz@unarin.com>,
	alexhung@gmail.com, ilpo.jarvinen@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: intel-hid: Add Dell 14 Plus 2-in-1 to dmi_vgbs_allow_list
Date: Fri, 13 Feb 2026 17:52:02 +0100	[thread overview]
Message-ID: <614aea0f-d17b-4a6b-8b2a-168fb387541e@kernel.org> (raw)
In-Reply-To: <20260213044627.203638-1-peter.metz@unarin.com>

Hi,

On 13-Feb-26 05:46, Peter Metz wrote:
> The Dell 14 Plus 2-in-1 (model DB04250) requires the VGBS allow list
> entry to correctly enable the tablet mode switch. Without this, the
> chassis state is not reported, and the hinge rotation only emits
> unknown scancodes.
> 
> Verified on Dell 14 Plus 2-in-1 DB04250.
> 
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221090
> Signed-off-by: Peter Metz <peter.metz@unarin.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>

Regards,

Hans




> ---
>  drivers/platform/x86/intel/hid.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c
> index 560cc0631..5b475a096 100644
> --- a/drivers/platform/x86/intel/hid.c
> +++ b/drivers/platform/x86/intel/hid.c
> @@ -189,6 +189,12 @@ static const struct dmi_system_id dmi_vgbs_allow_list[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Dell Pro Rugged 12 Tablet RA02260"),
>  		},
>  	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Dell 14 Plus 2-in-1 DB04250"),
> +		},
> +	},
>  	{ }
>  };
>  


  reply	other threads:[~2026-02-13 16:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13  4:46 Peter Metz
2026-02-13 16:52 ` Hans de Goede [this message]
2026-02-13 16:54 ` Hans de Goede
2026-02-13 22:58   ` [PATCH 2/2] platform/x86: intel-hid: Add Dell 16 " Peter Metz
2026-02-16 18:40     ` Hans de Goede
2026-02-23 16:34 ` [PATCH] platform/x86: intel-hid: Add Dell 14 " Ilpo Järvinen
2026-02-27 23:58   ` Peter Metz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=614aea0f-d17b-4a6b-8b2a-168fb387541e@kernel.org \
    --to=hansg@kernel.org \
    --cc=alexhung@gmail.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.metz@unarin.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome