From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Ethan Tidmore" <ethantidmore06@gmail.com>
Subject: [PATCH v1 0/7] iio: light: gp2ap020a00f: Set of ad-hoc cleanups
Date: Tue, 17 Feb 2026 11:15:10 +0100 [thread overview]
Message-ID: <20260217102318.1354103-1-andriy.shevchenko@linux.intel.com> (raw)
While reviewing the series from Ethan, I looked at the code of the driver
and found a lot of room to improve. Also there are some questions about
how driver was tested initially.
The third patch reveals the strange asymmetry (and I believe a few bugs)
in the state machine with commands where some clear_bit() and set_bit()
are being called in the error cases as well. This needs a serious audit
of the driver algorithm for which I don't have time, nor possess the HW.
The fourth patch moves error check in one case into the loop, and hence
I think fixes a preexisted bug. Perhaps this needs to be added to the commit
message and/or split to a separate change.
The rest of the patches do not affect functional behaviour. It might be that
the first one needs more thorough review.
Note, this series is not tested at all and I rely on Ethan to make necessary
compilation tests and rebase again, as it's based on his series and includes
something that has to be initially in his patches.
Andy Shevchenko (7):
iio: light: gp2ap020a00f: Use correct types for 16-bit LE data
iio: light: gp2ap020a00f: Replace custom implementation of min()
iio: light: gp2ap020a00f: Return directly from the switch cases
iio: light: gp2ap020a00f: Use temporary variable for struct device
iio: light: gp2ap020a00f: Explicitly use string literal for driver
name
iio: light: gp2ap020a00f: Remove trailing comma in termination entry
iio: light: gp2ap020a00f: Join some lines of code to be a single line
drivers/iio/light/gp2ap020a00f.c | 210 +++++++++++++------------------
1 file changed, 84 insertions(+), 126 deletions(-)
--
2.50.1
next reply other threads:[~2026-02-17 10:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 10:15 Andy Shevchenko [this message]
2026-02-17 10:15 ` [PATCH v1 1/7] iio: light: gp2ap020a00f: Use correct types for 16-bit LE data Andy Shevchenko
2026-02-17 10:15 ` [PATCH v1 2/7] iio: light: gp2ap020a00f: Replace custom implementation of min() Andy Shevchenko
2026-02-17 10:15 ` [PATCH v1 3/7] iio: light: gp2ap020a00f: Return directly from the switch cases Andy Shevchenko
2026-02-17 10:15 ` [PATCH v1 4/7] iio: light: gp2ap020a00f: Use temporary variable for struct device Andy Shevchenko
2026-02-17 10:15 ` [PATCH v1 5/7] iio: light: gp2ap020a00f: Explicitly use string literal for driver name Andy Shevchenko
2026-02-17 10:15 ` [PATCH v1 6/7] iio: light: gp2ap020a00f: Remove trailing comma in termination entry Andy Shevchenko
2026-02-17 10:15 ` [PATCH v1 7/7] iio: light: gp2ap020a00f: Join some lines of code to be a single line Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260217102318.1354103-1-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=ethantidmore06@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome