From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Ethan Tidmore" <ethantidmore06@gmail.com>
Subject: [PATCH v1 5/7] iio: light: gp2ap020a00f: Explicitly use string literal for driver name
Date: Tue, 17 Feb 2026 11:15:15 +0100 [thread overview]
Message-ID: <20260217102318.1354103-6-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20260217102318.1354103-1-andriy.shevchenko@linux.intel.com>
The driver name should be easily greppable and clearly spelled.
Replace a level of indirection and explicitly use string literal.
While at it, remove useless blank lines before module_*() and
MODULE_*() macros.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/iio/light/gp2ap020a00f.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a00f.c
index af5eb77cb8c6..95479154b6a4 100644
--- a/drivers/iio/light/gp2ap020a00f.c
+++ b/drivers/iio/light/gp2ap020a00f.c
@@ -55,8 +55,6 @@
#include <linux/iio/trigger_consumer.h>
#include <linux/iio/triggered_buffer.h>
-#define GP2A_I2C_NAME "gp2ap020a00f"
-
/* Registers */
#define GP2AP020A00F_OP_REG 0x00 /* Basic operations */
#define GP2AP020A00F_ALS_REG 0x01 /* ALS related settings */
@@ -1543,10 +1541,9 @@ static void gp2ap020a00f_remove(struct i2c_client *client)
}
static const struct i2c_device_id gp2ap020a00f_id[] = {
- { GP2A_I2C_NAME },
+ { "gp2ap020a00f" },
{ }
};
-
MODULE_DEVICE_TABLE(i2c, gp2ap020a00f_id);
static const struct of_device_id gp2ap020a00f_of_match[] = {
@@ -1557,14 +1554,13 @@ MODULE_DEVICE_TABLE(of, gp2ap020a00f_of_match);
static struct i2c_driver gp2ap020a00f_driver = {
.driver = {
- .name = GP2A_I2C_NAME,
+ .name = "gp2ap020a00f",
.of_match_table = gp2ap020a00f_of_match,
},
.probe = gp2ap020a00f_probe,
.remove = gp2ap020a00f_remove,
.id_table = gp2ap020a00f_id,
};
-
module_i2c_driver(gp2ap020a00f_driver);
MODULE_AUTHOR("Jacek Anaszewski <j.anaszewski@samsung.com>");
--
2.50.1
next prev parent reply other threads:[~2026-02-17 10:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 10:15 [PATCH v1 0/7] iio: light: gp2ap020a00f: Set of ad-hoc cleanups Andy Shevchenko
2026-02-17 10:15 ` [PATCH v1 1/7] iio: light: gp2ap020a00f: Use correct types for 16-bit LE data Andy Shevchenko
2026-02-17 10:15 ` [PATCH v1 2/7] iio: light: gp2ap020a00f: Replace custom implementation of min() Andy Shevchenko
2026-02-17 10:15 ` [PATCH v1 3/7] iio: light: gp2ap020a00f: Return directly from the switch cases Andy Shevchenko
2026-02-17 10:15 ` [PATCH v1 4/7] iio: light: gp2ap020a00f: Use temporary variable for struct device Andy Shevchenko
2026-02-17 10:15 ` Andy Shevchenko [this message]
2026-02-17 10:15 ` [PATCH v1 6/7] iio: light: gp2ap020a00f: Remove trailing comma in termination entry Andy Shevchenko
2026-02-17 10:15 ` [PATCH v1 7/7] iio: light: gp2ap020a00f: Join some lines of code to be a single line Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260217102318.1354103-6-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=ethantidmore06@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome