mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] ALSA: opl4: Add SPDX id lines to files in opl4 driver
@ 2026-02-17 23:22 Tim Bird
  2026-02-18  1:12 ` Richard Fontana
  0 siblings, 1 reply; 4+ messages in thread
From: Tim Bird @ 2026-02-17 23:22 UTC (permalink / raw)
  To: perex, tiwai, clemens, tglx, gregkh
  Cc: linux-spdx, linux-sound, linux-kernel, Tim Bird

Add a license file for the BSD-Source-Code license variant.
Add "SPDX-License-Identifier GPL-2.0-or-later OR BSD-Source-Code"
to files using this license and the 'Alternatively...' language.
Remove the boilerplate text from the files.

Signed-off-by: Tim Bird <tim.bird@sony.com>
---
 LICENSES/deprecated/BSD-Source-Code | 32 +++++++++++++++++++++++++++++
 sound/drivers/opl4/opl4_local.h     | 27 +-----------------------
 sound/drivers/opl4/opl4_seq.c       | 27 +-----------------------
 sound/drivers/opl4/opl4_synth.c     | 27 +-----------------------
 sound/drivers/opl4/yrw801.c         | 27 +-----------------------
 5 files changed, 36 insertions(+), 104 deletions(-)
 create mode 100644 LICENSES/deprecated/BSD-Source-Code

diff --git a/LICENSES/deprecated/BSD-Source-Code b/LICENSES/deprecated/BSD-Source-Code
new file mode 100644
index 000000000000..600cfea43526
--- /dev/null
+++ b/LICENSES/deprecated/BSD-Source-Code
@@ -0,0 +1,32 @@
+Valid-License-Identifier: BSD-Source-Code
+SPDX-URL: https://spdx.org/licenses/BSD-Source-Code.html
+Usage:
+  To use the BSD Source Code License, put the following SPDX tag/value
+  pair into a comment according to the placement guidelines in the
+  licensing rules documentation:
+    SPDX-License-Identifier: BSD-Source-Code
+License-Text:
+
+Copyright (c) <year> <owner> . All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are met:
+
+ - Redistributions of source code must retain the above copyright notice,
+   this list of conditions and the following disclaimer,
+   without modification.
+
+ - The name of the author may not be used to endorse or promote products
+   derived from this software without specific prior written permission.
+
+THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS "AS IS" AND
+ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE FOR
+ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+SUCH DAMAGE.
diff --git a/sound/drivers/opl4/opl4_local.h b/sound/drivers/opl4/opl4_local.h
index a16b4677c1e9..6dc223c6dc75 100644
--- a/sound/drivers/opl4/opl4_local.h
+++ b/sound/drivers/opl4/opl4_local.h
@@ -1,34 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later OR BSD-Source-Code */
 /*
  * Local definitions for the OPL4 driver
  *
  * Copyright (c) 2003 by Clemens Ladisch <clemens@ladisch.de>
  * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions, and the following disclaimer,
- *    without modification.
- * 2. The name of the author may not be used to endorse or promote products
- *    derived from this software without specific prior written permission.
- *
- * Alternatively, this software may be distributed and/or modified under the
- * terms of the GNU General Public License as published by the Free Software
- * Foundation; either version 2 of the License, or (at your option) any later
- * version.
- *
- * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
- * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
- * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE FOR
- * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
- * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
- * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
- * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
- * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
- * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
- * SUCH DAMAGE.
  */
 
 #ifndef __OPL4_LOCAL_H
diff --git a/sound/drivers/opl4/opl4_seq.c b/sound/drivers/opl4/opl4_seq.c
index 7bb22089a093..751b9f06aad8 100644
--- a/sound/drivers/opl4/opl4_seq.c
+++ b/sound/drivers/opl4/opl4_seq.c
@@ -1,34 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR BSD-Source-Code
 /*
  * OPL4 sequencer functions
  *
  * Copyright (c) 2003 by Clemens Ladisch <clemens@ladisch.de>
  * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions, and the following disclaimer,
- *    without modification.
- * 2. The name of the author may not be used to endorse or promote products
- *    derived from this software without specific prior written permission.
- *
- * Alternatively, this software may be distributed and/or modified under the
- * terms of the GNU General Public License as published by the Free Software
- * Foundation; either version 2 of the License, or (at your option) any later
- * version.
- *
- * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
- * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
- * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE FOR
- * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
- * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
- * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
- * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
- * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
- * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
- * SUCH DAMAGE.
  */
 
 #include "opl4_local.h"
diff --git a/sound/drivers/opl4/opl4_synth.c b/sound/drivers/opl4/opl4_synth.c
index 82dbb8519ab1..c3a91a348d9a 100644
--- a/sound/drivers/opl4/opl4_synth.c
+++ b/sound/drivers/opl4/opl4_synth.c
@@ -1,34 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR BSD-Source-Code
 /*
  * OPL4 MIDI synthesizer functions
  *
  * Copyright (c) 2003 by Clemens Ladisch <clemens@ladisch.de>
  * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions, and the following disclaimer,
- *    without modification.
- * 2. The name of the author may not be used to endorse or promote products
- *    derived from this software without specific prior written permission.
- *
- * Alternatively, this software may be distributed and/or modified under the
- * terms of the GNU General Public License as published by the Free Software
- * Foundation; either version 2 of the License, or (at your option) any later
- * version.
- *
- * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
- * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
- * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE FOR
- * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
- * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
- * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
- * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
- * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
- * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
- * SUCH DAMAGE.
  */
 
 #include "opl4_local.h"
diff --git a/sound/drivers/opl4/yrw801.c b/sound/drivers/opl4/yrw801.c
index 9e464b84b905..d7ce3ef9e6d4 100644
--- a/sound/drivers/opl4/yrw801.c
+++ b/sound/drivers/opl4/yrw801.c
@@ -1,34 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR BSD-Source-Code
 /*
  * Information about the Yamaha YRW801 wavetable ROM chip
  *
  * Copyright (c) 2003 by Clemens Ladisch <clemens@ladisch.de>
  * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions, and the following disclaimer,
- *    without modification.
- * 2. The name of the author may not be used to endorse or promote products
- *    derived from this software without specific prior written permission.
- *
- * Alternatively, this software may be distributed and/or modified under the
- * terms of the GNU General Public License as published by the Free Software
- * Foundation; either version 2 of the License, or (at your option) any later
- * version.
- *
- * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
- * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
- * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE FOR
- * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
- * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
- * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
- * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
- * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
- * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
- * SUCH DAMAGE.
  */
 
 #include "opl4_local.h"
-- 
2.43.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] ALSA: opl4: Add SPDX id lines to files in opl4 driver
  2026-02-17 23:22 [PATCH v2] ALSA: opl4: Add SPDX id lines to files in opl4 driver Tim Bird
@ 2026-02-18  1:12 ` Richard Fontana
  2026-02-18 17:48   ` Bird, Tim
  0 siblings, 1 reply; 4+ messages in thread
From: Richard Fontana @ 2026-02-18  1:12 UTC (permalink / raw)
  To: Tim Bird
  Cc: perex, tiwai, clemens, tglx, gregkh, linux-spdx, linux-sound,
	linux-kernel

On Tue, Feb 17, 2026 at 6:23 PM Tim Bird <tim.bird@sony.com> wrote:
>
> Add a license file for the BSD-Source-Code license variant.
> Add "SPDX-License-Identifier GPL-2.0-or-later OR BSD-Source-Code"
> to files using this license and the 'Alternatively...' language.
> Remove the boilerplate text from the files.

[. . .]
> +License-Text:
> +
> +Copyright (c) <year> <owner> . All rights reserved.
> +
> +Redistribution and use in source and binary forms, with or without
> +modification, are permitted provided that the following conditions are met:
> +
> + - Redistributions of source code must retain the above copyright notice,
> +   this list of conditions and the following disclaimer,
> +   without modification.
> +
> + - The name of the author may not be used to endorse or promote products
> +   derived from this software without specific prior written permission.
> +
> +THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS "AS IS" AND
> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> +IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> +ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE FOR
> +ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
> +DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
> +OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> +HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
> +LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
> +OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> +SUCH DAMAGE.

This isn't (at least not currently) `BSD-Source-Code`. See:
https://spdx.org/licenses/BSD-Source-Code.html
and https://github.com/spdx/license-list-XML/blob/main/src/BSD-Source-Code.xml

Richard


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH v2] ALSA: opl4: Add SPDX id lines to files in opl4 driver
  2026-02-18  1:12 ` Richard Fontana
@ 2026-02-18 17:48   ` Bird, Tim
  2026-02-18 19:57     ` Richard Fontana
  0 siblings, 1 reply; 4+ messages in thread
From: Bird, Tim @ 2026-02-18 17:48 UTC (permalink / raw)
  To: Richard Fontana
  Cc: perex, tiwai, clemens, tglx, gregkh, linux-spdx, linux-sound,
	linux-kernel



> -----Original Message-----
> From: Richard Fontana <rfontana@redhat.com>
> Sent: Tuesday, February 17, 2026 6:12 PM
> To: Bird, Tim <Tim.Bird@sony.com>
> Cc: perex@perex.cz; tiwai@suse.com; clemens@ladisch.de; tglx@kernel.org; gregkh@linuxfoundation.org; linux-spdx@vger.kernel.org;
> linux-sound@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2] ALSA: opl4: Add SPDX id lines to files in opl4 driver
> 
> On Tue, Feb 17, 2026 at 6: 23 PM Tim Bird <tim. bird@ sony. com> wrote: > > Add a license file for the BSD-Source-Code license variant. > Add
> "SPDX-License-Identifier GPL-2. 0-or-later OR BSD-Source-Code" > to files using this license
> 
> On Tue, Feb 17, 2026 at 6:23 PM Tim Bird <tim.bird@sony.com> wrote:
> >
> > Add a license file for the BSD-Source-Code license variant.
> > Add "SPDX-License-Identifier GPL-2.0-or-later OR BSD-Source-Code"
> > to files using this license and the 'Alternatively...' language.
> > Remove the boilerplate text from the files.
> 
> [. . .]
> > +License-Text:
> > +
> > +Copyright (c) <year> <owner> . All rights reserved.
> > +
> > +Redistribution and use in source and binary forms, with or without
> > +modification, are permitted provided that the following conditions are met:
> > +
> > + - Redistributions of source code must retain the above copyright notice,
> > +   this list of conditions and the following disclaimer,
> > +   without modification.
> > +
> > + - The name of the author may not be used to endorse or promote products
> > +   derived from this software without specific prior written permission.
> > +
> > +THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS "AS IS" AND
> > +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> > +IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> > +ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE FOR
> > +ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
> > +DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
> > +OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> > +HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
> > +LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
> > +OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> > +SUCH DAMAGE.
> 
> This isn't (at least not currently) `BSD-Source-Code`. See:
> https://spdx.org/licenses/BSD-Source-Code.html
> and https://github.com/spdx/license-list-XML/blob/main/src/BSD-Source-Code.xml

Yeah.  I used the wording from the files in the Linux kernel.  There are about 3 variations of
the wording for this license that I have found so far.  I included the URL for the SPDX version
in the kernel's license file in this patch.

Here is the wording from the SPDX site:
-----
Redistribution and use of this software in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

* Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.
* Neither the name of Deusty nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission of Deusty, LLC.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-----

While there *are* textual differences, I believe the two versions of the text are semantically equivalent.

The one in the patch was submitted by Clemens Ladisch in the original opl4 driver submission.  I haven't
done an exact count yet, but I believe this variant of the wording is used in more places than other
variants in the kernel.  My preference is to use the wording variant that was most commonly used
by kernel contributors, so that the kernel's LICENSE file matches the most places where the license
text was replaced with an SPDX-License-Identifier line.

I've been trying to avoid having to make a kernel LICENSE file for every minor variant of otherwise
semantically the same license text.  I believe dealing with this plethora of license variants is one reason the
SPDX work stalled out previously.

Let me know if you think the text in the kernel's License file  (for a given license) must be an exact match
for the spdx web site text for the license.  A separate question is whether it's appropriate to use the same
SPDX ID for variations on the same license text.  I believe it is, in this case, but I'm open to hearing
other opinions.
 -- Tim


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] ALSA: opl4: Add SPDX id lines to files in opl4 driver
  2026-02-18 17:48   ` Bird, Tim
@ 2026-02-18 19:57     ` Richard Fontana
  0 siblings, 0 replies; 4+ messages in thread
From: Richard Fontana @ 2026-02-18 19:57 UTC (permalink / raw)
  To: Bird, Tim
  Cc: perex, tiwai, clemens, tglx, gregkh, linux-spdx, linux-sound,
	linux-kernel

On Wed, Feb 18, 2026 at 12:48 PM Bird, Tim <Tim.Bird@sony.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Richard Fontana <rfontana@redhat.com>
> > Sent: Tuesday, February 17, 2026 6:12 PM
> > To: Bird, Tim <Tim.Bird@sony.com>
> > Cc: perex@perex.cz; tiwai@suse.com; clemens@ladisch.de; tglx@kernel.org; gregkh@linuxfoundation.org; linux-spdx@vger.kernel.org;
> > linux-sound@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH v2] ALSA: opl4: Add SPDX id lines to files in opl4 driver
> >
> > On Tue, Feb 17, 2026 at 6: 23 PM Tim Bird <tim. bird@ sony. com> wrote: > > Add a license file for the BSD-Source-Code license variant. > Add
> > "SPDX-License-Identifier GPL-2. 0-or-later OR BSD-Source-Code" > to files using this license
> >
> > On Tue, Feb 17, 2026 at 6:23 PM Tim Bird <tim.bird@sony.com> wrote:
> > >
> > > Add a license file for the BSD-Source-Code license variant.
> > > Add "SPDX-License-Identifier GPL-2.0-or-later OR BSD-Source-Code"
> > > to files using this license and the 'Alternatively...' language.
> > > Remove the boilerplate text from the files.
> >
> > [. . .]
> > > +License-Text:
> > > +
> > > +Copyright (c) <year> <owner> . All rights reserved.
> > > +
> > > +Redistribution and use in source and binary forms, with or without
> > > +modification, are permitted provided that the following conditions are met:
> > > +
> > > + - Redistributions of source code must retain the above copyright notice,
> > > +   this list of conditions and the following disclaimer,
> > > +   without modification.
> > > +
> > > + - The name of the author may not be used to endorse or promote products
> > > +   derived from this software without specific prior written permission.
> > > +
> > > +THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS "AS IS" AND
> > > +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> > > +IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> > > +ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE FOR
> > > +ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
> > > +DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
> > > +OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> > > +HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
> > > +LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
> > > +OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> > > +SUCH DAMAGE.
> >
> > This isn't (at least not currently) `BSD-Source-Code`. See:
> > https://spdx.org/licenses/BSD-Source-Code.html
> > and https://github.com/spdx/license-list-XML/blob/main/src/BSD-Source-Code.xml
>
> Yeah.  I used the wording from the files in the Linux kernel.  There are about 3 variations of
> the wording for this license that I have found so far.  I included the URL for the SPDX version
> in the kernel's license file in this patch.
>
> Here is the wording from the SPDX site:
> -----
> Redistribution and use of this software in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
>
> * Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.
> * Neither the name of Deusty nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission of Deusty, LLC.
>
> THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> -----
>
> While there *are* textual differences, I believe the two versions of the text are semantically equivalent.
>
> The one in the patch was submitted by Clemens Ladisch in the original opl4 driver submission.  I haven't
> done an exact count yet, but I believe this variant of the wording is used in more places than other
> variants in the kernel.  My preference is to use the wording variant that was most commonly used
> by kernel contributors, so that the kernel's LICENSE file matches the most places where the license
> text was replaced with an SPDX-License-Identifier line.
>
> I've been trying to avoid having to make a kernel LICENSE file for every minor variant of otherwise
> semantically the same license text.  I believe dealing with this plethora of license variants is one reason the
> SPDX work stalled out previously.
>
> Let me know if you think the text in the kernel's License file  (for a given license) must be an exact match
> for the spdx web site text for the license.  A separate question is whether it's appropriate to use the same
> SPDX ID for variations on the same license text.  I believe it is, in this case, but I'm open to hearing
> other opinions.

Based on your issue
https://github.com/spdx/license-list-XML/issues/2939 I think you know
this but for the sake of others: The issue is that from the SPDX
standpoint, the identifiers are (somewhat) precisely defined.
`BSD-Source-Code`, for example, is specified in the XML file I
previously linked to. SPDX has a more informally defined notion of
what it means for a real license text to "match" a given identifier,
mostly discussed here:
https://spdx.github.io/spdx-spec/v3.0.1/annexes/license-matching-guidelines-and-templates/

I'd suggest perhaps waiting for SPDX to resolve the open issue - you
see that Steve Winslow seems inclined to add a new identifier for this
variant.

Richard


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-02-18 19:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-17 23:22 [PATCH v2] ALSA: opl4: Add SPDX id lines to files in opl4 driver Tim Bird
2026-02-18  1:12 ` Richard Fontana
2026-02-18 17:48   ` Bird, Tim
2026-02-18 19:57     ` Richard Fontana

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®