mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] drm/sun4i: mixer: Fix layer init code
@ 2026-02-18 18:34 Jernej Skrabec
  2026-02-19  3:51 ` Chen-Yu Tsai
  2026-02-24 17:50 ` Chen-Yu Tsai
  0 siblings, 2 replies; 3+ messages in thread
From: Jernej Skrabec @ 2026-02-18 18:34 UTC (permalink / raw)
  To: wens
  Cc: maarten.lankhorst, mripard, tzimmermann, airlied, simona, samuel,
	dri-devel, linux-arm-kernel, linux-sunxi, linux-kernel,
	Jernej Skrabec

Code refactoring dropped extra NULL sentinel entry at the end of the drm
planes array.

Add it back.

Reported-by: Chen-Yu Tsai <wens@kernel.org>
Closes: https://lore.kernel.org/linux-sunxi/CAGb2v65wY2pF6sR+0JgnpLa4ysvjght5hAKDa1RUyo=zEKXreg@mail.gmail.com/
Fixes: 5fd711adc0ba ("drm/sun4i: layer: move num of planes calc out of layer code")
Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
---
 drivers/gpu/drm/sun4i/sun8i_mixer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/sun8i_mixer.c
index ce9c155bfad7..02acc7cbdb97 100644
--- a/drivers/gpu/drm/sun4i/sun8i_mixer.c
+++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c
@@ -321,7 +321,7 @@ static struct drm_plane **sun8i_layers_init(struct drm_device *drm,
 	unsigned int phy_index;
 	int i;
 
-	planes = devm_kcalloc(drm->dev, plane_cnt, sizeof(*planes), GFP_KERNEL);
+	planes = devm_kcalloc(drm->dev, plane_cnt + 1, sizeof(*planes), GFP_KERNEL);
 	if (!planes)
 		return ERR_PTR(-ENOMEM);
 
-- 
2.53.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/sun4i: mixer: Fix layer init code
  2026-02-18 18:34 [PATCH] drm/sun4i: mixer: Fix layer init code Jernej Skrabec
@ 2026-02-19  3:51 ` Chen-Yu Tsai
  2026-02-24 17:50 ` Chen-Yu Tsai
  1 sibling, 0 replies; 3+ messages in thread
From: Chen-Yu Tsai @ 2026-02-19  3:51 UTC (permalink / raw)
  To: Jernej Skrabec
  Cc: maarten.lankhorst, mripard, tzimmermann, airlied, simona, samuel,
	dri-devel, linux-arm-kernel, linux-sunxi, linux-kernel

On Thu, Feb 19, 2026 at 2:35 AM Jernej Skrabec <jernej.skrabec@gmail.com> wrote:
>
> Code refactoring dropped extra NULL sentinel entry at the end of the drm
> planes array.
>
> Add it back.
>
> Reported-by: Chen-Yu Tsai <wens@kernel.org>
> Closes: https://lore.kernel.org/linux-sunxi/CAGb2v65wY2pF6sR+0JgnpLa4ysvjght5hAKDa1RUyo=zEKXreg@mail.gmail.com/
> Fixes: 5fd711adc0ba ("drm/sun4i: layer: move num of planes calc out of layer code")
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> ---

Reviewed-by: Chen-Yu Tsai <wens@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/sun4i: mixer: Fix layer init code
  2026-02-18 18:34 [PATCH] drm/sun4i: mixer: Fix layer init code Jernej Skrabec
  2026-02-19  3:51 ` Chen-Yu Tsai
@ 2026-02-24 17:50 ` Chen-Yu Tsai
  1 sibling, 0 replies; 3+ messages in thread
From: Chen-Yu Tsai @ 2026-02-24 17:50 UTC (permalink / raw)
  To: Jernej Skrabec
  Cc: maarten.lankhorst, mripard, tzimmermann, airlied, simona, samuel,
	dri-devel, linux-arm-kernel, linux-sunxi, linux-kernel

On Wed, 18 Feb 2026 19:34:54 +0100, Jernej Skrabec wrote:
> Code refactoring dropped extra NULL sentinel entry at the end of the drm
> planes array.
> 
> Add it back.
> 
> 

Applied to drm-misc-next in drm-misc, thanks!

[1/1] drm/sun4i: mixer: Fix layer init code
      commit: 744629904c68bde847c31819f23482d09152f810

Best regards,
-- 
Chen-Yu Tsai <wens@kernel.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-02-24 17:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-18 18:34 [PATCH] drm/sun4i: mixer: Fix layer init code Jernej Skrabec
2026-02-19  3:51 ` Chen-Yu Tsai
2026-02-24 17:50 ` Chen-Yu Tsai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®