mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
To: gregkh@linuxfoundation.org
Cc: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org,
	elder@kernel.org, greybus-dev@lists.linaro.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: greybus: audio: Use sysfs_emit in show functions
Date: Wed, 25 Feb 2026 00:35:04 +0530	[thread overview]
Message-ID: <20260224190506.23334-1-chakrabortyshubham66@gmail.com> (raw)
In-Reply-To: <2026022438-gamma-blog-1561@gregkh>

Hi Greg,

You are right. The \n additions were a mistake on my part — the original
sprintf calls did not include \n and I should not have changed the output
behavior in the same patch.

I will send a v4 that does a pure mechanical conversion from sprintf to
sysfs_emit with no change in output, keeping the format strings identical
to the originals.

Thank you for the review.

Shubham

      reply	other threads:[~2026-02-24 19:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23 18:11 Shubham Chakraborty
2026-02-24 18:09 ` Greg Kroah-Hartman
2026-02-24 19:05   ` Shubham Chakraborty [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260224190506.23334-1-chakrabortyshubham66@gmail.com \
    --to=chakrabortyshubham66@gmail.com \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mgreer@animalcreek.com \
    --cc=vaibhav.sr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®